c18a8560ad3ad6ff3386ac43bb6c5622272745d0
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Push Down Method | 2 | ||
| Push Down Method protected checkExpiringObjects() : void from class com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller.SingularityExpiringUserActionHandler to protected checkExpiringObjects() : void from class com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller.SingularityExpiringRequestActionHandler | From | To | |
| Push Down Method public getRequestId() : String from class com.hubspot.singularity.expiring.SingularityExpiringParent to public getRequestId() : String from class com.hubspot.singularity.expiring.SingularityExpiringRequestActionParent | From | To | |
| Push Down Attribute | 1 | ||
| Push Down Attribute private requestId : String from class com.hubspot.singularity.expiring.SingularityExpiringParent to private requestId : String from class com.hubspot.singularity.expiring.SingularityExpiringRequestActionParent | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass com.hubspot.singularity.expiring.SingularityExpiringRequestActionParent from classes [com.hubspot.singularity.expiring.SingularityExpiringBounce, com.hubspot.singularity.expiring.SingularityExpiringPause, com.hubspot.singularity.expiring.SingularityExpiringScale, com.hubspot.singularity.expiring.SingularityExpiringSkipHealthchecks] | From | To | |
| Extract Superclass com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller.SingularityExpiringRequestActionHandler from classes [com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller.SingularityExpiringBounceHandler, com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller.SingularityExpiringPauseHandler, com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller.SingularityExpiringScaleHandler, com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller.SingularityExpiringSkipHealthchecksHandler] | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type handler : SingularityExpiringUserActionHandler<?> to handler : SingularityExpiringUserActionHandler<?,?> in method public runActionOnPoll() : void in class com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller | From | To | |
| Change Variable Type tempHandlers : List<SingularityExpiringUserActionHandler<?>> to tempHandlers : List<SingularityExpiringUserActionHandler<?,?>> in method package SingularityExpiringUserActionPoller(configuration SingularityConfiguration, requestManager RequestManager, taskManager TaskManager, slaveManager SlaveManager, rackManager RackManager, lock Lock, requestHelper RequestHelper, mailer SingularityMailer) in class com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type handlers : List<SingularityExpiringUserActionHandler<?>> to handlers : List<SingularityExpiringUserActionHandler<?,?>> in class com.hubspot.singularity.scheduler.SingularityExpiringUserActionPoller | From | To | |
| Change Attribute Type EXPIRING_CLASS_TO_PATH : Map<Class<? extends SingularityExpiringParent<? extends SingularityExpiringRequestParent>>,String> to EXPIRING_CLASS_TO_PATH : Map<Class<? extends SingularityExpiringRequestActionParent<? extends SingularityExpiringRequestParent>>,String> in class com.hubspot.singularity.data.RequestManager | From | To | |
| Change Attribute Type expiringTranscoderMap : Map<Class<? extends SingularityExpiringParent<? extends SingularityExpiringRequestParent>>,Transcoder<? extends SingularityExpiringParent<? extends SingularityExpiringRequestParent>>> to expiringTranscoderMap : Map<Class<? extends SingularityExpiringRequestActionParent<? extends SingularityExpiringRequestParent>>,Transcoder<? extends SingularityExpiringRequestActionParent<? extends SingularityExpiringRequestParent>>> in class com.hubspot.singularity.data.RequestManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter decomissionRequest : Optional<SingularityMachineChangeRequest> to decommissionRequest : Optional<SingularityMachineChangeRequest> in method protected decommission(objectId String, decommissionRequest Optional<SingularityMachineChangeRequest>, queryUser Optional<String>, action SingularityAction) : void in class com.hubspot.singularity.resources.AbstractMachineResource | From | To |