c5291147415425a3821ecb2e3cc3ce8be3d5da7b
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 2 | ||
| Move Method private rebalanceRacks(request SingularityRequest, state RequestState, deployStatistics SingularityDeployStatistics, pendingRequest SingularityPendingRequest, maybePendingDeploy Optional<SingularityPendingDeploy>, now long, remainingActiveTasks List<SingularityTaskId>) : void from class com.hubspot.singularity.scheduler.SingularityScheduler to public rebalanceRacks(request SingularityRequest, remainingActiveTasks List<SingularityTaskId>, user Optional<String>) : List<SingularityTaskId> from class com.hubspot.singularity.helpers.RebalancingHelper | From | To | |
| Move Method private rebalanceAttributeDistribution(request SingularityRequest, state RequestState, deployStatistics SingularityDeployStatistics, pendingRequest SingularityPendingRequest, maybePendingDeploy Optional<SingularityPendingDeploy>, now long, remainingActiveTasks List<SingularityTaskId>) : void from class com.hubspot.singularity.scheduler.SingularityScheduler to public rebalanceAttributeDistribution(request SingularityRequest, user Optional<String>, remainingActiveTasks List<SingularityTaskId>) : Set<SingularityTaskId> from class com.hubspot.singularity.helpers.RebalancingHelper | From | To | |
| Rename Variable | 1 | ||
| Rename Variable instance10 : SingularityTask to allTasks : Map<SingularityTaskId,SingularityTask> in method public testSlaveAttributesAreRedistributedOnScaleDown() : void in class com.hubspot.singularity.scheduler.SingularitySlavePlacementTest | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to Set<SingularityTaskId> in method public rebalanceAttributeDistribution(request SingularityRequest, user Optional<String>, remainingActiveTasks List<SingularityTaskId>) : Set<SingularityTaskId> in class com.hubspot.singularity.helpers.RebalancingHelper | From | To | |
| Change Return Type void to List<SingularityTaskId> in method public rebalanceRacks(request SingularityRequest, remainingActiveTasks List<SingularityTaskId>, user Optional<String>) : List<SingularityTaskId> in class com.hubspot.singularity.helpers.RebalancingHelper | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type instance10 : SingularityTask to allTasks : Map<SingularityTaskId,SingularityTask> in method public testSlaveAttributesAreRedistributedOnScaleDown() : void in class com.hubspot.singularity.scheduler.SingularitySlavePlacementTest | From | To |