c742307eb1e8a5a3a67558fb6c4b9654bc4058a8
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type taskRequests : Collection<SingularityTaskRequest> to taskRequests : Collection<SingularityTaskRequestHolder> in method private match(taskRequests Collection<SingularityTaskRequestHolder>, stateCache SingularitySchedulerStateCache, offerHolder SingularityOfferHolder, tasksPerOfferPerRequest Map<String,Map<String,Integer>>) : Optional<SingularityTask> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Rename Variable | 1 | ||
Rename Variable taskRequests : List<SingularityTaskRequest> to pendingTaskIdToTaskRequest : Map<String,SingularityTaskRequestHolder> in method public checkOffers(offers List<Protos.Offer>, acceptedOffers Set<Protos.OfferID>) : List<SingularityOfferHolder> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Change Variable Type | 1 | ||
Change Variable Type taskRequests : List<SingularityTaskRequest> to pendingTaskIdToTaskRequest : Map<String,SingularityTaskRequestHolder> in method public checkOffers(offers List<Protos.Offer>, acceptedOffers Set<Protos.OfferID>) : List<SingularityOfferHolder> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
Extract Method | 1 | ||
Extract Method private getDueTaskRequestHolders() : Map<String,SingularityTaskRequestHolder> extracted from public checkOffers(offers List<Protos.Offer>, acceptedOffers Set<Protos.OfferID>) : List<SingularityOfferHolder> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To |