cef1df4c3870014fab8572d1ffd7124d96fb143f
Files Diff
- Added: 6
- Removed: 2
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type parameters : Optional<List<SingularityDockerParameter>> to parameters : Optional<SingularityDockerParameters> in method public SingularityDockerInfo(image String, privileged boolean, network SingularityDockerNetworkType, portMappings Optional<List<SingularityDockerPortMapping>>, forcePullImage Optional<Boolean>, parameters Optional<SingularityDockerParameters>) in class com.hubspot.mesos.SingularityDockerInfo | From | To | |
| Change Parameter Type labels : Optional<List<SingularityMesosTaskLabel>> to labels : Optional<SingularityMesosTaskLabels> in method public SingularityDeploy(requestId String, id String, command Optional<String>, arguments Optional<List<String>>, containerInfo Optional<SingularityContainerInfo>, customExecutorCmd Optional<String>, customExecutorId Optional<String>, customExecutorSource Optional<String>, customExecutorResources Optional<Resources>, customExecutorUser Optional<String>, resources Optional<Resources>, env Optional<Map<String,String>>, taskEnv Optional<Map<Integer,Map<String,String>>>, uris Optional<List<String>>, metadata Optional<Map<String,String>>, executorData Optional<ExecutorData>, version Optional<String>, timestamp Optional<Long>, labels Optional<SingularityMesosTaskLabels>, taskLabels Optional<Map<Integer,Map<String,String>>>, deployHealthTimeoutSeconds Optional<Long>, healthcheckUri Optional<String>, healthcheckIntervalSeconds Optional<Long>, healthcheckTimeoutSeconds Optional<Long>, healthcheckPortIndex Optional<Integer>, healthcheckMaxRetries Optional<Integer>, healthcheckMaxTotalTimeoutSeconds Optional<Long>, serviceBasePath Optional<String>, loadBalancerGroups Optional<Set<String>>, loadBalancerPortIndex Optional<Integer>, considerHealthyAfterRunningForSeconds Optional<Long>, loadBalancerOptions Optional<Map<String,Object>>, loadBalancerDomains Optional<Set<String>>, loadBalancerAdditionalRoutes Optional<List<String>>, loadBalancerTemplate Optional<String>, skipHealthchecksOnDeploy Optional<Boolean>, healthcheckProtocol Optional<HealthcheckProtocol>, deployInstanceCountPerStep Optional<Integer>, deployStepWaitTimeMs Optional<Integer>, autoAdvanceDeploySteps Optional<Boolean>, maxTaskRetries Optional<Integer>, shell Optional<Boolean>) in class com.hubspot.singularity.SingularityDeploy | From | To | |
| Change Parameter Type labels : Optional<List<SingularityMesosTaskLabel>> to labels : Optional<SingularityMesosTaskLabels> in method public setLabels(labels Optional<SingularityMesosTaskLabels>) : SingularityDeployBuilder in class com.hubspot.singularity.SingularityDeployBuilder | From | To | |
| Change Return Type | 5 | ||
| Change Return Type Optional<List<SingularityMesosTaskLabel>> to Optional<SingularityMesosTaskLabels> in method public getLabels() : Optional<SingularityMesosTaskLabels> in class com.hubspot.singularity.SingularityDeploy | From | To | |
| Change Return Type List<SingularityMesosTaskLabel> to SingularityMesosTaskLabels in method public deserialize(jp JsonParser, ctxt DeserializationContext) : SingularityMesosTaskLabels in class com.hubspot.mesos.SingularityMesosTaskLabelsDeserializer | From | To | |
| Change Return Type List<SingularityDockerParameter> to SingularityDockerParameters in method public deserialize(jp JsonParser, ctxt DeserializationContext) : SingularityDockerParameters in class com.hubspot.mesos.SingularityDockerParametersDeserializer | From | To | |
| Change Return Type List<SingularityDockerParameter> to Optional<SingularityDockerParameters> in method public getParameters() : Optional<SingularityDockerParameters> in class com.hubspot.mesos.SingularityDockerInfo | From | To | |
| Change Return Type Optional<List<SingularityMesosTaskLabel>> to Optional<SingularityMesosTaskLabels> in method public getLabels() : Optional<SingularityMesosTaskLabels> in class com.hubspot.singularity.SingularityDeployBuilder | From | To | |
| Move Class | 2 | ||
| Move Class com.hubspot.singularity.SingularityMesosTaskLabelsDeserializer moved to com.hubspot.mesos.SingularityMesosTaskLabelsDeserializer | From | To | |
| Move Class com.hubspot.singularity.SingularityMesosTaskLabel moved to com.hubspot.mesos.SingularityMesosTaskLabel | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type labels : Optional<List<SingularityMesosTaskLabel>> to labels : Optional<SingularityMesosTaskLabels> in class com.hubspot.singularity.SingularityDeployBuilder | From | To | |
| Change Attribute Type parameters : List<SingularityDockerParameter> to parameters : Optional<SingularityDockerParameters> in class com.hubspot.mesos.SingularityDockerInfo | From | To | |
| Change Attribute Type labels : Optional<List<SingularityMesosTaskLabel>> to labels : Optional<SingularityMesosTaskLabels> in class com.hubspot.singularity.SingularityDeploy | From | To |