d9c4dbf862357ae0c1593233f83c930a7114b5cc
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private getActivePath(taskId String) : String renamed to private getPendingForRequestPath(requestId String) : String in class com.hubspot.singularity.data.TaskManager | From | To | |
Change Parameter Type | 3 | ||
Change Parameter Type taskId : String to taskId : SingularityTaskId in method public deleteActiveTaskId(taskId SingularityTaskId) : void in class com.hubspot.singularity.scheduler.SingularityLeaderCache | From | To | |
Change Parameter Type taskId : String to taskId : SingularityTaskId in method public isActiveTask(taskId SingularityTaskId) : boolean in class com.hubspot.singularity.scheduler.SingularityLeaderCache | From | To | |
Change Parameter Type taskId : String to taskId : SingularityTaskId in method public isActiveTask(taskId SingularityTaskId) : boolean in class com.hubspot.singularity.data.TaskManager | From | To | |
Rename Variable | 2 | ||
Rename Variable matchingTask : SingularityPendingTask to matchingTaskId : SingularityPendingTaskId in method private processRequestCleanup(start long, numTasksKilled AtomicInteger, numScheduledTasksRemoved AtomicInteger, requestCleanup SingularityRequestCleanup) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
Rename Variable pendingTasks : List<SingularityPendingTask> to pendingTaskIds : List<SingularityPendingTaskId> in method private processRequestCleanup(start long, numTasksKilled AtomicInteger, numScheduledTasksRemoved AtomicInteger, requestCleanup SingularityRequestCleanup) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
Change Variable Type | 2 | ||
Change Variable Type matchingTask : SingularityPendingTask to matchingTaskId : SingularityPendingTaskId in method private processRequestCleanup(start long, numTasksKilled AtomicInteger, numScheduledTasksRemoved AtomicInteger, requestCleanup SingularityRequestCleanup) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
Change Variable Type pendingTasks : List<SingularityPendingTask> to pendingTaskIds : List<SingularityPendingTaskId> in method private processRequestCleanup(start long, numTasksKilled AtomicInteger, numScheduledTasksRemoved AtomicInteger, requestCleanup SingularityRequestCleanup) : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
Rename Parameter | 1 | ||
Rename Parameter taskId : String to requestId : String in method private getPendingForRequestPath(requestId String) : String in class com.hubspot.singularity.data.TaskManager | From | To |