dc1d0364ea526eac3e9d317405c43dc9b2f31594
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type statusUpdateDeltaTimer : Timer to statusUpdateDeltas : ConcurrentHashMap<Long,Long> in method public SingularityMesosStatusUpdateHandler(taskManager TaskManager, deployManager DeployManager, requestManager RequestManager, taskIdTranscoder IdTranscoder<SingularityTaskId>, exceptionNotifier SingularityExceptionNotifier, healthchecker SingularityHealthchecker, newTaskChecker SingularityNewTaskChecker, slaveAndRackManager SingularitySlaveAndRackManager, logSupport SingularityMesosExecutorInfoSupport, scheduler SingularityScheduler, stateCacheProvider Provider<SingularitySchedulerStateCache>, serverId String, schedulerDriverSupplier SchedulerDriverSupplier, schedulerLock SingularitySchedulerLock, configuration SingularityConfiguration, taskLostReasons Multiset<Protos.TaskStatus.Reason>, lostTasksMeter Meter, statusUpdateDeltas ConcurrentHashMap<Long,Long>) in class com.hubspot.singularity.mesos.SingularityMesosStatusUpdateHandler | From | To | |
| Rename Variable | 2 | ||
| Rename Variable offerResult : SingularityOfferProcessingResult to offerHolders : List<SingularityOfferHolder> in method public runActionOnPoll() : void in class com.hubspot.singularity.scheduler.SingularitySchedulerPoller | From | To | |
| Rename Variable offerResult : SingularityOfferProcessingResult to offerHolders : List<SingularityOfferHolder> in method public resourceOffers(driver SchedulerDriver, offers List<Protos.Offer>) : void in class com.hubspot.singularity.mesos.SingularityMesosScheduler | From | To | |
| Change Return Type | 1 | ||
| Change Return Type SingularityOfferProcessingResult to List<SingularityOfferHolder> in method public checkOffers(offers Collection<Protos.Offer>) : List<SingularityOfferHolder> in class com.hubspot.singularity.mesos.SingularityMesosOfferScheduler | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute statusUpdateDeltaTimer : Timer to statusUpdateDeltas : ConcurrentHashMap<Long,Long> in class com.hubspot.singularity.mesos.SingularityMesosStatusUpdateHandler | From | To | |
| Extract Variable | 1 | ||
| Extract Variable now : long in method private unsafeProcessStatusUpdate(status Protos.TaskStatus) : void from class com.hubspot.singularity.mesos.SingularityMesosStatusUpdateHandler | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type offerResult : SingularityOfferProcessingResult to offerHolders : List<SingularityOfferHolder> in method public resourceOffers(driver SchedulerDriver, offers List<Protos.Offer>) : void in class com.hubspot.singularity.mesos.SingularityMesosScheduler | From | To | |
| Change Variable Type offerResult : SingularityOfferProcessingResult to offerHolders : List<SingularityOfferHolder> in method public runActionOnPoll() : void in class com.hubspot.singularity.scheduler.SingularitySchedulerPoller | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type statusUpdateDeltaTimer : Timer to statusUpdateDeltas : ConcurrentHashMap<Long,Long> in class com.hubspot.singularity.mesos.SingularityMesosStatusUpdateHandler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter statusUpdateDeltaTimer : Timer to statusUpdateDeltas : ConcurrentHashMap<Long,Long> in method public SingularityMesosStatusUpdateHandler(taskManager TaskManager, deployManager DeployManager, requestManager RequestManager, taskIdTranscoder IdTranscoder<SingularityTaskId>, exceptionNotifier SingularityExceptionNotifier, healthchecker SingularityHealthchecker, newTaskChecker SingularityNewTaskChecker, slaveAndRackManager SingularitySlaveAndRackManager, logSupport SingularityMesosExecutorInfoSupport, scheduler SingularityScheduler, stateCacheProvider Provider<SingularitySchedulerStateCache>, serverId String, schedulerDriverSupplier SchedulerDriverSupplier, schedulerLock SingularitySchedulerLock, configuration SingularityConfiguration, taskLostReasons Multiset<Protos.TaskStatus.Reason>, lostTasksMeter Meter, statusUpdateDeltas ConcurrentHashMap<Long,Long>) in class com.hubspot.singularity.mesos.SingularityMesosStatusUpdateHandler | From | To |