f055d9bccf1bfd1b9824554e1f3fc9576684f705
Files Diff
- Added: 0
 - Removed: 0
 - Renamed: 0
 - Modified: 4
 
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public setMaxStaleRequestsInZkWhenNoDatabase(maxStaleRequestsInZkWhenNoDatabase Optional<Integer>) : void renamed to public setMaxRequestHistoryUpdatesPerRequestInZkWhenNoDatabase(maxRequestHistoryUpdatesPerRequestInZkWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Rename Method public getMaxStaleRequestsInZkWhenNoDatabase() : Optional<Integer> renamed to public getMaxRequestHistoryUpdatesPerRequestInZkWhenNoDatabase() : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type object : SingularityRequestHistoryParent to object : SingularityRequestHistory in method protected moveToHistory(object SingularityRequestHistory) : boolean in class com.hubspot.singularity.data.history.SingularityRequestHistoryPersister | From | To | |
| Change Parameter Type object : SingularityRequestHistoryParent to object : SingularityRequestHistory in method protected purgeFromZk(object SingularityRequestHistory) : SingularityDeleteResult in class com.hubspot.singularity.data.history.SingularityRequestHistoryPersister | From | To | |
| Move Method | 1 | ||
| Move Method public getCreateTimestampForCalculatingHistoryAge() : long from class com.hubspot.singularity.data.history.SingularityRequestHistoryPersister.SingularityRequestHistoryParent to public getCreateTimestampForCalculatingHistoryAge() : long from class com.hubspot.singularity.SingularityRequestHistory | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable requestHistory : SingularityRequestHistory to object : SingularityRequestHistory in method protected moveToHistory(object SingularityRequestHistory) : boolean in class com.hubspot.singularity.data.history.SingularityRequestHistoryPersister | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute maxStaleRequestsInZkWhenNoDatabase : Optional<Integer> to maxRequestHistoryUpdatesPerRequestInZkWhenNoDatabase : Optional<Integer> in class com.hubspot.singularity.config.SingularityConfiguration | From | To | |
| Extract Variable | 3 | ||
| Extract Variable actionTwoTimestamp : long in method public testRequestCountPurging() : void from class com.hubspot.singularity.scheduler.HistoryPersisterTest | From | To | |
| Extract Variable requestIds : List<String> in method public runActionOnPoll() : void from class com.hubspot.singularity.data.history.SingularityRequestHistoryPersister | From | To | |
| Extract Variable actionOneTimestamp : long in method public testRequestCountPurging() : void from class com.hubspot.singularity.scheduler.HistoryPersisterTest | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter maxStaleRequestsInZkWhenNoDatabase : Optional<Integer> to maxRequestHistoryUpdatesPerRequestInZkWhenNoDatabase : Optional<Integer> in method public setMaxRequestHistoryUpdatesPerRequestInZkWhenNoDatabase(maxRequestHistoryUpdatesPerRequestInZkWhenNoDatabase Optional<Integer>) : void in class com.hubspot.singularity.config.SingularityConfiguration | From | To |