f18573dc754134be129cd5a71600a744794c19b9
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type deployMarker : SingularityDeployMarker to pendingDeploy : SingularityPendingDeploy in method private getLoadBalancerRequestId(pendingDeploy SingularityPendingDeploy) : LoadBalancerRequestId in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Change Parameter Type lbUpdate : SingularityLoadBalancerUpdate to lbUpdate : Optional<SingularityLoadBalancerUpdate> in method private updatePendingDeploy(pendingDeploy SingularityPendingDeploy, lbUpdate Optional<SingularityLoadBalancerUpdate>, deployState DeployState, deployProgress Optional<SingularityDeployProgress>) : void in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method | 4 | ||
| Extract Method private checkOverdue(deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, isOverdue boolean) : SingularityDeployResult extracted from private getDeployResult(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, deployKey SingularityDeployKey, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>, inactiveDeployMatchingTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method private checkDeployProgress(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>) : SingularityDeployResult extracted from private getDeployResult(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, deployKey SingularityDeployKey, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>, inactiveDeployMatchingTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method private updatePendingDeploy(pendingDeploy SingularityPendingDeploy, lbUpdate Optional<SingularityLoadBalancerUpdate>, deployState DeployState) : void extracted from private cancelLoadBalancer(pendingDeploy SingularityPendingDeploy) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Extract Method private isWaitingForCurrentLbRequest(pendingDeploy SingularityPendingDeploy) : boolean extracted from private getDeployResult(request SingularityRequest, cancelRequest Optional<SingularityDeployMarker>, pendingDeploy SingularityPendingDeploy, deployKey SingularityDeployKey, deploy Optional<SingularityDeploy>, deployActiveTasks Collection<SingularityTaskId>, otherActiveTasks Collection<SingularityTaskId>, inactiveDeployMatchingTasks Collection<SingularityTaskId>) : SingularityDeployResult in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter deployMarker : SingularityDeployMarker to pendingDeploy : SingularityPendingDeploy in method private getLoadBalancerRequestId(pendingDeploy SingularityPendingDeploy) : LoadBalancerRequestId in class com.hubspot.singularity.scheduler.SingularityDeployChecker | From | To |