f9b248c029e483a2da7728aeddd5501e478b1688
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 1 | ||
| Rename Variable incrementalBounceCleaningTasks : Multiset<SingularityDeployKey> to incrementalCleaningTasks : Multiset<SingularityDeployKey> in method private drainTaskCleanupQueue() : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable cleanupTask : SingularityTaskCleanup to taskCleanup : SingularityTaskCleanup in method private isIncrementalCleanup(taskCleanup SingularityTaskCleanup) : boolean in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Extract Method | 2 | ||
| Extract Method private isIncrementalCleanup(taskCleanup SingularityTaskCleanup) : boolean extracted from private shouldKillTask(taskCleanup SingularityTaskCleanup, activeTaskIds List<SingularityTaskId>, cleaningTasks List<SingularityTaskId>, incrementalBounceCleaningTasks Multiset<SingularityDeployKey>) : boolean in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Extract Method private isIncrementalCleanup(taskCleanup SingularityTaskCleanup) : boolean extracted from private drainTaskCleanupQueue() : void in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter activeDeployId : String to deployId : String in method private getNumHealthyTasks(request SingularityRequest, deployId String, matchingTasks List<SingularityTaskId>) : int in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To | |
| Rename Parameter incrementalBounceCleaningTasks : Multiset<SingularityDeployKey> to incrementalCleaningTasks : Multiset<SingularityDeployKey> in method private shouldKillTask(taskCleanup SingularityTaskCleanup, activeTaskIds List<SingularityTaskId>, cleaningTasks List<SingularityTaskId>, incrementalCleaningTasks Multiset<SingularityDeployKey>) : boolean in class com.hubspot.singularity.scheduler.SingularityCleaner | From | To |