Singularity fd40e04bdf210b1bb0592b6464de2f240c7cafe6

fd40e04bdf210b1bb0592b6464de2f240c7cafe6

Files Diff

Added: 11
Removed: 3
Renamed: 0
Modified: 26

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method public getUsername() : String renamed to public getEmail() : Optional<String> in class com.hubspot.singularity.SingularityUser	From	To
Rename Method public setRequestUserHeaderName(requestUserHeaderName String) : void renamed to public setUserFilter(userFilter String) : void in class com.hubspot.singularity.config.LDAPConfiguration	From	To
Rename Method public getRequestUserHeaderName() : String renamed to public getUserFilter() : String in class com.hubspot.singularity.config.LDAPConfiguration	From	To
Change Parameter Type	9
Change Parameter Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public WebhookResource(webhookManager WebhookManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.WebhookResource	From	To
Change Parameter Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public AbstractMachineResource(manager AbstractMachineManager<T>, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.AbstractMachineResource	From	To
Change Parameter Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public SandboxResource(historyManager HistoryManager, taskManager TaskManager, sandboxManager SandboxManager, deployManager DeployManager, logSupport SingularityLogSupport, configuration SingularityConfiguration, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.SandboxResource	From	To
Change Parameter Type validator : SingularityValidator to authDatastore : SingularityAuthDatastore in method public AuthResource(authorizationHelper SingularityAuthorizationHelper, authDatastore SingularityAuthDatastore, user Optional<SingularityUser>, configuration SingularityConfiguration) in class com.hubspot.singularity.resources.AuthResource	From	To
Change Parameter Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public AbstractHistoryResource(historyManager HistoryManager, taskManager TaskManager, deployManager DeployManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.AbstractHistoryResource	From	To
Change Parameter Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public RackResource(rackManager RackManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.RackResource	From	To
Change Parameter Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public SlaveResource(slaveManager SlaveManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.SlaveResource	From	To
Change Parameter Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public S3LogResource(requestManager RequestManager, historyManager HistoryManager, requestHistoryHelper RequestHistoryHelper, taskManager TaskManager, deployManager DeployManager, s3ServiceDefault Optional<S3Service>, configuration Optional<S3Configuration>, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>, s3GroupOverride Map<String,S3Service>) in class com.hubspot.singularity.resources.S3LogResource	From	To
Change Parameter Type oldValue : Set<String> to oldValue : Optional<SingularityUser> in method public reload(key String, oldValue Optional<SingularityUser>) : ListenableFuture<Optional<SingularityUser>> in class com.hubspot.singularity.auth.datastore.SingularityLDAPDatastore.LDAPCacheLoader	From	To
Move Method	11
Move Method public setEnabled(enabled boolean) : void from class com.hubspot.singularity.config.LDAPConfiguration to public setEnabled(enabled boolean) : void from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Method public getRequiredGroups() : Set<String> from class com.hubspot.singularity.config.LDAPConfiguration to public getRequiredGroups() : Set<String> from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Method public checkForAuthorizationByRequestId(requestId String, user Optional<SingularityUser>) : void from class com.hubspot.singularity.data.SingularityValidator to public checkForAuthorizationByRequestId(requestId String, user Optional<SingularityUser>) : void from class com.hubspot.singularity.auth.SingularityAuthorizationHelper	From	To
Move Method public isAuthorizedForRequest(request SingularityRequest, user Optional<SingularityUser>) : boolean from class com.hubspot.singularity.data.SingularityValidator to public isAuthorizedForRequest(request SingularityRequest, user Optional<SingularityUser>) : boolean from class com.hubspot.singularity.auth.SingularityAuthorizationHelper	From	To
Move Method public checkForAuthorization(request SingularityRequest, existingRequest Optional<SingularityRequest>, user Optional<SingularityUser>) : void from class com.hubspot.singularity.data.SingularityValidator to public checkForAuthorization(request SingularityRequest, existingRequest Optional<SingularityRequest>, user Optional<SingularityUser>) : void from class com.hubspot.singularity.auth.SingularityAuthorizationHelper	From	To
Move Method public setRequiredGroups(requiredGroups Set<String>) : void from class com.hubspot.singularity.config.LDAPConfiguration to public setRequiredGroups(requiredGroups Set<String>) : void from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Method public hasAdminAuthorization(user Optional<SingularityUser>) : boolean from class com.hubspot.singularity.data.SingularityValidator to public hasAdminAuthorization(user Optional<SingularityUser>) : boolean from class com.hubspot.singularity.auth.SingularityAuthorizationHelper	From	To
Move Method public checkForAuthorizationByTaskId(taskId String, user Optional<SingularityUser>) : void from class com.hubspot.singularity.data.SingularityValidator to public checkForAuthorizationByTaskId(taskId String, user Optional<SingularityUser>) : void from class com.hubspot.singularity.auth.SingularityAuthorizationHelper	From	To
Move Method public isEnabled() : boolean from class com.hubspot.singularity.config.LDAPConfiguration to public isEnabled() : boolean from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Method public getAdminGroups() : Set<String> from class com.hubspot.singularity.config.LDAPConfiguration to public getAdminGroups() : Set<String> from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Method public setAdminGroups(adminGroups Set<String>) : void from class com.hubspot.singularity.config.LDAPConfiguration to public setAdminGroups(adminGroups Set<String>) : void from class com.hubspot.singularity.config.AuthConfiguration	From	To
Rename Variable	1
Rename Variable refreshStartTime : long to reloadStartTime : long in method public reload(key String, oldValue Optional<SingularityUser>) : ListenableFuture<Optional<SingularityUser>> in class com.hubspot.singularity.auth.datastore.SingularityLDAPDatastore.LDAPCacheLoader	From	To
Change Return Type	5
Change Return Type LDAPConfiguration to Optional<LDAPConfiguration> in method public getLdapConfiguration() : Optional<LDAPConfiguration> in class com.hubspot.singularity.config.SingularityConfiguration	From	To
Change Return Type ListenableFuture<Set<String>> to ListenableFuture<Optional<SingularityUser>> in method public reload(key String, oldValue Optional<SingularityUser>) : ListenableFuture<Optional<SingularityUser>> in class com.hubspot.singularity.auth.datastore.SingularityLDAPDatastore.LDAPCacheLoader	From	To
Change Return Type String to Optional<String> in method public getEmail() : Optional<String> in class com.hubspot.singularity.SingularityUser	From	To
Change Return Type Set<String> to Optional<SingularityUser> in method public load(key String) : Optional<SingularityUser> in class com.hubspot.singularity.auth.datastore.SingularityLDAPDatastore.LDAPCacheLoader	From	To
Change Return Type Optional<SingularityUser> to SingularityUserHolder in method public getUser() : SingularityUserHolder in class com.hubspot.singularity.resources.AuthResource	From	To
Move Attribute	7
Move Attribute private configuration : SingularityConfiguration from class com.hubspot.singularity.SingularityLDAPModule to private configuration : SingularityConfiguration from class com.hubspot.singularity.resources.AuthResource	From	To
Move Attribute private requestUserHeaderName : String from class com.hubspot.singularity.config.LDAPConfiguration to private requestUserHeaderName : String from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Attribute private enabled : boolean from class com.hubspot.singularity.config.LDAPConfiguration to private enabled : boolean from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Attribute private requestManager : RequestManager from class com.hubspot.singularity.data.SingularityValidator to private requestManager : RequestManager from class com.hubspot.singularity.SingularityAuthorizationHelperTest	From	To
Move Attribute private configuration : SingularityConfiguration from class com.hubspot.singularity.auth.SingularityLDAPManager to private configuration : SingularityConfiguration from class com.hubspot.singularity.resources.AuthResource	From	To
Move Attribute private adminGroups : Set<String> from class com.hubspot.singularity.config.LDAPConfiguration to private adminGroups : Set<String> from class com.hubspot.singularity.config.AuthConfiguration	From	To
Move Attribute private requiredGroups : Set<String> from class com.hubspot.singularity.config.LDAPConfiguration to private requiredGroups : Set<String> from class com.hubspot.singularity.config.AuthConfiguration	From	To
Extract Class	1
Extract Class com.hubspot.singularity.config.AuthConfiguration from class com.hubspot.singularity.config.LDAPConfiguration	From	To
Move And Rename Class	1
Move And Rename Class com.hubspot.singularity.auth.SingularityLDAPManager.LDAPGroupCacheLoader moved and renamed to com.hubspot.singularity.auth.datastore.SingularityLDAPDatastore.LDAPCacheLoader	From	To
Rename Attribute	6
Rename Attribute ldapManager : SingularityLDAPManager to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.AuthResource	From	To
Rename Attribute validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.AbstractMachineResource	From	To
Rename Attribute validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.AbstractHistoryResource	From	To
Rename Attribute validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.WebhookResource	From	To
Rename Attribute requestUserHeaderName : String to userFilter : String in class com.hubspot.singularity.config.LDAPConfiguration	From	To
Rename Attribute validator : SingularityValidator to authDatastore : SingularityAuthDatastore in class com.hubspot.singularity.resources.AuthResource	From	To
Change Variable Type	1
Change Variable Type task : ListenableFutureTask<Set<String>> to task : ListenableFutureTask<Optional<SingularityUser>> in method public reload(key String, oldValue Optional<SingularityUser>) : ListenableFuture<Optional<SingularityUser>> in class com.hubspot.singularity.auth.datastore.SingularityLDAPDatastore.LDAPCacheLoader	From	To
Change Attribute Type	5
Change Attribute Type ldapManager : SingularityLDAPManager to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.AuthResource	From	To
Change Attribute Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.AbstractHistoryResource	From	To
Change Attribute Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.WebhookResource	From	To
Change Attribute Type validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in class com.hubspot.singularity.resources.AbstractMachineResource	From	To
Change Attribute Type validator : SingularityValidator to authDatastore : SingularityAuthDatastore in class com.hubspot.singularity.resources.AuthResource	From	To
Extract And Move Method	1
Extract And Move Method public getAuthConfiguration() : AuthConfiguration extracted from public getUser() : Optional<SingularityUser> in class com.hubspot.singularity.resources.AuthResource & moved to class com.hubspot.singularity.config.SingularityConfiguration	From	To
Rename Parameter	14
Rename Parameter validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public RackResource(rackManager RackManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.RackResource	From	To
Rename Parameter validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public S3LogResource(requestManager RequestManager, historyManager HistoryManager, requestHistoryHelper RequestHistoryHelper, taskManager TaskManager, deployManager DeployManager, s3ServiceDefault Optional<S3Service>, configuration Optional<S3Configuration>, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>, s3GroupOverride Map<String,S3Service>) in class com.hubspot.singularity.resources.S3LogResource	From	To
Rename Parameter validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public WebhookResource(webhookManager WebhookManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.WebhookResource	From	To
Rename Parameter authHelper : SingularityAuthorizationHelper to authorizationHelper : SingularityAuthorizationHelper in method public RequestResource(validator SingularityValidator, deployManager DeployManager, taskManager TaskManager, requestManager RequestManager, mailer SingularityMailer, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.RequestResource	From	To
Rename Parameter validator : SingularityValidator to authDatastore : SingularityAuthDatastore in method public AuthResource(authorizationHelper SingularityAuthorizationHelper, authDatastore SingularityAuthDatastore, user Optional<SingularityUser>, configuration SingularityConfiguration) in class com.hubspot.singularity.resources.AuthResource	From	To
Rename Parameter authHelper : SingularityAuthorizationHelper to authorizationHelper : SingularityAuthorizationHelper in method public DeployResource(requestManager RequestManager, deployManager DeployManager, validator SingularityValidator, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.DeployResource	From	To
Rename Parameter validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public AbstractHistoryResource(historyManager HistoryManager, taskManager TaskManager, deployManager DeployManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.AbstractHistoryResource	From	To
Rename Parameter authHelper : SingularityAuthorizationHelper to authorizationHelper : SingularityAuthorizationHelper in method public TaskResource(taskRequestManager TaskRequestManager, taskManager TaskManager, slaveManager SlaveManager, mesosClient MesosClient, validator SingularityValidator, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.TaskResource	From	To
Rename Parameter username : String to id : String in method public SingularityUser(id String, name Optional<String>, email Optional<String>, groups Set<String>) in class com.hubspot.singularity.SingularityUser	From	To
Rename Parameter validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public SlaveResource(slaveManager SlaveManager, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.SlaveResource	From	To
Rename Parameter authHelper : SingularityAuthorizationHelper to authorizationHelper : SingularityAuthorizationHelper in method public HistoryResource(historyManager HistoryManager, taskManager TaskManager, deployManager DeployManager, deployHistoryHelper DeployHistoryHelper, taskHistoryHelper TaskHistoryHelper, requestHistoryHelper RequestHistoryHelper, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.HistoryResource	From	To
Rename Parameter validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public AbstractMachineResource(manager AbstractMachineManager<T>, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.AbstractMachineResource	From	To
Rename Parameter requestUserHeaderName : String to userFilter : String in method public setUserFilter(userFilter String) : void in class com.hubspot.singularity.config.LDAPConfiguration	From	To
Rename Parameter validator : SingularityValidator to authorizationHelper : SingularityAuthorizationHelper in method public SandboxResource(historyManager HistoryManager, taskManager TaskManager, sandboxManager SandboxManager, deployManager DeployManager, logSupport SingularityLogSupport, configuration SingularityConfiguration, authorizationHelper SingularityAuthorizationHelper, user Optional<SingularityUser>) in class com.hubspot.singularity.resources.SandboxResource	From	To

fd40e04bdf210b1bb0592b6464de2f240c7cafe6

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: