alluxio 0dfaae3e72b0f687c6b6059575e322df23938662

0dfaae3e72b0f687c6b6059575e322df23938662

Files Diff

Added: 20
Removed: 20
Renamed: 0
Modified: 71

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	11
Change Parameter Type address : SocketAddress to address : GrpcServerAddress in method public DefaultBlockWorkerClient(subject Subject, address GrpcServerAddress, alluxioConf AlluxioConfiguration, workerGroup EventLoopGroup) in class alluxio.client.block.stream.DefaultBlockWorkerClient	From	To
Change Parameter Type address : SocketAddress to address : GrpcServerAddress in method public newBuilder(address GrpcServerAddress, conf AlluxioConfiguration) : GrpcChannelBuilder in class alluxio.grpc.GrpcChannelBuilder	From	To
Change Parameter Type address : SocketAddress to address : GrpcServerAddress in method public create(subject Subject, address GrpcServerAddress, alluxioConf AlluxioConfiguration, workerGroup EventLoopGroup) : BlockWorkerClient in class alluxio.client.block.stream.BlockWorkerClient.Factory	From	To
Change Parameter Type value : String to value : ChannelAuthenticationScheme in method public setAuthenticationScheme(value ChannelAuthenticationScheme) : Builder in class alluxio.grpc.SaslMessage.Builder	From	To
Change Parameter Type authorizedUser : String to userInfo : AuthenticatedUserInfo in method public registerChannel(channelId UUID, userInfo AuthenticatedUserInfo, saslServer SaslServer) : void in class alluxio.security.authentication.DefaultAuthenticationServer	From	To
Change Parameter Type saslClient : SaslClient to saslClientHandler : SaslClientHandler in method public DefaultSaslHandshakeClientHandler(saslClientHandler SaslClientHandler) in class alluxio.security.authentication.DefaultSaslHandshakeClientHandler	From	To
Change Parameter Type address : SocketAddress to address : GrpcServerAddress in method public BlockWorkerClientPool(subject Subject, address GrpcServerAddress, maxCapacity int, alluxioConf AlluxioConfiguration, workerGroup EventLoopGroup) in class alluxio.client.block.stream.BlockWorkerClientPool	From	To
Change Parameter Type saslServer : SaslServer to saslServerHandler : SaslServerHandler in method public DefaultSaslHandshakeServerHandler(saslServerHandler SaslServerHandler) in class alluxio.security.authentication.DefaultSaslHandshakeServerHandler	From	To
Change Parameter Type authorizedUser : String to userInfo : AuthenticatedUserInfo in method public registerChannel(channelId UUID, userInfo AuthenticatedUserInfo, saslServer SaslServer) : void in class alluxio.security.authentication.AuthenticationServer	From	To
Change Parameter Type authorizedUser : String to userInfo : AuthenticatedUserInfo in method public AuthenticatedChannelInfo(userInfo AuthenticatedUserInfo, authenticatedServer SaslServer) in class alluxio.security.authentication.DefaultAuthenticationServer.AuthenticatedChannelInfo	From	To
Change Parameter Type address : SocketAddress to address : GrpcServerAddress in method private GrpcChannelBuilder(address GrpcServerAddress, conf AlluxioConfiguration) in class alluxio.grpc.GrpcChannelBuilder	From	To
Move Source Folder	2
Move Source Folder core/base to core/common	From	To
Move Source Folder core/common to core/base	From	To
Move Attribute	2
Move Attribute private mConfiguration : AlluxioConfiguration from class alluxio.security.authentication.SaslStreamServerDriver to private mConfiguration : AlluxioConfiguration from class alluxio.security.authentication.ChannelAuthenticator	From	To
Move Attribute private mSaslServer : SaslServer from class alluxio.security.authentication.SaslStreamServerDriver to private mSaslServer : SaslServer from class alluxio.security.authentication.plain.SaslServerHandlerPlain	From	To
Rename Class	2
Rename Class alluxio.security.authentication.SaslParticipantProviderTest renamed to alluxio.security.authentication.SaslHandlersTest	From	To
Rename Class alluxio.security.authentication.SaslParticipantProviderUtils renamed to alluxio.security.authentication.AuthenticationUserUtils	From	To
Move And Rename Class	2
Move And Rename Class alluxio.security.authentication.plain.SaslHandshakeServerHandlerPlain moved and renamed to alluxio.security.authentication.DefaultSaslHandshakeServerHandler	From	To
Move And Rename Class alluxio.security.authentication.plain.SaslHandshakeClientHandlerPlain moved and renamed to alluxio.security.authentication.DefaultSaslHandshakeClientHandler	From	To
Extract Variable	5
Extract Variable bindAddress : InetSocketAddress in method public testEqualKeys() : void from class alluxio.grpc.GrpcManagedChannelPoolTest	From	To
Extract Variable bindAddress : InetSocketAddress in method public testEqualKeysNoPooling() : void from class alluxio.grpc.GrpcManagedChannelPoolTest	From	To
Extract Variable bindAddress : InetSocketAddress in method private createServer(authType AuthType) : GrpcServer from class alluxio.security.authentication.GrpcSecurityTest	From	To
Extract Variable bindAddress : InetSocketAddress in method public testEqualKeysComplex() : void from class alluxio.grpc.GrpcManagedChannelPoolTest	From	To
Extract Variable bindAddress : InetSocketAddress in method public testNotEqualKeys() : void from class alluxio.grpc.GrpcManagedChannelPoolTest	From	To
Change Variable Type	2
Change Variable Type server : SaslServer to serverHandler : SaslServerHandler in method public testCreateServerSimple() : void in class alluxio.security.authentication.SaslHandlersTest	From	To
Change Variable Type userName : String to userInfo : AuthenticatedUserInfo in method private authenticateCall(call ServerCall<ReqT,RespT>, headers Metadata) : boolean in class alluxio.security.authentication.AuthenticatedUserInjector	From	To
Extract Method	2
Extract Method private acquireBlockWorkerClientInternal(workerNetAddress WorkerNetAddress, subject Subject) : BlockWorkerClient extracted from public acquireBlockWorkerClient(workerNetAddress WorkerNetAddress) : BlockWorkerClient in class alluxio.client.file.FileSystemContext	From	To
Extract Method public initialize(uri URI, conf Configuration, alluxioConfiguration AlluxioConfiguration) : void extracted from public initialize(uri URI, conf Configuration) : void in class alluxio.hadoop.AbstractFileSystem	From	To
Inline Variable	1
Inline Variable conf : AlluxioConfiguration in method public create(context FileSystemContext, address WorkerNetAddress, id long, length long, type RequestType, options OutStreamOptions) : GrpcDataWriter from class alluxio.client.block.stream.GrpcDataWriter	From	To
Rename Method	8
Rename Method public setAuthenticationName(value String) : Builder renamed to public setAuthenticationScheme(value ChannelAuthenticationScheme) : Builder in class alluxio.grpc.SaslMessage.Builder	From	To
Rename Method public hasAuthenticationName() : boolean renamed to public hasAuthenticationScheme() : boolean in class alluxio.grpc.SaslMessageOrBuilder	From	To
Rename Method public hasAuthenticationName() : boolean renamed to public hasAuthenticationScheme() : boolean in class alluxio.grpc.SaslMessage	From	To
Rename Method public clearAuthenticationName() : Builder renamed to public clearAuthenticationScheme() : Builder in class alluxio.grpc.SaslMessage.Builder	From	To
Rename Method public getUserName() : String renamed to public getUserInfo() : AuthenticatedUserInfo in class alluxio.security.authentication.DefaultAuthenticationServer.AuthenticatedChannelInfo	From	To
Rename Method public hasAuthenticationName() : boolean renamed to public hasAuthenticationScheme() : boolean in class alluxio.grpc.SaslMessage.Builder	From	To
Rename Method public getUserNameForChannel(channelId UUID) : String renamed to public getUserInfoForChannel(channelId UUID) : AuthenticatedUserInfo in class alluxio.security.authentication.DefaultAuthenticationServer	From	To
Rename Method public getUserNameForChannel(channelId UUID) : String renamed to public getUserInfoForChannel(channelId UUID) : AuthenticatedUserInfo in class alluxio.security.authentication.AuthenticationServer	From	To
Rename Variable	2
Rename Variable userName : String to userInfo : AuthenticatedUserInfo in method private authenticateCall(call ServerCall<ReqT,RespT>, headers Metadata) : boolean in class alluxio.security.authentication.AuthenticatedUserInjector	From	To
Rename Variable server : SaslServer to serverHandler : SaslServerHandler in method public testCreateServerSimple() : void in class alluxio.security.authentication.SaslHandlersTest	From	To
Change Return Type	4
Change Return Type String to AuthenticatedUserInfo in method public getUserInfoForChannel(channelId UUID) : AuthenticatedUserInfo in class alluxio.security.authentication.DefaultAuthenticationServer	From	To
Change Return Type String to AuthenticatedUserInfo in method public getUserInfoForChannel(channelId UUID) : AuthenticatedUserInfo in class alluxio.security.authentication.AuthenticationServer	From	To
Change Return Type String to AuthenticatedUserInfo in method public getUserInfo() : AuthenticatedUserInfo in class alluxio.security.authentication.DefaultAuthenticationServer.AuthenticatedChannelInfo	From	To
Change Return Type InetSocketAddress to GrpcServerAddress in method private getServerConnectAddress(server GrpcServer) : GrpcServerAddress in class alluxio.security.authentication.GrpcSecurityTest	From	To
Rename Attribute	7
Rename Attribute mConf : AlluxioConfiguration to mServerAddress : GrpcServerAddress in class alluxio.security.authentication.ChannelAuthenticator.AuthenticatedManagedChannel	From	To
Rename Attribute mRpcAddress : InetSocketAddress to mRpcConnectAddress : InetSocketAddress in class alluxio.worker.AlluxioJobWorkerProcess	From	To
Rename Attribute mRpcAddress : InetSocketAddress to mRpcBindAddress : InetSocketAddress in class alluxio.worker.AlluxioWorkerProcess	From	To
Rename Attribute S_PLAIN_INITIATE_CHANNEL : byte[] to S_INITIATE_CHALLENGE : byte[] in class alluxio.security.authentication.DefaultSaslHandshakeClientHandler	From	To
Rename Attribute authenticationName_ : Object to authenticationScheme_ : int in class alluxio.grpc.SaslMessage.Builder	From	To
Rename Attribute mAuthorizedUser : String to mUserInfo : AuthenticatedUserInfo in class alluxio.security.authentication.DefaultAuthenticationServer.AuthenticatedChannelInfo	From	To
Rename Attribute AUTHENTICATIONNAME_FIELD_NUMBER : int to AUTHENTICATIONSCHEME_FIELD_NUMBER : int in class alluxio.grpc.SaslMessage	From	To
Change Attribute Type	5
Change Attribute Type authenticationName_ : Object to authenticationScheme_ : int in class alluxio.grpc.SaslMessage.Builder	From	To
Change Attribute Type mAuthorizedUser : String to mUserInfo : AuthenticatedUserInfo in class alluxio.security.authentication.DefaultAuthenticationServer.AuthenticatedChannelInfo	From	To
Change Attribute Type mAddress : SocketAddress to mAddress : GrpcServerAddress in class alluxio.client.block.stream.DefaultBlockWorkerClient	From	To
Change Attribute Type mConf : AlluxioConfiguration to mServerAddress : GrpcServerAddress in class alluxio.security.authentication.ChannelAuthenticator.AuthenticatedManagedChannel	From	To
Change Attribute Type mAddress : SocketAddress to mAddress : GrpcServerAddress in class alluxio.client.block.stream.BlockWorkerClientPool	From	To
Rename Parameter	7
Rename Parameter address : SocketAddress to bindAddress : SocketAddress in method public GrpcDataServer(hostName String, bindAddress SocketAddress, workerProcess WorkerProcess) in class alluxio.worker.grpc.GrpcDataServer	From	To
Rename Parameter address : SocketAddress to bindAddress : SocketAddress in method private createServerBuilder(hostName String, bindAddress SocketAddress, type ChannelType) : GrpcServerBuilder in class alluxio.worker.grpc.GrpcDataServer	From	To
Rename Parameter authorizedUser : String to userInfo : AuthenticatedUserInfo in method public registerChannel(channelId UUID, userInfo AuthenticatedUserInfo, saslServer SaslServer) : void in class alluxio.security.authentication.DefaultAuthenticationServer	From	To
Rename Parameter saslClient : SaslClient to saslClientHandler : SaslClientHandler in method public DefaultSaslHandshakeClientHandler(saslClientHandler SaslClientHandler) in class alluxio.security.authentication.DefaultSaslHandshakeClientHandler	From	To
Rename Parameter saslServer : SaslServer to saslServerHandler : SaslServerHandler in method public DefaultSaslHandshakeServerHandler(saslServerHandler SaslServerHandler) in class alluxio.security.authentication.DefaultSaslHandshakeServerHandler	From	To
Rename Parameter authorizedUser : String to userInfo : AuthenticatedUserInfo in method public AuthenticatedChannelInfo(userInfo AuthenticatedUserInfo, authenticatedServer SaslServer) in class alluxio.security.authentication.DefaultAuthenticationServer.AuthenticatedChannelInfo	From	To
Rename Parameter authorizedUser : String to userInfo : AuthenticatedUserInfo in method public registerChannel(channelId UUID, userInfo AuthenticatedUserInfo, saslServer SaslServer) : void in class alluxio.security.authentication.AuthenticationServer	From	To

0dfaae3e72b0f687c6b6059575e322df23938662

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: