1d50c373dcfa44ec4fa1b8bd05ab5cd49e72bd97
Files Diff
- Added: 9
- Removed: 9
- Renamed: 0
- Modified: 71
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getOwnerFromLoginModule(conf AlluxioConfiguration) : String renamed to public getGroup(userState UserState, conf AlluxioConfiguration) : String in class alluxio.util.SecurityUtils | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public getGroupFromLoginModule(conf AlluxioConfiguration) : String moved from class alluxio.util.SecurityUtils to class alluxio.client.file.options.OutStreamOptions & inlined to private OutStreamOptions(context ClientContext, alluxioConf AlluxioConfiguration) | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type configuration : javax.security.auth.login.Configuration to configuration : Configuration in method public createLoginContext(authType AuthType, subject Subject, classLoader ClassLoader, configuration Configuration, callbackHandler CallbackHandler) : LoginContext in class alluxio.util.SecurityUtils | From | To | |
| Change Parameter Type alluxioConf : AlluxioConfiguration to callbackHandler : CallbackHandler in method public createLoginContext(authType AuthType, subject Subject, classLoader ClassLoader, configuration Configuration, callbackHandler CallbackHandler) : LoginContext in class alluxio.util.SecurityUtils | From | To | |
| Move Method | 1 | ||
| Move Method private createLoginContext(authType AuthType, subject Subject, classLoader ClassLoader, configuration Configuration, alluxioConf AlluxioConfiguration) : LoginContext from class alluxio.security.LoginUser to public createLoginContext(authType AuthType, subject Subject, classLoader ClassLoader, configuration Configuration, callbackHandler CallbackHandler) : LoginContext from class alluxio.util.SecurityUtils | From | To | |
| Rename Variable | 1 | ||
| Rename Variable username : String to connectionUser : String in method public SaslClientHandlerPlain(subject Subject, conf AlluxioConfiguration) in class alluxio.security.authentication.plain.SaslClientHandlerPlain | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private mSubject : Subject from class alluxio.ClientContext to protected mSubject : Subject from class alluxio.security.user.BaseUserState | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class alluxio.security.LoginUserTest moved and renamed to alluxio.security.user.UserStateTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute mSubject : Subject to mUserState : UserState in class alluxio.ClientContext | From | To | |
| Extract Variable | 3 | ||
| Extract Variable fs : FileSystem in method private createFiles(user String) : void from class alluxio.client.cli.fs.command.LsCommandIntegrationTest | From | To | |
| Extract Variable fsContext : FileSystemContext in method private replicateFileBlocks(filePath AlluxioURI) : void from class alluxio.server.ft.MultiWorkerIntegrationTest | From | To | |
| Extract Variable fs : FileSystem in method private createFiles(user String) : URIStatus[] from class alluxio.client.cli.fs.command.SetFaclCommandIntegrationTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type user : User to user : CurrentUser in method private createHdfsSubject() : Subject in class alluxio.client.fs.ImpersonationIntegrationTest | From | To | |
| Change Variable Type user : Set<User> to user : Set<CurrentUser> in method public getImpersonationUser(subject Subject, conf AlluxioConfiguration) : String in class alluxio.security.authentication.AuthenticationUserUtils | From | To | |
| Extract Method | 1 | ||
| Extract Method public testMasterContext(journalSystem JournalSystem, userState UserState) : CoreMasterContext extracted from public testMasterContext(journalSystem JournalSystem) : CoreMasterContext in class alluxio.master.MasterTestUtils | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type mSubject : Subject to mUserState : UserState in class alluxio.ClientContext | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter alluxioConf : AlluxioConfiguration to callbackHandler : CallbackHandler in method public createLoginContext(authType AuthType, subject Subject, classLoader ClassLoader, configuration Configuration, callbackHandler CallbackHandler) : LoginContext in class alluxio.util.SecurityUtils | From | To |