32247205c1c9e89f7d29379324a56186d9982fb5
Files Diff
- Added: 1
- Removed: 4
- Renamed: 0
- Modified: 6
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method protected createReadRequest(request Protocol.ReadRequest) : AbstractReadRequest renamed to protected createRequest(request Protocol.ReadRequest) : BlockReadRequest in class alluxio.worker.netty.BlockReadHandler | From | To | |
Move Method | 4 | ||
Move Method public setBlockReader(blockReader BlockReader) : void from class alluxio.worker.netty.BlockReadRequest to public setBlockReader(blockReader BlockReader) : void from class alluxio.worker.netty.BlockReadRequest.Context | From | To | |
Move Method public getBlockReader() : BlockReader from class alluxio.worker.netty.BlockReadRequest to public getBlockReader() : BlockReader from class alluxio.worker.netty.BlockReadRequest.Context | From | To | |
Move Method public setCounter(counter Counter) : void from class alluxio.worker.netty.BlockReadRequest to public setCounter(counter Counter) : void from class alluxio.worker.netty.BaseWriteRequest | From | To | |
Move Method public getCounter() : Counter from class alluxio.worker.netty.BlockReadRequest to public getCounter() : Counter from class alluxio.worker.netty.BaseWriteRequest | From | To | |
Inline Method | 3 | ||
Inline Method private cleanup() : void inlined to private runInternal() : void in class alluxio.worker.netty.AbstractWriteHandler.PacketWriter | From | To | |
Inline Method private complete() : void inlined to private runInternal() : void in class alluxio.worker.netty.AbstractWriteHandler.PacketWriter | From | To | |
Inline Method private cancel() : void inlined to private runInternal() : void in class alluxio.worker.netty.AbstractWriteHandler.PacketWriter | From | To | |
Change Return Type | 6 | ||
Change Return Type AbstractReadRequest to BlockReadRequest in method protected createRequest(request Protocol.ReadRequest) : BlockReadRequest in class alluxio.worker.netty.BlockReadHandler | From | To | |
Change Return Type AbstractReadRequest to T in method public getRequest() : T in class alluxio.worker.netty.AbstractReadHandler | From | To | |
Change Return Type AbstractWriteRequest to BaseWriteRequest in method protected createWriteRequest(msg RPCProtoMessage) : BaseWriteRequest in class alluxio.worker.netty.UfsFileWriteHandler | From | To | |
Change Return Type AbstractWriteRequest to BaseWriteRequest in method protected abstract createWriteRequest(msg RPCProtoMessage) : BaseWriteRequest in class alluxio.worker.netty.AbstractWriteHandler | From | To | |
Change Return Type AbstractWriteRequest to BaseWriteRequest in method protected createWriteRequest(msg RPCProtoMessage) : BaseWriteRequest in class alluxio.worker.netty.BlockWriteHandler | From | To | |
Change Return Type AbstractWriteRequest to BaseWriteRequest in method public getRequest() : BaseWriteRequest in class alluxio.worker.netty.AbstractWriteHandler | From | To | |
Move Attribute | 2 | ||
Move Attribute private mBlockReader : BlockReader from class alluxio.worker.netty.BlockReadRequest to private mBlockReader : BlockReader from class alluxio.worker.netty.BlockReadRequest.Context | From | To | |
Move Attribute private mCounter : Counter from class alluxio.worker.netty.BlockReadRequest to private mCounter : Counter from class alluxio.worker.netty.BaseWriteRequest | From | To | |
Extract Class | 2 | ||
Extract Class alluxio.worker.netty.BlockReadRequest.Context from class alluxio.worker.netty.BlockReadRequest | From | To | |
Extract Class alluxio.worker.netty.BaseWriteRequest from class alluxio.worker.netty.BlockReadRequest | From | To | |
Rename Class | 1 | ||
Rename Class alluxio.worker.netty.AbstractWriteRequest renamed to alluxio.worker.netty.BaseWriteRequest | From | To | |
Move Class | 2 | ||
Move Class alluxio.worker.netty.BlockWriteRequest moved to alluxio.worker.netty.BlockWriteHandler.BlockWriteRequest | From | To | |
Move Class alluxio.worker.netty.UfsFileWriteRequest moved to alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest | From | To | |
Extract Superclass | 2 | ||
Extract Superclass alluxio.worker.netty.AbstractReadHandler.ReadRequest from classes [alluxio.worker.netty.BlockReadRequest] | From | To | |
Extract Superclass alluxio.worker.netty.BaseWriteRequest from classes [alluxio.worker.netty.BlockWriteHandler.BlockWriteRequest, alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest] | From | To | |
Extract Variable | 1 | ||
Extract Variable ufs : UnderFileSystem in method private createUfsFile(channel Channel) : void from class alluxio.worker.netty.UfsFileWriteHandler | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type mRequest : AbstractReadRequest to mRequest : T in class alluxio.worker.netty.AbstractReadHandler | From | To | |
Change Attribute Type mRequest : AbstractWriteRequest to mRequest : BaseWriteRequest in class alluxio.worker.netty.AbstractWriteHandler | From | To |