alluxio 70208eed69fb50d6c01806f5d87df85e6101f63a

70208eed69fb50d6c01806f5d87df85e6101f63a

Files Diff

Added: 9
Removed: 3
Renamed: 0
Modified: 23

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	4
Extract Subclass alluxio.master.journal.ufs.UfsCheckpointManager from class alluxio.master.journal.CheckpointManager	From	To
Extract Subclass alluxio.master.journal.ufs.UfsJournal from class alluxio.master.journal.Journal	From	To
Extract Subclass alluxio.master.journal.ufs.UfsJournalWriter from class alluxio.master.journal.JournalWriter	From	To
Extract Subclass alluxio.master.journal.ufs.UfsJournalReader from class alluxio.master.journal.JournalReader	From	To
Change Parameter Type	7
Change Parameter Type baseDirectory : String to baseLocation : URL in method public ReadOnly(baseLocation URL) in class alluxio.master.journal.JournalFactory.ReadOnly	From	To
Change Parameter Type baseDirectory : String to baseLocation : URL in method public ReadWrite(baseLocation URL) in class alluxio.master.journal.JournalFactory.ReadWrite	From	To
Change Parameter Type journalWriter : JournalWriter to journalWriter : UfsJournalWriter in method public EntryOutputStream(ufs UnderFileSystem, logPath String, journalFormatter JournalFormatter, journalWriter UfsJournalWriter) in class alluxio.master.journal.ufs.UfsJournalWriter.EntryOutputStream	From	To
Change Parameter Type newCheckpointPath : String to newCheckpointPath : URL in method public update(newCheckpointPath URL) : void in class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Change Parameter Type journal : Journal to journal : UfsJournal in method package UfsJournalReader(journal UfsJournal) in class alluxio.master.journal.ufs.UfsJournalReader	From	To
Change Parameter Type writer : JournalWriter to writer : UfsJournalWriter in method public UfsCheckpointManager(ufs UnderFileSystem, checkpointPath String, writer UfsJournalWriter) in class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Change Parameter Type journal : Journal to journal : UfsJournal in method package UfsJournalWriter(journal UfsJournal) in class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Move Method	2
Move Method public getNewReader() : JournalReader from class alluxio.master.journal.ReadOnlyJournal to public getNewReader() : JournalReader from class alluxio.master.journal.ufs.ReadOnlyUfsJournal	From	To
Move Method public getNewWriter() : JournalWriter from class alluxio.master.journal.ReadWriteJournal to public getNewWriter() : JournalWriter from class alluxio.master.journal.ufs.ReadWriteUfsJournal	From	To
Move Attribute	5
Move Attribute private mUfs : UnderFileSystem from class alluxio.master.journal.JournalWriter to private mUfs : UnderFileSystem from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Move Attribute private mCheckpointPath : String from class alluxio.master.journal.JournalReader to private mCheckpointPath : String from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Move Attribute private LOG : Logger from class alluxio.master.journal.JournalWriter to private LOG : Logger from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Move Attribute private mUfs : UnderFileSystem from class alluxio.master.journal.JournalReader to private mUfs : UnderFileSystem from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Move Attribute private LOG : Logger from class alluxio.master.journal.JournalReader to private LOG : Logger from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Attribute	23
Push Down Attribute private mTempCheckpointPath : String from class alluxio.master.journal.JournalWriter to private mTempCheckpointPath : String from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Attribute private LOG : Logger from class alluxio.master.journal.CheckpointManager to private LOG : Logger from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Attribute private mJournalFormatter : JournalFormatter from class alluxio.master.journal.Journal to private mJournalFormatter : JournalFormatter from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Attribute private mJournalDirectory : String from class alluxio.master.journal.JournalWriter to private mJournalDirectory : String from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Attribute private CURRENT_LOG_EXTENSION : String from class alluxio.master.journal.Journal to private CURRENT_LOG_EXTENSION : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Attribute private mCurrentLogNumber : long from class alluxio.master.journal.JournalReader to private mCurrentLogNumber : long from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Attribute private mCompletedDirectory : String from class alluxio.master.journal.JournalWriter to private mCompletedDirectory : String from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Attribute private mCheckpointPath : String from class alluxio.master.journal.CheckpointManager to private mCheckpointPath : String from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Attribute private mBackupCheckpointPath : String from class alluxio.master.journal.CheckpointManager to private mBackupCheckpointPath : String from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Attribute private COMPLETED_DIRECTORY : String from class alluxio.master.journal.Journal to private COMPLETED_DIRECTORY : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Attribute private mNextCompleteLogNumber : long from class alluxio.master.journal.JournalWriter to private mNextCompleteLogNumber : long from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Attribute private mTempBackupCheckpointPath : String from class alluxio.master.journal.CheckpointManager to private mTempBackupCheckpointPath : String from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Attribute private mCheckpointOutputStream : CheckpointOutputStream from class alluxio.master.journal.JournalWriter to private mCheckpointOutputStream : CheckpointOutputStream from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Attribute private mEntryOutputStream : EntryOutputStream from class alluxio.master.journal.JournalWriter to private mEntryOutputStream : EntryOutputStream from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Attribute public FIRST_COMPLETED_LOG_NUMBER : long from class alluxio.master.journal.Journal to protected FIRST_COMPLETED_LOG_NUMBER : long from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Attribute private mCheckpointOpenedTime : long from class alluxio.master.journal.JournalReader to private mCheckpointOpenedTime : long from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Attribute private ENTRY_LOG_FILENAME_BASE : String from class alluxio.master.journal.Journal to private ENTRY_LOG_FILENAME_BASE : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Attribute private mNextEntrySequenceNumber : long from class alluxio.master.journal.JournalWriter to private mNextEntrySequenceNumber : long from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Attribute private mUfs : UnderFileSystem from class alluxio.master.journal.CheckpointManager to private mUfs : UnderFileSystem from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Attribute private mCheckpointRead : boolean from class alluxio.master.journal.JournalReader to private mCheckpointRead : boolean from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Attribute private mCheckpointLastModifiedTime : long from class alluxio.master.journal.JournalReader to private mCheckpointLastModifiedTime : long from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Attribute private mDirectory : String from class alluxio.master.journal.Journal to private mDirectory : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Attribute private CHECKPOINT_FILENAME : String from class alluxio.master.journal.Journal to private CHECKPOINT_FILENAME : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Extract Class	2
Extract Class alluxio.master.journal.ufs.UfsCheckpointManager from class alluxio.master.journal.JournalWriter	From	To
Extract Class alluxio.master.journal.ufs.UfsCheckpointManager from class alluxio.master.journal.JournalReader	From	To
Rename Class	2
Rename Class alluxio.master.JournalIntegrationTest renamed to alluxio.master.UfsJournalIntegrationTest	From	To
Rename Class alluxio.master.JournalShutdownIntegrationTest renamed to alluxio.master.UfsJournalShutdownIntegrationTest	From	To
Move And Rename Class	1
Move And Rename Class alluxio.master.journal.JournalWriterTest moved and renamed to alluxio.master.journal.ufs.UfsJournalWriterTest	From	To
Move Class	2
Move Class alluxio.master.journal.JournalWriter.EntryOutputStream moved to alluxio.master.journal.ufs.UfsJournalWriter.EntryOutputStream	From	To
Move Class alluxio.master.journal.JournalWriter.CheckpointOutputStream moved to alluxio.master.journal.ufs.UfsJournalWriter.CheckpointOutputStream	From	To
Change Variable Type	3
Change Variable Type mockJournalWriter : JournalWriter to mockJournalWriter : UfsJournalWriter in method public rotateLogOnWriteException() : void in class alluxio.master.journal.ufs.UfsJournalWriterTest	From	To
Change Variable Type mockJournalWriter : JournalWriter to mockJournalWriter : UfsJournalWriter in method public rotateLogOnSyncException() : void in class alluxio.master.journal.ufs.UfsJournalWriterTest	From	To
Change Variable Type mockJournalWriter : JournalWriter to mockJournalWriter : UfsJournalWriter in method public rotateLogOnFlushIOException() : void in class alluxio.master.journal.ufs.UfsJournalWriterTest	From	To
Extract Method	1
Extract Method public recover() : void extracted from public getCheckpointOutputStream(latestSequenceNumber long) : JournalOutputStream in class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Rename Method	2
Rename Method protected getJournalDirectory() : String renamed to protected getJournalLocation() : URL in class alluxio.master.DefaultAlluxioMaster	From	To
Rename Method public processNextJournalLogFiles() : int renamed to public processNextJournalLogs() : int in class alluxio.master.journal.JournalTailer	From	To
Push Down Method	23
Push Down Method public getCheckpointOutputStream(latestSequenceNumber long) : JournalOutputStream from class alluxio.master.journal.JournalWriter to public getCheckpointOutputStream(latestSequenceNumber long) : JournalOutputStream from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public completeAllLogs() : void from class alluxio.master.journal.JournalWriter to public completeLogs() : void from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public writeEntry(entry JournalEntry) : void from class alluxio.master.journal.JournalWriter to public write(entry JournalEntry) : void from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public getCheckpointLastModifiedTimeMs() : long from class alluxio.master.journal.JournalReader to public getCheckpointLastModifiedTimeMs() : long from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Method public allocateNextEntrySequenceNumber() : long from class alluxio.master.journal.JournalWriter to public getNextSequenceNumber() : long from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public getJournalFormatter() : JournalFormatter from class alluxio.master.journal.Journal to protected getJournalFormatter() : JournalFormatter from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Method public getNextInputStream() : JournalInputStream from class alluxio.master.journal.JournalReader to public getNextInputStream() : JournalInputStream from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Method public close() : void from class alluxio.master.journal.JournalWriter to public close() : void from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public updateCheckpoint(newCheckpointPath String) : void from class alluxio.master.journal.CheckpointManager to public update(newCheckpointPath URL) : void from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Method public getCompletedLogFilePath(logNumber long) : String from class alluxio.master.journal.Journal to protected getCompletedLogFilePath(logNumber long) : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Method package JournalReader(journal Journal) from class alluxio.master.journal.JournalReader to package UfsJournalReader(journal UfsJournal) from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Method public getCompletedDirectory() : String from class alluxio.master.journal.Journal to public getCompletedDirectory() : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Method public recoverCheckpoint() : void from class alluxio.master.journal.CheckpointManager to public recover() : void from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Method public CheckpointManager(ufs UnderFileSystem, checkpointPath String, writer JournalWriter) from class alluxio.master.journal.CheckpointManager to public UfsCheckpointManager(ufs UnderFileSystem, checkpointPath String, writer UfsJournalWriter) from class alluxio.master.journal.ufs.UfsCheckpointManager	From	To
Push Down Method public completeCurrentLog() : void from class alluxio.master.journal.JournalWriter to public completeCurrentLog() : void from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public recoverCheckpoint() : void from class alluxio.master.journal.JournalWriter to public recover() : void from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public getCheckpointFilePath() : String from class alluxio.master.journal.Journal to protected getCheckpointFilePath() : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Push Down Method public getCheckpointInputStream() : JournalInputStream from class alluxio.master.journal.JournalReader to public getCheckpointInputStream() : JournalInputStream from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Method public deleteCompletedLogs() : void from class alluxio.master.journal.JournalWriter to public deleteCompletedLogs() : void from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method package JournalWriter(journal Journal) from class alluxio.master.journal.JournalWriter to package UfsJournalWriter(journal UfsJournal) from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public flushEntryStream() : void from class alluxio.master.journal.JournalWriter to public flush() : void from class alluxio.master.journal.ufs.UfsJournalWriter	From	To
Push Down Method public isValid() : boolean from class alluxio.master.journal.JournalReader to public isValid() : boolean from class alluxio.master.journal.ufs.UfsJournalReader	From	To
Push Down Method public getCurrentLogFilePath() : String from class alluxio.master.journal.Journal to public getCurrentLogFilePath() : String from class alluxio.master.journal.ufs.UfsJournal	From	To
Change Return Type	3
Change Return Type String to URL in method protected getJournalLocation() : URL in class alluxio.master.DefaultAlluxioMaster	From	To
Change Return Type Journal to UfsJournal in method public get(name String) : UfsJournal in class alluxio.master.journal.JournalFactory.ReadOnly	From	To
Change Return Type Journal to UfsJournal in method public get(name String) : UfsJournal in class alluxio.master.journal.JournalFactory.ReadWrite	From	To
Rename Attribute	2
Rename Attribute mBaseDirectory : String to mBaseLocation : URL in class alluxio.master.journal.JournalFactory.ReadOnly	From	To
Rename Attribute mBaseDirectory : String to mBaseLocation : URL in class alluxio.master.journal.JournalFactory.ReadWrite	From	To
Change Attribute Type	4
Change Attribute Type mBaseDirectory : String to mBaseLocation : URL in class alluxio.master.journal.JournalFactory.ReadOnly	From	To
Change Attribute Type mBaseDirectory : String to mBaseLocation : URL in class alluxio.master.journal.JournalFactory.ReadWrite	From	To
Change Attribute Type mJournal : Journal to mJournal : UfsJournal in class alluxio.master.journal.ufs.UfsJournalWriterTest	From	To
Change Attribute Type mJournalWriter : JournalWriter to mJournalWriter : UfsJournalWriter in class alluxio.master.journal.ufs.UfsJournalWriter.EntryOutputStream	From	To
Rename Parameter	5
Rename Parameter directory : String to name : String in method public get(name String) : Journal in class alluxio.master.journal.JournalFactory	From	To
Rename Parameter directory : String to name : String in method public get(name String) : UfsJournal in class alluxio.master.journal.JournalFactory.ReadOnly	From	To
Rename Parameter baseDirectory : String to baseLocation : URL in method public ReadOnly(baseLocation URL) in class alluxio.master.journal.JournalFactory.ReadOnly	From	To
Rename Parameter directory : String to name : String in method public get(name String) : UfsJournal in class alluxio.master.journal.JournalFactory.ReadWrite	From	To
Rename Parameter baseDirectory : String to baseLocation : URL in method public ReadWrite(baseLocation URL) in class alluxio.master.journal.JournalFactory.ReadWrite	From	To

70208eed69fb50d6c01806f5d87df85e6101f63a

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: