alluxio 7f397c5e31f41df64e3f774e6a952d8fd9dc5ad5

7f397c5e31f41df64e3f774e6a952d8fd9dc5ad5

Files Diff

Added: 4
Removed: 0
Renamed: 0
Modified: 9

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public setDone(done boolean) : void renamed to public setDoneUnsafe(done boolean) : void in class alluxio.worker.netty.ReadRequestContext	From	To
Rename Method public isDone() : boolean renamed to public isDoneUnsafe() : boolean in class alluxio.worker.netty.ReadRequestContext	From	To
Merge Attribute	2
Merge Attribute [mPackets : Queue<ByteBuf>, mError : Error, mPosToWrite : long] to mContext : T in class alluxio.worker.netty.AbstractWriteHandler	From	To
Merge Attribute [mPackets : Queue<ByteBuf>, mError : Error, mPosToQueue : long] to mContext : T in class alluxio.worker.netty.AbstractWriteHandler	From	To
Pull Up Method	2
Pull Up Method public getCounter() : Counter from class alluxio.worker.netty.BlockWriteHandler.BlockWriteRequest to public getCounter() : Counter from class alluxio.worker.netty.WriteRequestContext	From	To
Pull Up Method public setCounter(counter Counter) : void from class alluxio.worker.netty.BlockWriteHandler.BlockWriteRequest to public setCounter(counter Counter) : void from class alluxio.worker.netty.WriteRequestContext	From	To
Change Parameter Type	1
Change Parameter Type id : long to request : Protocol.WriteRequest in method package WriteRequest(request Protocol.WriteRequest) in class alluxio.worker.netty.WriteRequest	From	To
Move Method	17
Move Method private createUfsFile(channel Channel) : void from class alluxio.worker.netty.UfsFileWriteHandler to private createUfsFile(context UfsFileWriteRequestContext, channel Channel) : void from class alluxio.worker.netty.UfsFileWriteHandler.UfsFilePacketWriter	From	To
Move Method protected cleanupRequest() : void from class alluxio.worker.netty.BlockWriteHandler to protected cleanupRequest(context BlockWriteRequestContext) : void from class alluxio.worker.netty.BlockWriteHandler.BlockPacketWriter	From	To
Move Method public setUnderFileSystem(underFileSystem UnderFileSystem) : void from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to public setUnderFileSystem(underFileSystem UnderFileSystem) : void from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Move Method public getUnderFileSystem() : UnderFileSystem from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to public getUnderFileSystem() : UnderFileSystem from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Move Method protected incrementMetrics(bytesWritten long) : void from class alluxio.worker.netty.UfsFileWriteHandler to private incrementMetrics(bytesWritten long) : void from class alluxio.worker.netty.AbstractWriteHandler	From	To
Move Method public getRequest() : T from class alluxio.worker.netty.AbstractWriteHandler to public getRequest() : T from class alluxio.worker.netty.WriteRequestContext	From	To
Move Method public setOutputStream(outputStream OutputStream) : void from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to public setOutputStream(outputStream OutputStream) : void from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Move Method protected writeBuf(channel Channel, buf ByteBuf, pos long) : void from class alluxio.worker.netty.BlockWriteHandler to protected writeBuf(context BlockWriteRequestContext, channel Channel, buf ByteBuf, pos long) : void from class alluxio.worker.netty.BlockWriteHandler.BlockPacketWriter	From	To
Move Method public getOutputStream() : OutputStream from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to public getOutputStream() : OutputStream from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Move Method protected cleanupRequest() : void from class alluxio.worker.netty.UfsFileWriteHandler to protected cleanupRequest(context UfsFileWriteRequestContext) : void from class alluxio.worker.netty.UfsFileWriteHandler.UfsFilePacketWriter	From	To
Move Method public getCounter() : Counter from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to public getCounter() : Counter from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Move Method protected incrementMetrics(bytesWritten long) : void from class alluxio.worker.netty.BlockWriteHandler to private incrementMetrics(bytesWritten long) : void from class alluxio.worker.netty.AbstractWriteHandler	From	To
Move Method protected completeRequest(channel Channel) : void from class alluxio.worker.netty.BlockWriteHandler to protected completeRequest(context BlockWriteRequestContext, channel Channel) : void from class alluxio.worker.netty.BlockWriteHandler.BlockPacketWriter	From	To
Move Method protected writeBuf(channel Channel, buf ByteBuf, pos long) : void from class alluxio.worker.netty.UfsFileWriteHandler to protected writeBuf(context UfsFileWriteRequestContext, channel Channel, buf ByteBuf, pos long) : void from class alluxio.worker.netty.UfsFileWriteHandler.UfsFilePacketWriter	From	To
Move Method protected cancelRequest() : void from class alluxio.worker.netty.UfsFileWriteHandler to protected cancelRequest(context UfsFileWriteRequestContext) : void from class alluxio.worker.netty.UfsFileWriteHandler.UfsFilePacketWriter	From	To
Move Method protected cancelRequest() : void from class alluxio.worker.netty.BlockWriteHandler to protected cancelRequest(context BlockWriteRequestContext) : void from class alluxio.worker.netty.BlockWriteHandler.BlockPacketWriter	From	To
Move Method protected completeRequest(channel Channel) : void from class alluxio.worker.netty.UfsFileWriteHandler to protected completeRequest(context UfsFileWriteRequestContext, channel Channel) : void from class alluxio.worker.netty.UfsFileWriteHandler.UfsFilePacketWriter	From	To
Pull Up Attribute	1
Pull Up Attribute private mCounter : Counter from class alluxio.worker.netty.BlockWriteHandler.BlockWriteRequest to private mCounter : Counter from class alluxio.worker.netty.WriteRequestContext	From	To
Move Attribute	9
Move Attribute protected mPosToWrite : long from class alluxio.worker.netty.AbstractWriteHandler to protected mPosToWrite : long from class alluxio.worker.netty.WriteRequestContext	From	To
Move Attribute private mPacketWriterActive : boolean from class alluxio.worker.netty.AbstractWriteHandler to private mPacketWriterActive : boolean from class alluxio.worker.netty.WriteRequestContext	From	To
Move Attribute private mRequest : T from class alluxio.worker.netty.AbstractWriteHandler to private mRequest : T from class alluxio.worker.netty.WriteRequestContext	From	To
Move Attribute private mPackets : Queue<ByteBuf> from class alluxio.worker.netty.AbstractWriteHandler to private mPackets : Queue<ByteBuf> from class alluxio.worker.netty.WriteRequestContext	From	To
Move Attribute private mUnderFileSystem : UnderFileSystem from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to private mUnderFileSystem : UnderFileSystem from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Move Attribute private mError : Error from class alluxio.worker.netty.AbstractWriteHandler to private mError : Error from class alluxio.worker.netty.WriteRequestContext	From	To
Move Attribute private mOutputStream : OutputStream from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to private mOutputStream : OutputStream from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Move Attribute private mPosToQueue : long from class alluxio.worker.netty.AbstractWriteHandler to private mPosToQueue : long from class alluxio.worker.netty.WriteRequestContext	From	To
Move Attribute private mCounter : Counter from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest to private mCounter : Counter from class alluxio.worker.netty.UfsFileWriteRequestContext	From	To
Extract Class	2
Extract Class alluxio.worker.netty.WriteRequestContext from class alluxio.worker.netty.AbstractWriteHandler	From	To
Extract Class alluxio.worker.netty.UfsFileWriteRequestContext from class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest	From	To
Move And Rename Class	1
Move And Rename Class alluxio.worker.netty.BlockWriteHandler.BlockWriteRequest moved and renamed to alluxio.worker.netty.BlockWriteRequestContext	From	To
Move Class	1
Move Class alluxio.worker.netty.UfsFileWriteHandler.UfsFileWriteRequest moved to alluxio.worker.netty.UfsFileWriteRequest	From	To
Extract Superclass	1
Extract Superclass alluxio.worker.netty.WriteRequestContext from classes [alluxio.worker.netty.BlockWriteRequestContext]	From	To
Rename Parameter	4
Rename Parameter request : T to context : T in method protected abstract getDataBuffer(context T, channel Channel, offset long, len int) : DataBuffer in class alluxio.worker.netty.AbstractReadHandler.PacketReader	From	To
Rename Parameter id : long to request : Protocol.WriteRequest in method package WriteRequest(request Protocol.WriteRequest) in class alluxio.worker.netty.WriteRequest	From	To
Rename Parameter request : T to context : T in method protected abstract createPacketReader(context T, channel Channel) : PacketReader in class alluxio.worker.netty.AbstractReadHandler	From	To
Rename Parameter request : T to context : T in method protected abstract completeRequest(context T) : void in class alluxio.worker.netty.AbstractReadHandler.PacketReader	From	To

7f397c5e31f41df64e3f774e6a952d8fd9dc5ad5

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: