alluxio 9c1eb168e712e1366ebfec070aa40a03fc673afd

9c1eb168e712e1366ebfec070aa40a03fc673afd

Files Diff

Added: 26
Removed: 6
Renamed: 0
Modified: 106

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move Method	6
Move Method public after() : void from class alluxio.client.file.options.CompleteUfsFileOptionsTest to public after() : void from class alluxio.worker.block.UnderFileSystemBlockReaderTest	From	To
Move Method public validate() : void from class alluxio.thrift.BlockWorkerClientService.lockBlock_args to public validate() : void from class alluxio.thrift.LockBlockTOptions	From	To
Move Method private createBlockFile(blockPath String) : void from class alluxio.worker.block.DefaultBlockWorker to private createBlockFile(blockPath String) : void from class alluxio.worker.block.TieredBlockStore	From	To
Move Method public before() : void from class alluxio.client.file.options.CreateUfsFileOptionsTest to public before() : void from class alluxio.worker.block.UnderFileSystemBlockReaderTest	From	To
Move Method public before() : void from class alluxio.client.file.options.CompleteUfsFileOptionsTest to public before() : void from class alluxio.worker.block.UnderFileSystemBlockReaderTest	From	To
Move Method public after() : void from class alluxio.client.file.options.CreateUfsFileOptionsTest to public after() : void from class alluxio.worker.block.UnderFileSystemBlockReaderTest	From	To
Move Attribute	2
Move Attribute private mContext : FileSystemContext from class alluxio.client.block.LocalBlockInStream to private mContext : FileSystemContext from class alluxio.client.block.UnderFileSystemBlockInStream	From	To
Move Attribute private mBlockId : long from class alluxio.client.block.stream.BlockInStream to private mBlockId : long from class alluxio.client.resource.LockBlockResource	From	To
Extract Class	3
Extract Class alluxio.worker.block.UnderFileSystemBlockReaderTest from class alluxio.client.file.options.CompleteUfsFileOptionsTest	From	To
Extract Class alluxio.worker.block.UnderFileSystemBlockReaderTest from class alluxio.client.file.options.CreateUfsFileOptionsTest	From	To
Extract Class alluxio.thrift.LockBlockTOptions from class alluxio.thrift.BlockWorkerClientService.lockBlock_args	From	To
Move Class	1
Move Class alluxio.client.UnderFileSystemFileReader.Factory moved to alluxio.client.UnderFileSystemBlockReader.Factory	From	To
Extract Variable	1
Extract Variable sizeStr : String in method public formatLsString(rawSize boolean, acl boolean, isFolder boolean, permission String, userName String, groupName String, size long, createTimeMs long, inMemory boolean, path String) : String from class alluxio.shell.command.LsCommand	From	To
Extract Method	2
Extract Method public getTempBlockMetaOrNull(blockId long) : TempBlockMeta extracted from public getTempBlockMeta(blockId long) : TempBlockMeta in class alluxio.worker.block.BlockMetadataManager	From	To
Extract Method public unlockBlockNoException(lockId long) : boolean extracted from public unlockBlock(lockId long) : void in class alluxio.worker.block.BlockLockManager	From	To
Rename Method	2
Rename Method public createBlockMeta(sessionId long, blockId long, location BlockStoreLocation, initialBlockSize long) : TempBlockMeta renamed to public createBlock(sessionId long, blockId long, location BlockStoreLocation, initialBlockSize long) : TempBlockMeta in class alluxio.worker.block.BlockStore	From	To
Rename Method public createBlockMeta(sessionId long, blockId long, location BlockStoreLocation, initialBlockSize long) : TempBlockMeta renamed to public createBlock(sessionId long, blockId long, location BlockStoreLocation, initialBlockSize long) : TempBlockMeta in class alluxio.worker.block.TieredBlockStore	From	To
Rename Variable	2
Rename Variable formatter : DateFormat to dateFormat : DateFormat in method public convertMsToDate(millis long) : String in class alluxio.shell.command.CommandUtils	From	To
Rename Variable formatter : DateFormat to dateFormat : DateFormat in method public convertMsToDate(millis long) : String in class alluxio.web.WebUtils	From	To
Change Return Type	8
Change Return Type LockBlockResult to LockBlockResource in method public lockBlock(blockId long, options LockBlockOptions) : LockBlockResource in class alluxio.client.block.BlockWorkerClient	From	To
Change Return Type UnderFileSystemFileReader to UnderFileSystemBlockReader in method public create(context FileSystemContext) : UnderFileSystemBlockReader in class alluxio.client.UnderFileSystemBlockReader.Factory	From	To
Change Return Type void to boolean in method public unlockBlock(sessionId long, blockId long) : boolean in class alluxio.worker.block.BlockStore	From	To
Change Return Type void to boolean in method public unlockBlock(sessionId long, blockId long) : boolean in class alluxio.worker.block.BlockWorker	From	To
Change Return Type void to boolean in method public unlockBlock(sessionId long, blockId long) : boolean in class alluxio.worker.block.DefaultBlockWorker	From	To
Change Return Type void to boolean in method public unlockBlock(sessionId long, blockId long) : boolean in class alluxio.worker.block.BlockLockManager	From	To
Change Return Type LockBlockResult to LockBlockResource in method public lockBlock(blockId long, options LockBlockOptions) : LockBlockResource in class alluxio.client.block.RetryHandlingBlockWorkerClient	From	To
Change Return Type void to boolean in method public unlockBlock(sessionId long, blockId long) : boolean in class alluxio.worker.block.TieredBlockStore	From	To
Rename Attribute	3
Rename Attribute mLocationPolicy : FileWriteLocationPolicy to mCacheLocationPolicy : FileWriteLocationPolicy in class alluxio.client.file.FileInStream	From	To
Rename Attribute mLocationPolicy : FileWriteLocationPolicy to mCacheLocationPolicy : FileWriteLocationPolicy in class alluxio.client.file.options.InStreamOptions	From	To
Rename Attribute FILE_READER_EXECUTOR : ExecutorService to UFS_BLOCK_READER_EXECUTOR : ExecutorService in class alluxio.worker.netty.NettyExecutors	From	To
Change Attribute Type	3
Change Attribute Type mUfs : UnderFileSystem to mUfs : UnderFileSystemWithLogging in class alluxio.underfs.UnderStorageSystemInterfaceIntegrationTest	From	To
Change Attribute Type mRule : AuthenticatedUserRule to mRule : LoginUserRule in class alluxio.client.file.options.OutStreamOptionsTest	From	To
Change Attribute Type mRule : AuthenticatedUserRule to mRule : LoginUserRule in class alluxio.client.file.options.CreateUfsFileOptionsTest	From	To
Extract And Move Method	4
Extract And Move Method public castToIOException(e Throwable) : IOException extracted from public createLocalBlockInStream(blockId long, blockSize long, workerNetAddress WorkerNetAddress, context FileSystemContext, options InStreamOptions) : BlockInStream in class alluxio.client.block.stream.BlockInStream & moved to class alluxio.util.CommonUtils	From	To
Extract And Move Method public closeQuitely(closer Closer) : void extracted from public createRemoteBlockInStream(blockId long, blockSize long, workerNetAddress WorkerNetAddress, context FileSystemContext, options InStreamOptions) : BlockInStream in class alluxio.client.block.stream.BlockInStream & moved to class alluxio.util.CommonUtils	From	To
Extract And Move Method public closeQuitely(closer Closer) : void extracted from public createLocalBlockInStream(blockId long, blockSize long, workerNetAddress WorkerNetAddress, context FileSystemContext, options InStreamOptions) : BlockInStream in class alluxio.client.block.stream.BlockInStream & moved to class alluxio.util.CommonUtils	From	To
Extract And Move Method public castToIOException(e Throwable) : IOException extracted from public createRemoteBlockInStream(blockId long, blockSize long, workerNetAddress WorkerNetAddress, context FileSystemContext, options InStreamOptions) : BlockInStream in class alluxio.client.block.stream.BlockInStream & moved to class alluxio.util.CommonUtils	From	To
Rename Parameter	1
Rename Parameter permission : short to mode : short in method private verifySetAcl(runUser TestUser, path String, owner String, group String, mode short, recursive boolean) : void in class alluxio.master.file.PermissionCheckTest	From	To

9c1eb168e712e1366ebfec070aa40a03fc673afd

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: