e10d3fa415ce716e052ede482718f2bb2d2b0e76
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method protected checkFileContent(size long) : void renamed to protected checkWriteData(expectedChecksum long, size long) : void in class alluxio.worker.netty.WriteHandlerTest | From | To | |
Move And Rename Method | 1 | ||
Move And Rename Method protected buildWriteRequest(offset long, len int) : RPCProtoMessage from class alluxio.worker.netty.BlockWriteHandlerTest to protected newDataBuffer(len int) : DataBuffer from class alluxio.worker.netty.WriteHandlerTest | From | To | |
Rename Variable | 2 | ||
Rename Variable checksumActual : long to actualChecksum : long in method protected checkWriteData(expectedChecksum long, size long) : void in class alluxio.worker.netty.WriteHandlerTest | From | To | |
Rename Variable sizeActual : long to actualSize : long in method protected checkWriteData(expectedChecksum long, size long) : void in class alluxio.worker.netty.WriteHandlerTest | From | To | |
Inline Method | 1 | ||
Inline Method private createLocalBlockOutStream(context FileSystemContext, address WorkerNetAddress, id long, length long, options OutStreamOptions) : BlockOutStream inlined to public create(context FileSystemContext, blockId long, blockSize long, address WorkerNetAddress, options OutStreamOptions) : BlockOutStream in class alluxio.client.block.stream.BlockOutStream | From | To | |
Change Return Type | 1 | ||
Change Return Type RPCProtoMessage to DataBuffer in method protected newDataBuffer(len int) : DataBuffer in class alluxio.worker.netty.WriteHandlerTest | From | To | |
Extract Variable | 2 | ||
Extract Variable metricName : String in method protected writeBuf(context BlockWriteRequestContext, channel Channel, buf ByteBuf, pos long) : void from class alluxio.worker.netty.BlockWriteHandler.BlockPacketWriter | From | To | |
Extract Variable metricName : String in method private openBlock(context BlockReadRequestContext, channel Channel) : void from class alluxio.worker.netty.BlockReadHandler.BlockPacketReader | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method public create(context FileSystemContext, address WorkerNetAddress, id long, length long, type Protocol.RequestType, options OutStreamOptions) : NettyPacketWriter extracted from public create(context FileSystemContext, address WorkerNetAddress, options OutStreamOptions) : UnderFileSystemFileOutStream in class alluxio.client.block.stream.UnderFileSystemFileOutStream & moved to class alluxio.client.block.stream.NettyPacketWriter | From | To | |
Rename Parameter | 1 | ||
Rename Parameter statusExpected : PStatus to expectedStatus : PStatus in method protected checkWriteResponse(expectedStatus PStatus, writeResponse Object) : void in class alluxio.worker.netty.WriteHandlerTest | From | To |