alluxio ec9f9ceb904710b915e3e41a3738a797f94f9881

ec9f9ceb904710b915e3e41a3738a797f94f9881

Files Diff

Added: 8
Removed: 2
Renamed: 0
Modified: 33

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass alluxio.worker.block.meta.StorageDirEvictorView from class alluxio.worker.block.meta.StorageDirView	From	To
Change Parameter Type	27
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public LRUEvictor(view BlockMetadataEvictorView, allocator Allocator) in class alluxio.worker.block.evictor.LRUEvictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataView in method public MaxFreeAllocator(view BlockMetadataView) in class alluxio.worker.block.allocator.MaxFreeAllocator	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataView in method public RoundRobinAllocator(view BlockMetadataView) in class alluxio.worker.block.allocator.RoundRobinAllocator	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public StorageTierEvictorView(tier StorageTier, view BlockMetadataEvictorView) in class alluxio.worker.block.meta.StorageTierEvictorView	From	To
Change Parameter Type view : BlockMetadataManagerView to metadataView : BlockMetadataView in method public allocateBlockWithView(sessionId long, blockSize long, location BlockStoreLocation, metadataView BlockMetadataView) : StorageDirView in class alluxio.worker.block.allocator.GreedyAllocator	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public freeSpaceWithView(bytesToBeAvailable long, location BlockStoreLocation, view BlockMetadataEvictorView) : EvictionPlan in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Change Parameter Type view : BlockMetadataManagerView to metadataView : BlockMetadataView in method public allocateBlockWithView(sessionId long, blockSize long, location BlockStoreLocation, metadataView BlockMetadataView) : StorageDirView in class alluxio.worker.block.allocator.MaxFreeAllocator	From	To
Change Parameter Type mManagerView : BlockMetadataManagerView to mManagerView : BlockMetadataEvictorView in method public selectDirWithRequestedSpace(bytesToBeAvailable long, location BlockStoreLocation, mManagerView BlockMetadataEvictorView) : StorageDirView in class alluxio.worker.block.evictor.EvictorUtils	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method private selectEvictorDirFromAnyTier(view BlockMetadataEvictorView, availableBytes long) : StorageDirEvictorView in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Parameter Type tierView1 : StorageTierView to tierView1 : StorageTierEvictorView in method private assertSameTierView(tierView1 StorageTierEvictorView, tierView2 StorageTierEvictorView) : void in class alluxio.worker.block.BlockMetadataViewTest	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public AbstractEvictor(view BlockMetadataEvictorView, allocator Allocator) in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Change Parameter Type dir : StorageDirView to dir : StorageDirEvictorView in method public add(dir StorageDirEvictorView, blockId long, blockSizeBytes long) : void in class alluxio.worker.block.evictor.EvictionDirCandidates	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public freeSpaceWithView(availableBytes long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.Evictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public LRFUEvictor(view BlockMetadataEvictorView, allocator Allocator) in class alluxio.worker.block.evictor.LRFUEvictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public create(view BlockMetadataEvictorView, allocator Allocator) : Evictor in class alluxio.worker.block.evictor.Evictor.Factory	From	To
Change Parameter Type mManagerView : BlockMetadataManagerView to metadataView : BlockMetadataEvictorView in method public getDirWithMaxFreeSpace(bytesToBeAvailable long, location BlockStoreLocation, metadataView BlockMetadataEvictorView) : StorageDirView in class alluxio.worker.block.evictor.EvictorUtils	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public freeSpaceWithView(availableBytes long, location BlockStoreLocation, view BlockMetadataEvictorView) : EvictionPlan in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public freeSpaceWithView(bytesToBeAvailable long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.LRFUEvictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public freeSpaceWithView(availableBytes long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Parameter Type dirView : StorageDirView to dirView : StorageDirEvictorView in method private canEvictBlocksFromDir(dirView StorageDirEvictorView, bytesToBeAvailable long) : boolean in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public freeSpaceWithView(availableBytes long, location BlockStoreLocation, view BlockMetadataEvictorView) : EvictionPlan in class alluxio.worker.block.evictor.Evictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataView in method public allocateBlockWithView(sessionId long, blockSize long, location BlockStoreLocation, view BlockMetadataView) : StorageDirView in class alluxio.worker.block.allocator.Allocator	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataView in method public GreedyAllocator(view BlockMetadataView) in class alluxio.worker.block.allocator.GreedyAllocator	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public PartialLRUEvictor(view BlockMetadataEvictorView, allocator Allocator) in class alluxio.worker.block.evictor.PartialLRUEvictor	From	To
Change Parameter Type view : BlockMetadataManagerView to view : BlockMetadataEvictorView in method public freeSpaceWithView(bytesToBeAvailable long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Change Parameter Type tierView2 : StorageTierView to tierView2 : StorageTierEvictorView in method private assertSameTierView(tierView1 StorageTierEvictorView, tierView2 StorageTierEvictorView) : void in class alluxio.worker.block.BlockMetadataViewTest	From	To
Change Parameter Type view : BlockMetadataManagerView to metadataView : BlockMetadataView in method public allocateBlockWithView(sessionId long, blockSize long, location BlockStoreLocation, metadataView BlockMetadataView) : StorageDirView in class alluxio.worker.block.allocator.RoundRobinAllocator	From	To
Pull Up Attribute	2
Pull Up Attribute private mTierViews : List<StorageTierView> from class alluxio.worker.block.BlockMetadataManagerView to package mTierViews : List<StorageTierView> from class alluxio.worker.block.BlockMetadataView	From	To
Pull Up Attribute private mAliasToTierViews : Map<String,StorageTierView> from class alluxio.worker.block.BlockMetadataManagerView to package mAliasToTierViews : Map<String,StorageTierView> from class alluxio.worker.block.BlockMetadataView	From	To
Push Down Attribute	4
Push Down Attribute private mBlocksToMoveOutSize : long from class alluxio.worker.block.meta.StorageDirView to private mBlocksToMoveOutSize : long from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Attribute private mBlocksToMoveInSize : long from class alluxio.worker.block.meta.StorageDirView to private mBlocksToMoveInSize : long from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Attribute private mBlocksToMoveOut : Set<Long> from class alluxio.worker.block.meta.StorageDirView to private mBlocksToMoveOut : Set<Long> from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Attribute private mBlocksToMoveIn : Set<Long> from class alluxio.worker.block.meta.StorageDirView to private mBlocksToMoveIn : Set<Long> from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Rename Class	2
Rename Class alluxio.worker.block.BlockMetadataManagerView renamed to alluxio.worker.block.BlockMetadataEvictorView	From	To
Rename Class alluxio.worker.block.BlockMetadataManagerViewTest renamed to alluxio.worker.block.BlockMetadataViewTest	From	To
Change Variable Type	12
Change Variable Type tierView : StorageTierView to tierView : StorageTierEvictorView in method public BlockMetadataEvictorView(manager BlockMetadataManager, pinnedInodes Set<Long>, lockedBlocks Set<Long>) in class alluxio.worker.block.BlockMetadataEvictorView	From	To
Change Variable Type tierView2 : StorageTierView to tierView2 : StorageTierEvictorView in method public sameTierView() : void in class alluxio.worker.block.BlockMetadataViewTest	From	To
Change Variable Type dirView1 : StorageDirView to dirView1 : StorageDirEvictorView in method private assertSameTierView(tierView1 StorageTierEvictorView, tierView2 StorageTierEvictorView) : void in class alluxio.worker.block.BlockMetadataViewTest	From	To
Change Variable Type nextDirView : StorageDirView to nextDirView : StorageDirEvictorView in method protected cascadingEvict(bytesToBeAvailable long, location BlockStoreLocation, plan EvictionPlan, mode Mode) : StorageDirEvictorView in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Change Variable Type candidateDir : StorageDirView to candidateDir : StorageDirEvictorView in method public freeSpaceWithView(bytesToBeAvailable long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.LRFUEvictor	From	To
Change Variable Type candidateDirView : StorageDirView to candidateDirView : StorageDirEvictorView in method protected cascadingEvict(bytesToBeAvailable long, location BlockStoreLocation, plan EvictionPlan, mode Mode) : StorageDirEvictorView in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Change Variable Type metaManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in method public before() : void in class alluxio.worker.block.meta.StorageTierViewTest	From	To
Change Variable Type selectedDirView : StorageDirView to selectedDirView : StorageDirEvictorView in method public freeSpaceWithView(availableBytes long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Variable Type dir : StorageDirView to dir : StorageDirEvictorView in method public freeSpaceWithView(availableBytes long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Variable Type initManagerView : BlockMetadataManagerView to initManagerView : BlockMetadataEvictorView in method public TieredBlockStore() in class alluxio.worker.block.TieredBlockStore	From	To
Change Variable Type dirView2 : StorageDirView to dirView2 : StorageDirEvictorView in method private assertSameTierView(tierView1 StorageTierEvictorView, tierView2 StorageTierEvictorView) : void in class alluxio.worker.block.BlockMetadataViewTest	From	To
Change Variable Type candidateDir : StorageDirView to candidateDir : StorageDirEvictorView in method public freeSpaceWithView(bytesToBeAvailable long, location BlockStoreLocation, view BlockMetadataEvictorView, mode Mode) : EvictionPlan in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Rename Method	2
Rename Method private selectEvictableDirFromAnyTier(view BlockMetadataManagerView, availableBytes long) : StorageDirView renamed to private selectEvictorDirFromAnyTier(view BlockMetadataEvictorView, availableBytes long) : StorageDirEvictorView in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Rename Method protected getManagerView() : BlockMetadataManagerView renamed to protected getMetadataEvictorView() : BlockMetadataEvictorView in class alluxio.worker.block.allocator.AllocatorTestBase	From	To
Push Down Method	8
Push Down Method public StorageTierView(tier StorageTier, view BlockMetadataManagerView) from class alluxio.worker.block.meta.StorageTierView to public StorageTierEvictorView(tier StorageTier, view BlockMetadataEvictorView) from class alluxio.worker.block.meta.StorageTierEvictorView	From	To
Push Down Method public isMarkedToMoveOut(blockId long) : boolean from class alluxio.worker.block.meta.StorageDirView to public isMarkedToMoveOut(blockId long) : boolean from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Method public clearBlockMarks() : void from class alluxio.worker.block.meta.StorageDirView to public clearBlockMarks() : void from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Method public getEvitableBytes() : long from class alluxio.worker.block.meta.StorageDirView to public getEvitableBytes() : long from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Method public getEvictableBlocks() : List<BlockMeta> from class alluxio.worker.block.meta.StorageDirView to public getEvictableBlocks() : List<BlockMeta> from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Method public getAvailableBytes() : long from class alluxio.worker.block.meta.StorageDirView to public getAvailableBytes() : long from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Method public markBlockMoveIn(blockId long, blockSize long) : void from class alluxio.worker.block.meta.StorageDirView to public markBlockMoveIn(blockId long, blockSize long) : void from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Push Down Method public markBlockMoveOut(blockId long, blockSize long) : void from class alluxio.worker.block.meta.StorageDirView to public markBlockMoveOut(blockId long, blockSize long) : void from class alluxio.worker.block.meta.StorageDirEvictorView	From	To
Pull Up Method	4
Pull Up Method public getTierView(tierAlias String) : StorageTierView from class alluxio.worker.block.BlockMetadataManagerView to public getTierView(tierAlias String) : StorageTierView from class alluxio.worker.block.BlockMetadataView	From	To
Pull Up Method public getTierViews() : List<StorageTierView> from class alluxio.worker.block.BlockMetadataManagerView to public getTierViews() : List<StorageTierView> from class alluxio.worker.block.BlockMetadataView	From	To
Pull Up Method public getTierViewsBelow(tierAlias String) : List<StorageTierView> from class alluxio.worker.block.BlockMetadataManagerView to public getTierViewsBelow(tierAlias String) : List<StorageTierView> from class alluxio.worker.block.BlockMetadataView	From	To
Pull Up Method public getNextTier(tierView StorageTierView) : StorageTierView from class alluxio.worker.block.BlockMetadataManagerView to public getNextTier(tierView StorageTierView) : StorageTierView from class alluxio.worker.block.BlockMetadataView	From	To
Rename Variable	1
Rename Variable dirViewIndex : int to dirIndex : int in method private getNextAvailDirInTier(tierView StorageTierView, blockSize long, mediumType String) : int in class alluxio.worker.block.allocator.RoundRobinAllocator	From	To
Change Return Type	7
Change Return Type BlockMetadataManagerView to BlockMetadataEvictorView in method private getUpdatedView() : BlockMetadataEvictorView in class alluxio.worker.block.TieredBlockStore	From	To
Change Return Type StorageDirView to StorageDirEvictorView in method public candidateDir() : StorageDirEvictorView in class alluxio.worker.block.evictor.EvictionDirCandidates	From	To
Change Return Type StorageDirView to StorageDirEvictorView in method private selectEvictableDirFromTier(tierView StorageTierView, availableBytes long) : StorageDirEvictorView in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Return Type StorageDirView to StorageDirEvictorView in method private selectEvictorDirFromAnyTier(view BlockMetadataEvictorView, availableBytes long) : StorageDirEvictorView in class alluxio.worker.block.evictor.GreedyEvictor	From	To
Change Return Type StorageDirView to StorageDirEvictorView in method protected cascadingEvict(bytesToBeAvailable long, location BlockStoreLocation, plan EvictionPlan, mode Mode) : StorageDirEvictorView in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Change Return Type BlockMetadataManagerView to BlockMetadataEvictorView in method protected getMetadataEvictorView() : BlockMetadataEvictorView in class alluxio.worker.block.allocator.AllocatorTestBase	From	To
Change Return Type BlockMetadataManagerView to BlockMetadataEvictorView in method public defaultMetadataManagerView(baseDir String) : BlockMetadataEvictorView in class alluxio.worker.block.TieredBlockStoreTestUtils	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute metaManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in method public before() : void in class alluxio.worker.block.meta.StorageTierViewTest	From	To
Extract Superclass	1
Extract Superclass alluxio.worker.block.BlockMetadataView from classes [alluxio.worker.block.BlockMetadataEvictorView]	From	To
Rename Attribute	10
Rename Attribute mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.LRFUEvictorTest	From	To
Rename Attribute mMetaManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.meta.StorageDirViewTest	From	To
Rename Attribute mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataView in class alluxio.worker.block.allocator.GreedyAllocator	From	To
Rename Attribute mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Rename Attribute mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.EvictorTestBase	From	To
Rename Attribute sBlockMetadataManagerView : BlockMetadataManagerView to sBlockMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.EvictorFactoryTest	From	To
Rename Attribute mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataView in class alluxio.worker.block.allocator.RoundRobinAllocator	From	To
Rename Attribute mMetaManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.BlockMetadataViewTest	From	To
Rename Attribute mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.allocator.AllocatorFactoryTest	From	To
Rename Attribute mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataView in class alluxio.worker.block.allocator.MaxFreeAllocator	From	To
Change Attribute Type	15
Change Attribute Type mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataView in class alluxio.worker.block.allocator.GreedyAllocator	From	To
Change Attribute Type mMetaManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.BlockMetadataViewTest	From	To
Change Attribute Type mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.allocator.AllocatorFactoryTest	From	To
Change Attribute Type mDirWithMaxBytes : StorageDirView to mDirWithMaxBytes : StorageDirEvictorView in class alluxio.worker.block.evictor.EvictionDirCandidates	From	To
Change Attribute Type mDirCandidates : Map<StorageDirView,Pair<List<Long>,Long>> to mDirCandidates : Map<StorageDirEvictorView,Pair<List<Long>,Long>> in class alluxio.worker.block.evictor.EvictionDirCandidates	From	To
Change Attribute Type mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.LRFUEvictorTest	From	To
Change Attribute Type mMetaManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.meta.StorageDirViewTest	From	To
Change Attribute Type mTestDirView : StorageDirView to mTestDirView : StorageDirEvictorView in class alluxio.worker.block.meta.StorageDirViewTest	From	To
Change Attribute Type mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.AbstractEvictor	From	To
Change Attribute Type sBlockMetadataManagerView : BlockMetadataManagerView to sBlockMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.EvictorFactoryTest	From	To
Change Attribute Type mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataEvictorView in class alluxio.worker.block.evictor.EvictorTestBase	From	To
Change Attribute Type mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataView in class alluxio.worker.block.allocator.RoundRobinAllocator	From	To
Change Attribute Type mTestTierView : StorageTierView to mTestTierView : StorageTierEvictorView in class alluxio.worker.block.meta.StorageTierViewTest	From	To
Change Attribute Type mManagerView : BlockMetadataManagerView to mMetadataView : BlockMetadataView in class alluxio.worker.block.allocator.MaxFreeAllocator	From	To
Change Attribute Type mTestTierView : StorageTierView to mTestTierView : StorageTierEvictorView in class alluxio.worker.block.meta.StorageDirViewTest	From	To
Rename Parameter	4
Rename Parameter mManagerView : BlockMetadataManagerView to metadataView : BlockMetadataEvictorView in method public getDirWithMaxFreeSpace(bytesToBeAvailable long, location BlockStoreLocation, metadataView BlockMetadataEvictorView) : StorageDirView in class alluxio.worker.block.evictor.EvictorUtils	From	To
Rename Parameter view : BlockMetadataManagerView to metadataView : BlockMetadataView in method public allocateBlockWithView(sessionId long, blockSize long, location BlockStoreLocation, metadataView BlockMetadataView) : StorageDirView in class alluxio.worker.block.allocator.RoundRobinAllocator	From	To
Rename Parameter view : BlockMetadataManagerView to metadataView : BlockMetadataView in method public allocateBlockWithView(sessionId long, blockSize long, location BlockStoreLocation, metadataView BlockMetadataView) : StorageDirView in class alluxio.worker.block.allocator.GreedyAllocator	From	To
Rename Parameter view : BlockMetadataManagerView to metadataView : BlockMetadataView in method public allocateBlockWithView(sessionId long, blockSize long, location BlockStoreLocation, metadataView BlockMetadataView) : StorageDirView in class alluxio.worker.block.allocator.MaxFreeAllocator	From	To

ec9f9ceb904710b915e3e41a3738a797f94f9881

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: