47d1940b3e3c5885519d02529b266be4f262a9ed
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public testPollNotificationWithPrivateNamespaceAsFile() : void renamed to public testPollNotificationWithSomeNamespaceAsFile() : void in class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method private periodicSendMessage(message String, stop AtomicBoolean) : void from class com.ctrip.framework.apollo.configservice.integration.NotificationControllerIntegrationTest to protected periodicSendMessage(executorService ExecutorService, message String, stop AtomicBoolean) : void from class com.ctrip.framework.apollo.configservice.integration.AbstractBaseIntegrationTest | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public testPollNotificationWithPublicNamespaceAndHandleMessage() : void from class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest to public testPollNotificationWithMultipleNamespacesAndHandleMessage() : void from class com.ctrip.framework.apollo.configservice.controller.NotificationControllerV2Test | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type result : ApolloConfigNotification to result : List<ApolloConfigNotification> in method private mockPollNotificationHandler(pollResultTimeOutInMS long, statusCode int, result List<ApolloConfigNotification>, failedAtFirstTime boolean) : ContextHandler in class com.ctrip.framework.apollo.integration.ConfigIntegrationTest | From | To | |
| Move Method | 5 | ||
| Move Method public testAssembleLongPollRefreshUrl() : void from class com.ctrip.framework.apollo.internals.RemoteConfigRepositoryTest to public testAssembleLongPollRefreshUrl() : void from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollServiceTest | From | To | |
| Move Method package assembleLongPollRefreshUrl(uri String, appId String, cluster String, namespace String, dataCenter String, previousResult ApolloConfigNotification) : String from class com.ctrip.framework.apollo.internals.RemoteConfigRepository to package assembleLongPollRefreshUrl(uri String, appId String, cluster String, dataCenter String, notificationsMap Map<String,Long>) : String from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService | From | To | |
| Move Method package stopLongPollingRefresh() : void from class com.ctrip.framework.apollo.internals.RemoteConfigRepository to package stopLongPollingRefresh() : void from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService | From | To | |
| Move Method private doLongPollingRefresh(appId String, cluster String, dataCenter String) : void from class com.ctrip.framework.apollo.internals.RemoteConfigRepository to private doLongPollingRefresh(appId String, cluster String, dataCenter String) : void from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService | From | To | |
| Move Method public testPollNotificationWithPublicNamespaceWithNotificationIdOutDated() : void from class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest to public testPollNotificationWithPublicNamespaceWithNotificationIdOutDated() : void from class com.ctrip.framework.apollo.configservice.integration.NotificationControllerV2IntegrationTest | From | To | |
| Rename Variable | 3 | ||
| Rename Variable clusters : List<String> to watchKeys : Set<String> in method public testPollNotificationWithDefaultNamespaceAsFile() : void in class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Rename Variable clusters : List<String> to watchKeys : Set<String> in method public testPollNotificationWithDefaultNamespace() : void in class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Rename Variable key : String to anotherWatchKey : String in method public testPollNotificationWithDefaultNamespaceAndHandleMessage() : void in class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private m_longPollingService : ExecutorService from class com.ctrip.framework.apollo.internals.RemoteConfigRepository to private m_longPollingService : ExecutorService from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService | From | To | |
| Move Attribute private m_longPollRateLimiter : RateLimiter from class com.ctrip.framework.apollo.internals.RemoteConfigRepository to private m_longPollRateLimiter : RateLimiter from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService | From | To | |
| Move Attribute private m_longPollingStopped : AtomicBoolean from class com.ctrip.framework.apollo.internals.RemoteConfigRepository to private m_longPollingStopped : AtomicBoolean from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService | From | To | |
| Move Attribute private m_longPollFailSchedulePolicyInSecond : SchedulePolicy from class com.ctrip.framework.apollo.internals.RemoteConfigRepository to private m_longPollFailSchedulePolicyInSecond : SchedulePolicy from class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService | From | To | |
| Extract Class | 3 | ||
| Extract Class com.ctrip.framework.apollo.configservice.integration.NotificationControllerV2IntegrationTest from class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Extract Class com.ctrip.framework.apollo.configservice.controller.NotificationControllerV2Test from class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Extract Class com.ctrip.framework.apollo.internals.RemoteConfigLongPollService from class com.ctrip.framework.apollo.internals.RemoteConfigRepository | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private DEFAULT_VALUE : String in class ApolloConfigDemo | From | To | |
| Extract Variable | 1 | ||
| Extract Variable changeListener : ConfigChangeListener in method public ApolloConfigDemo() from class ApolloConfigDemo | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type clusters : List<String> to watchKeys : Set<String> in method public testPollNotificationWithDefaultNamespaceAsFile() : void in class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Change Variable Type clusters : List<String> to watchKeys : Set<String> in method public testPollNotificationWithDefaultNamespace() : void in class com.ctrip.framework.apollo.configservice.controller.NotificationControllerTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type pollResponse : HttpResponse<ApolloConfigNotification> to pollResponse : HttpResponse<List<ApolloConfigNotification>> in class com.ctrip.framework.apollo.internals.RemoteConfigRepositoryTest | From | To |