6f850772dfc8b227d5613855529e5c8632592d5b
Files Diff
- Added: 16
- Removed: 22
- Renamed: 0
- Modified: 25
Third party dependencies:
| Dependency Action |
|---|
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 10 | ||
| Rename Method public getGroupId() : long renamed to public getNamespaceId() : long in class com.ctrip.apollo.biz.entity.Item | From | To | |
| Rename Method public setName(name String) : void renamed to public setNamespaceName(namespaceName String) : void in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Method public setComment(comment String) : void renamed to public setClusterName(clusterName String) : void in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Method public setGroupName(groupName String) : void renamed to public setNamespaceName(namespaceName String) : void in class com.ctrip.apollo.biz.entity.Release | From | To | |
| Rename Method public getComment() : String renamed to public getClusterName() : String in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Method public getId() : long renamed to public getNamespaceId() : long in class com.ctrip.apollo.biz.entity.Privilege | From | To | |
| Rename Method public getName() : String renamed to public getNamespaceName() : String in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Method public findGroups(appId String, clusterName String) : List<Group> renamed to public findNamespaces(appId String, clusterName String) : List<Namespace> in class com.ctrip.apollo.biz.service.ViewService | From | To | |
| Rename Method public getGroupName() : String renamed to public getNamespaceName() : String in class com.ctrip.apollo.biz.entity.Release | From | To | |
| Rename Method public setId(id long) : void renamed to public setNamespaceId(namespaceId long) : void in class com.ctrip.apollo.biz.entity.Privilege | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type appId : String to namespaceId : long in method public addPrivilege(namespaceId long, name String, privilType PrivilType) : Privilege in class com.ctrip.apollo.biz.service.PrivilegeService | From | To | |
| Change Parameter Type appId : String to namespaceId : long in method public removePrivilege(namespaceId long, name String, privilType PrivilType) : void in class com.ctrip.apollo.biz.service.PrivilegeService | From | To | |
| Change Parameter Type appId : String to namespaceId : long in method public hasPrivilege(namespaceId long, name String, privilType PrivilType) : boolean in class com.ctrip.apollo.biz.service.PrivilegeService | From | To | |
| Move Method | 1 | ||
| Move Method public setNamespaceId(namespaceId long) : void from class com.ctrip.apollo.biz.entity.Group to public setNamespaceId(namespaceId long) : void from class com.ctrip.apollo.biz.entity.Item | From | To | |
| Change Return Type | 3 | ||
| Change Return Type List<Group> to List<Namespace> in method public findNamespaces(appId String, clusterName String) : List<Namespace> in class com.ctrip.apollo.biz.service.ViewService | From | To | |
| Change Return Type GroupDTO to NamespaceDTO in method public findOne(groupId Long) : NamespaceDTO in class com.ctrip.apollo.adminservice.controller.GroupController | From | To | |
| Change Return Type List<GroupDTO> to List<NamespaceDTO> in method public findGroups(appId String, clusterName String) : List<NamespaceDTO> in class com.ctrip.apollo.adminservice.controller.GroupController | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private comment : String from class com.ctrip.apollo.biz.entity.Namespace to private comment : String from class com.ctrip.apollo.biz.entity.AppNamespace | From | To | |
| Move Attribute private name : String from class com.ctrip.apollo.biz.entity.Namespace to private name : String from class com.ctrip.apollo.biz.entity.AppNamespace | From | To | |
| Move Attribute private namespaceId : long from class com.ctrip.apollo.biz.entity.Group to private namespaceId : long from class com.ctrip.apollo.biz.entity.Item | From | To | |
| Move Attribute private clusterName : String from class com.ctrip.apollo.biz.entity.Group to private clusterName : String from class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Class | 1 | ||
| Rename Class com.ctrip.apollo.core.dto.GroupDTO renamed to com.ctrip.apollo.core.dto.NamespaceDTO | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.ctrip.apollo.portal.repository.AppRepositoryTest moved and renamed to com.ctrip.apollo.biz.service.AdminServiceTest | From | To | |
| Move Class | 5 | ||
| Move Class com.ctrip.apollo.portal.controller.PrivilegeController moved to com.ctrip.apollo.adminservice.controller.PrivilegeController | From | To | |
| Move Class com.ctrip.apollo.portal.entity.AppConfigVO moved to com.ctrip.apollo.core.dto.AppConfigVO | From | To | |
| Move Class com.ctrip.apollo.portal.service.PrivilegeService moved to com.ctrip.apollo.biz.service.PrivilegeService | From | To | |
| Move Class com.ctrip.apollo.portal.service.PrivilegeServiceTest moved to com.ctrip.apollo.biz.service.PrivilegeServiceTest | From | To | |
| Move Class com.ctrip.apollo.portal.entity.Privilege moved to com.ctrip.apollo.biz.entity.Privilege | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute groupName : String to namespaceName : String in class com.ctrip.apollo.biz.entity.Release | From | To | |
| Rename Attribute comment : String to clusterName : String in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Attribute id : long to namespaceId : long in class com.ctrip.apollo.biz.entity.Privilege | From | To | |
| Rename Attribute groupRepository : GroupRepository to namespaceRepository : NamespaceRepository in class com.ctrip.apollo.biz.service.ViewService | From | To | |
| Rename Attribute name : String to namespaceName : String in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type groups : List<Group> to groups : List<Namespace> in method public findNamespaces(appId String, clusterName String) : List<Namespace> in class com.ctrip.apollo.biz.service.ViewService | From | To | |
| Change Variable Type group : Group to group : Namespace in method public findOne(groupId Long) : NamespaceDTO in class com.ctrip.apollo.adminservice.controller.GroupController | From | To | |
| Change Variable Type groups : List<Group> to groups : List<Namespace> in method public findGroups(appId String, clusterName String) : List<NamespaceDTO> in class com.ctrip.apollo.adminservice.controller.GroupController | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type groupRepository : GroupRepository to namespaceRepository : NamespaceRepository in class com.ctrip.apollo.biz.service.ViewService | From | To | |
| Change Attribute Type groupService : GroupService to groupService : NamespaceService in class com.ctrip.apollo.adminservice.controller.GroupController | From | To | |
| Rename Parameter | 13 | ||
| Rename Parameter groupName : String to namespaceName : String in method public findItems(appId String, clusterName String, namespaceName String) : List<Item> in class com.ctrip.apollo.biz.service.ViewService | From | To | |
| Rename Parameter groupId : Long to namespaceId : Long in method public findItems(namespaceId Long) : List<Item> in class com.ctrip.apollo.biz.service.ViewService | From | To | |
| Rename Parameter appId : String to namespaceId : long in method public hasPrivilege(namespaceId long, name String, privilType PrivilType) : boolean in class com.ctrip.apollo.biz.service.PrivilegeService | From | To | |
| Rename Parameter appId : String to namespaceId : long in method public removePrivilege(namespaceId long, name String, privilType PrivilType) : void in class com.ctrip.apollo.biz.service.PrivilegeService | From | To | |
| Rename Parameter groupName : String to namespaceName : String in method public findLatest(appId String, clusterName String, namespaceName String) : Release in class com.ctrip.apollo.biz.repository.ReleaseRepository | From | To | |
| Rename Parameter name : String to namespaceName : String in method public setNamespaceName(namespaceName String) : void in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Parameter id : long to namespaceId : long in method public setNamespaceId(namespaceId long) : void in class com.ctrip.apollo.biz.entity.Privilege | From | To | |
| Rename Parameter appId : String to namespaceId : long in method public addPrivilege(namespaceId long, name String, privilType PrivilType) : Privilege in class com.ctrip.apollo.biz.service.PrivilegeService | From | To | |
| Rename Parameter groupName : String to namespaceName : String in method public findItems(appId String, clusterName String, namespaceName String) : List<ItemDTO> in class com.ctrip.apollo.adminservice.controller.ItemController | From | To | |
| Rename Parameter groupName : String to namespaceName : String in method public findRelease(appId String, clusterName String, namespaceName String) : Release in class com.ctrip.apollo.biz.service.ConfigService | From | To | |
| Rename Parameter comment : String to clusterName : String in method public setClusterName(clusterName String) : void in class com.ctrip.apollo.biz.entity.Namespace | From | To | |
| Rename Parameter groupName : String to namespaceName : String in method public loadConfig(release Release, namespaceName String, versionName String) : ApolloConfig in class com.ctrip.apollo.biz.service.ConfigService | From | To | |
| Rename Parameter groupName : String to namespaceName : String in method public setNamespaceName(namespaceName String) : void in class com.ctrip.apollo.biz.entity.Release | From | To |