9ca8b1704fba5f1360053de6363fd4d689615622
Files Diff
- Added: 61
- Removed: 6
- Renamed: 0
- Modified: 95
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Updated | |
| From com.ctrip.framework:framework-foundation 1.2.1 To 1.4.0 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method public buildRelease(appId String, clusterName String, namespaceName String, name String, comment String, operator String) : ReleaseDTO renamed to public updateAndPublish(appId String, clusterName String, namespaceName String, releaseName String, branchName String, deleteBranch boolean, releaseComment String, changeSets ItemChangeSets) : ReleaseDTO in class com.ctrip.framework.apollo.adminservice.controller.ReleaseController | From | To | |
| Rename Method public save(entity Cluster) : Cluster renamed to public saveWithoutCreatePrivateNamespace(entity Cluster) : Cluster in class com.ctrip.framework.apollo.biz.service.ClusterService | From | To | |
| Rename Method public findClusters(appId String) : List<Cluster> renamed to public findParentClusters(appId String) : List<Cluster> in class com.ctrip.framework.apollo.biz.service.ClusterService | From | To | |
| Rename Method public createRelease(model NamespaceReleaseModel) : ReleaseDTO renamed to public publish(model NamespaceReleaseModel) : ReleaseDTO in class com.ctrip.framework.apollo.portal.service.ReleaseService | From | To | |
| Rename Method public buildRelease(name String, comment String, namespace Namespace, operator String) : Release renamed to private createRelease(namespace Namespace, name String, comment String, configurations Map<String,String>, operator String) : Release in class com.ctrip.framework.apollo.biz.service.ReleaseService | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method private toByteArray(keyHashCode int, machineIdentifier int, counter int) : byte[] from class com.ctrip.framework.apollo.biz.utils.ReleaseKeyGenerator to protected toByteArray(keyHashCode int, machineIdentifier int, counter int) : byte[] from class com.ctrip.framework.apollo.common.utils.UniqueKeyGenerator | From | To | |
| Move Method | 2 | ||
| Move Method public releaseMessageScanner() : ReleaseMessageScanner from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration to public releaseMessageScanner() : ReleaseMessageScanner from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration.MessageScannerConfiguration | From | To | |
| Move Method private assembleKey(appId String, cluster String, namespace String) : String from class com.ctrip.framework.apollo.adminservice.controller.ReleaseController to private assembleKey(appId String, cluster String, namespace String) : String from class com.ctrip.framework.apollo.configservice.integration.ConfigControllerIntegrationTest | From | To | |
| Rename Variable | 6 | ||
| Rename Variable redisAppSettingListner : ServletListenerRegistrationBean to redisAppSettingListener : ServletListenerRegistrationBean in method public redisAppSettingListner() : ServletListenerRegistrationBean in class com.ctrip.framework.apollo.portal.configuration.AuthConfiguration.CtripAuthAutoConfiguration | From | To | |
| Rename Variable firstRelease : ReleaseDTO to baseRelease : ReleaseDTO in method public compare(env Env, baseReleaseId long, toCompareReleaseId long) : ReleaseCompareResult in class com.ctrip.framework.apollo.portal.service.ReleaseService | From | To | |
| Rename Variable secondItems : Map<String,String> to toCompareReleaseConfiguration : Map<String,String> in method public compare(env Env, baseReleaseId long, toCompareReleaseId long) : ReleaseCompareResult in class com.ctrip.framework.apollo.portal.service.ReleaseService | From | To | |
| Rename Variable firstItems : Map<String,String> to baseReleaseConfiguration : Map<String,String> in method public compare(env Env, baseReleaseId long, toCompareReleaseId long) : ReleaseCompareResult in class com.ctrip.framework.apollo.portal.service.ReleaseService | From | To | |
| Rename Variable secondRelease : ReleaseDTO to toCompareRelease : ReleaseDTO in method public compare(env Env, baseReleaseId long, toCompareReleaseId long) : ReleaseCompareResult in class com.ctrip.framework.apollo.portal.service.ReleaseService | From | To | |
| Rename Variable groups : List<Namespace> to namespaces : List<Namespace> in method public findNamespaces(appId String, clusterName String) : List<Namespace> in class com.ctrip.framework.apollo.biz.service.NamespaceService | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private KEY_JOINER : Joiner from class com.ctrip.framework.apollo.biz.utils.ReleaseKeyGenerator to private KEY_JOINER : Joiner from class com.ctrip.framework.apollo.common.utils.UniqueKeyGenerator | From | To | |
| Pull Up Attribute private TIMESTAMP_FORMAT : FastDateFormat from class com.ctrip.framework.apollo.biz.utils.ReleaseKeyGenerator to private TIMESTAMP_FORMAT : FastDateFormat from class com.ctrip.framework.apollo.common.utils.UniqueKeyGenerator | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private notificationController : NotificationController from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration to private notificationController : NotificationController from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration.MessageScannerConfiguration | From | To | |
| Move Attribute private STRING_JOINER : Joiner from class com.ctrip.framework.apollo.adminservice.controller.ReleaseController to private STRING_JOINER : Joiner from class com.ctrip.framework.apollo.biz.utils.ReleaseMessageKeyGenerator | From | To | |
| Move Attribute private notificationControllerV2 : NotificationControllerV2 from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration to private notificationControllerV2 : NotificationControllerV2 from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration.MessageScannerConfiguration | From | To | |
| Move Attribute private configFileController : ConfigFileController from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration to private configFileController : ConfigFileController from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration.MessageScannerConfiguration | From | To | |
| Extract Class | 1 | ||
| Extract Class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration.MessageScannerConfiguration from class com.ctrip.framework.apollo.configservice.ConfigServiceAutoConfiguration | From | To | |
| Move Class | 5 | ||
| Move Class com.ctrip.framework.apollo.portal.entity.form.NamespaceSyncModel moved to com.ctrip.framework.apollo.portal.entity.model.NamespaceSyncModel | From | To | |
| Move Class com.ctrip.framework.apollo.portal.entity.form.NamespaceTextModel moved to com.ctrip.framework.apollo.portal.entity.model.NamespaceTextModel | From | To | |
| Move Class com.ctrip.framework.apollo.portal.entity.form.NamespaceCreationModel moved to com.ctrip.framework.apollo.portal.entity.model.NamespaceCreationModel | From | To | |
| Move Class com.ctrip.framework.apollo.portal.entity.form.Verifiable moved to com.ctrip.framework.apollo.portal.entity.model.Verifiable | From | To | |
| Move Class com.ctrip.framework.apollo.portal.entity.form.NamespaceReleaseModel moved to com.ctrip.framework.apollo.portal.entity.model.NamespaceReleaseModel | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.ctrip.framework.apollo.common.utils.UniqueKeyGenerator from classes [com.ctrip.framework.apollo.biz.utils.ReleaseKeyGenerator] | From | To | |
| Change Package | 1 | ||
| Change Package com.ctrip.framework.apollo.portal.entity.form to com.ctrip.framework.apollo.portal.entity.model | From | To | |
| Extract Method | 3 | ||
| Extract Method private loadConfig(outputFormat ConfigFileOutputFormat, appId String, clusterName String, namespace String, dataCenter String, clientIp String, request HttpServletRequest, response HttpServletResponse) : String extracted from package queryConfig(outputFormat ConfigFileOutputFormat, appId String, clusterName String, namespace String, dataCenter String, clientIp String, request HttpServletRequest, response HttpServletResponse) : String in class com.ctrip.framework.apollo.configservice.controller.ConfigFileController | From | To | |
| Extract Method public findLastOne(namespaceId long) : Item extracted from public findLastOne(appId String, clusterName String, namespaceName String) : Item in class com.ctrip.framework.apollo.biz.service.ItemService | From | To | |
| Extract Method public updateItems(appId String, env Env, clusterName String, namespaceName String, changeSets ItemChangeSets) : void extracted from public updateConfigItemByText(model NamespaceTextModel) : void in class com.ctrip.framework.apollo.portal.service.ItemService | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter secondReleaseId : long to toCompareReleaseId : long in method public compareRelease(env String, baseReleaseId long, toCompareReleaseId long) : ReleaseCompareResult in class com.ctrip.framework.apollo.portal.controller.ReleaseController | From | To | |
| Rename Parameter applicationId : String to clientAppId : String in method private findPublicConfig(clientAppId String, clientIp String, clusterName String, namespace String, dataCenter String) : Release in class com.ctrip.framework.apollo.configservice.controller.ConfigController | From | To | |
| Rename Parameter comment : String to releaseComment : String in method public createRelease(appId String, env Env, clusterName String, namespace String, releaseName String, releaseComment String, operator String) : ReleaseDTO in class com.ctrip.framework.apollo.portal.api.AdminServiceAPI.ReleaseAPI | From | To | |
| Rename Parameter clusterName : String to configClusterName : String in method private loadConfig(clientAppId String, clientIp String, configAppId String, configClusterName String, configNamespace String, dataCenter String) : Release in class com.ctrip.framework.apollo.configservice.controller.ConfigController | From | To | |
| Rename Parameter releaseTitle : String to releaseName : String in method public createRelease(appId String, env Env, clusterName String, namespace String, releaseName String, releaseComment String, operator String) : ReleaseDTO in class com.ctrip.framework.apollo.portal.api.AdminServiceAPI.ReleaseAPI | From | To | |
| Rename Parameter firstReleaseId : long to baseReleaseId : long in method public compareRelease(env String, baseReleaseId long, toCompareReleaseId long) : ReleaseCompareResult in class com.ctrip.framework.apollo.portal.controller.ReleaseController | From | To |