60e0272f336be5d67134e352f295948a064039ab
Files Diff
- Added: 7
- Removed: 2
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 12 | ||
| Rename Method public onSslHandshakeCompleted() : void renamed to public onTlsHandshakeFailure(cause Throwable) : void in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Rename Method public onSslHandshakeCompleted() : void renamed to public onTlsHandshakeFailure(cause Throwable) : void in class org.asynchttpclient.handler.AsyncHandlerExtensions | From | To | |
| Rename Method public onDnsResolved(nameResolutions NameResolution[]) : void renamed to public onTlsHandshake() : void in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Rename Method public onConnectionFailure(address InetAddress) : void renamed to public onTcpConnectFailure(remoteAddress InetSocketAddress, cause Throwable) : void in class org.asynchttpclient.handler.AsyncHandlerExtensions | From | To | |
| Rename Method private onFutureSuccess(channel Channel) : void renamed to public onSuccess(channel Channel) : void in class org.asynchttpclient.netty.channel.NettyConnectListener | From | To | |
| Rename Method public onConnectionOpen() : void renamed to public onTcpConnect(address InetSocketAddress) : void in class org.asynchttpclient.handler.AsyncHandlerExtensions | From | To | |
| Rename Method public onConnectionFailure(address InetAddress) : void renamed to public onTcpConnectFailure(address InetSocketAddress, t Throwable) : void in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Rename Method public onConnectionSuccess(connection Channel, address InetAddress) : void renamed to public onTcpConnectSuccess(remoteAddress InetSocketAddress, connection Channel) : void in class org.asynchttpclient.handler.AsyncHandlerExtensions | From | To | |
| Rename Method public onConnectionOpen() : void renamed to public onTcpConnect(address InetSocketAddress) : void in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Rename Method public onDnsResolved(addresses NameResolution[]) : void renamed to public onTlsHandshake() : void in class org.asynchttpclient.handler.AsyncHandlerExtensions | From | To | |
| Rename Method private onFutureFailure(channel Channel, cause Throwable) : void renamed to public onFailure(channel Channel, cause Throwable) : void in class org.asynchttpclient.netty.channel.NettyConnectListener | From | To | |
| Rename Method public onConnectionSuccess(connection Channel, address InetAddress) : void renamed to public onTcpConnectSuccess(address InetSocketAddress, connection Channel) : void in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public operationComplete(f ChannelFuture) : void from class org.asynchttpclient.netty.channel.NettyConnectListener to public operationComplete(future ChannelFuture) : void from class org.asynchttpclient.netty.SimpleChannelFutureListener | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type address : InetAddress to address : InetSocketAddress in method public onTcpConnectSuccess(address InetSocketAddress, connection Channel) : void in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Change Parameter Type address : InetAddress to address : InetSocketAddress in method public onTcpConnectFailure(address InetSocketAddress, t Throwable) : void in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Move Class | 2 | ||
| Move Class org.asynchttpclient.channel.NameResolver.JdkNameResolver moved to org.asynchttpclient.resolver.JdkNameResolver | From | To | |
| Move Class org.asynchttpclient.channel.NameResolver moved to org.asynchttpclient.resolver.NameResolver | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.asynchttpclient.netty.SimpleChannelFutureListener from classes [org.asynchttpclient.netty.channel.NettyConnectListener] | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute DNS_RESOLVED_EVENT : String to TLS_HANDSHAKE_EVENT : String in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Rename Attribute SSL_HANDSHAKE_COMPLETED_EVENT : String to TLS_HANDSHAKE_FAILURE_EVENT : String in class org.asynchttpclient.test.EventCollectingHandler | From | To | |
| Extract Variable | 1 | ||
| Extract Variable channelPreempted : boolean in method private sendRequestWithNewChannel(request Request, proxy ProxyServer, future NettyResponseFuture<T>, asyncHandler AsyncHandler<T>, reclaimCache boolean) : ListenableFuture<T> from class org.asynchttpclient.netty.request.NettyRequestSender | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type remoteAddresses : InetSocketAddress[] to remoteAddresses : List<InetSocketAddress> in class org.asynchttpclient.netty.request.NettyChannelConnector | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getCause(t Throwable) : Throwable extracted from public done() : void in class org.asynchttpclient.netty.NettyResponseFuture & moved to class org.asynchttpclient.util.MiscUtils | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter handler : AsyncHandler<?> to asyncHandler : AsyncHandler<?> in method public tryToOfferChannelToPool(channel Channel, asyncHandler AsyncHandler<?>, keepAlive boolean, partitionKey Object) : void in class org.asynchttpclient.netty.channel.ChannelManager | From | To | |
| Rename Parameter f : ChannelFuture to future : ChannelFuture in method public operationComplete(future ChannelFuture) : void in class org.asynchttpclient.netty.SimpleChannelFutureListener | From | To |