04d22ce6070f4091ea86623a8d101a7f003d0a16
Files Diff
- Added: 22
- Removed: 9
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 3 | ||
| Move And Rename Method package execute(request ExecuteRequest) : ExecuteResponse from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext.PrimaryBackupRole to public error() : ExecuteResponse from class io.atomix.protocols.backup.protocol.ExecuteResponse | From | To | |
| Move And Rename Method package restore(request RestoreRequest) : RestoreResponse from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext.PrimaryBackupRole to public error() : RestoreResponse from class io.atomix.protocols.backup.protocol.RestoreResponse | From | To | |
| Move And Rename Method private getMetadata(request MetadataRequest) : CompletableFuture<MetadataResponse> from class io.atomix.protocols.backup.PrimaryBackupServer to private metadata(request MetadataRequest) : CompletableFuture<MetadataResponse> from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type request : OpenSessionRequest to request : RestoreRequest in method public restore(request RestoreRequest) : CompletableFuture<RestoreResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Parameter Type request : CloseSessionRequest to request : BackupRequest in method public backup(request BackupRequest) : CompletableFuture<BackupResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Parameter Type communicationService : ClusterCommunicationService to sessionIdService : SessionIdService in method public withSessionIdProvider(sessionIdService SessionIdService) : Builder in class io.atomix.protocols.backup.PrimaryBackupClient.Builder | From | To | |
| Move Method | 2 | ||
| Move Method protected logReceived(request R) : R from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext to protected logReceived(request R) : R from class io.atomix.protocols.backup.roles.PrimaryBackupRole | From | To | |
| Move Method protected logResponse(response R) : R from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext to protected logResponse(response R) : R from class io.atomix.protocols.backup.roles.PrimaryBackupRole | From | To | |
| Move Attribute | 13 | ||
| Move Attribute private primaryElection : PrimaryElection from class io.atomix.protocols.backup.PrimaryBackupServer to private primaryElection : PrimaryElection from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Move Attribute private primitiveTypes : PrimitiveTypeRegistry from class io.atomix.protocols.backup.PrimaryBackupServer to private primitiveTypes : PrimitiveTypeRegistry from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Move Attribute private executeSubject : MessageSubject from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext to package executeSubject : MessageSubject from class io.atomix.protocols.backup.partition.impl.PrimaryBackupMessageContext | From | To | |
| Move Attribute private restoreSubject : MessageSubject from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext to package restoreSubject : MessageSubject from class io.atomix.protocols.backup.partition.impl.PrimaryBackupMessageContext | From | To | |
| Move Attribute private metadataSubject : MessageSubject from class io.atomix.protocols.backup.PrimaryBackupServer to package metadataSubject : MessageSubject from class io.atomix.protocols.backup.partition.impl.PrimaryBackupMessageContext | From | To | |
| Move Attribute private serverName : String from class io.atomix.protocols.backup.impl.PrimaryBackupSession to private serverName : String from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Move Attribute private threadContextFactory : ThreadContextFactory from class io.atomix.protocols.backup.PrimaryBackupServer to private threadContextFactory : ThreadContextFactory from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Move Attribute private backupSubject : MessageSubject from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext to package backupSubject : MessageSubject from class io.atomix.protocols.backup.partition.impl.PrimaryBackupMessageContext | From | To | |
| Move Attribute private serverName : String from class io.atomix.protocols.backup.PrimaryBackupServer to private serverName : String from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Move Attribute private metadataSubject : MessageSubject from class io.atomix.protocols.backup.PrimaryBackupClient to package metadataSubject : MessageSubject from class io.atomix.protocols.backup.partition.impl.PrimaryBackupMessageContext | From | To | |
| Move Attribute private clusterService : ClusterService from class io.atomix.protocols.backup.PrimaryBackupServer to private clusterService : ClusterService from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Move Attribute private clusterService : ClusterService from class io.atomix.protocols.backup.impl.PrimaryBackupSession to private clusterService : ClusterService from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Move Attribute private services : Map<String,PrimaryBackupServiceContext> from class io.atomix.protocols.backup.PrimaryBackupServer to private services : Map<String,PrimaryBackupServiceContext> from class io.atomix.protocols.backup.impl.PrimaryBackupServerContext | From | To | |
| Extract Class | 4 | ||
| Extract Class io.atomix.protocols.backup.impl.PrimaryBackupServerContext from class io.atomix.protocols.backup.PrimaryBackupServer | From | To | |
| Extract Class io.atomix.protocols.backup.partition.impl.PrimaryBackupMessageContext from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext | From | To | |
| Extract Class io.atomix.protocols.backup.roles.PrimaryBackupRole from class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext | From | To | |
| Extract Class io.atomix.protocols.backup.impl.PrimaryBackupServerContext from class io.atomix.protocols.backup.impl.PrimaryBackupSession | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class io.atomix.protocols.backup.impl.DefaultServiceSessions moved and renamed to io.atomix.protocols.backup.service.impl.PrimaryBackupServiceSessions | From | To | |
| Move Class | 2 | ||
| Move Class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext.Role moved to io.atomix.protocols.backup.PrimaryBackupServer.Role | From | To | |
| Move Class io.atomix.protocols.backup.impl.PrimaryBackupServiceContext moved to io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [primitiveType : PrimitiveType, serviceName : String] to descriptor : PrimitiveDescriptor in method public PrimaryBackupServiceContext(serverName String, primitiveId PrimitiveId, primitiveType PrimitiveType, descriptor PrimitiveDescriptor, threadContext ThreadContext, clusterService ClusterService, protocol PrimaryBackupServerProtocol, primaryElection PrimaryElection) in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type future : ComposableFuture<OpenSessionResponse> to future : ComposableFuture<RestoreResponse> in method public restore(request RestoreRequest) : CompletableFuture<RestoreResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Variable Type future : ComposableFuture<CloseSessionResponse> to future : ComposableFuture<ExecuteResponse> in method public execute(request ExecuteRequest) : CompletableFuture<ExecuteResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Variable Type future : ComposableFuture<CloseSessionResponse> to future : ComposableFuture<BackupResponse> in method public backup(request BackupRequest) : CompletableFuture<BackupResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Variable Type future : ComposableFuture<OpenSessionResponse> to future : ComposableFuture<ExecuteResponse> in method public execute(request ExecuteRequest) : CompletableFuture<ExecuteResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Extract Method | 2 | ||
| Extract Method public execute(request ExecuteRequest) : CompletableFuture<ExecuteResponse> extracted from public closeSession(request CloseSessionRequest) : CompletableFuture<CloseSessionResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Extract Method public execute(request ExecuteRequest) : CompletableFuture<ExecuteResponse> extracted from public openSession(request OpenSessionRequest) : CompletableFuture<OpenSessionResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Split Attribute | 1 | ||
| Split Attribute communicationService : ClusterCommunicationService to [protocol : PrimaryBackupClientProtocol, sessionIdService : SessionIdService] in class io.atomix.protocols.backup.PrimaryBackupClient.Builder | From | To | |
| Rename Method | 4 | ||
| Rename Method public withCommunicationService(communicationService ClusterCommunicationService) : Builder renamed to public withSessionIdProvider(sessionIdService SessionIdService) : Builder in class io.atomix.protocols.backup.PrimaryBackupClient.Builder | From | To | |
| Rename Method public sessionId() : long renamed to public session() : long in class io.atomix.protocols.backup.protocol.ExecuteRequest | From | To | |
| Rename Method public closeSession(request CloseSessionRequest) : CompletableFuture<CloseSessionResponse> renamed to public backup(request BackupRequest) : CompletableFuture<BackupResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Rename Method public openSession(request OpenSessionRequest) : CompletableFuture<OpenSessionResponse> renamed to public restore(request RestoreRequest) : CompletableFuture<RestoreResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Session to PrimaryBackupSession in method public getSession(sessionId long) : PrimaryBackupSession in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceSessions | From | To | |
| Change Return Type CompletableFuture<CloseSessionResponse> to CompletableFuture<BackupResponse> in method public backup(request BackupRequest) : CompletableFuture<BackupResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Return Type CompletableFuture<OpenSessionResponse> to CompletableFuture<RestoreResponse> in method public restore(request RestoreRequest) : CompletableFuture<RestoreResponse> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass io.atomix.protocols.backup.protocol.PrimitiveRequest from classes [io.atomix.protocols.backup.protocol.BackupRequest, io.atomix.protocols.backup.protocol.ExecuteRequest, io.atomix.protocols.backup.protocol.RestoreRequest] | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute serviceName : String to protocol : PrimaryBackupServerProtocol in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Rename Attribute serverName : String to protocol : PrimaryBackupServerProtocol in class io.atomix.protocols.backup.impl.PrimaryBackupSession | From | To | |
| Rename Attribute communicationService : ClusterCommunicationService to descriptor : PrimitiveDescriptor in class io.atomix.protocols.backup.proxy.PrimaryBackupProxy | From | To | |
| Rename Attribute sessionId : long to session : long in class io.atomix.protocols.backup.protocol.ExecuteRequest | From | To | |
| Rename Attribute communicationService : ClusterCommunicationService to sessionIdService : SessionIdService in class io.atomix.protocols.backup.PrimaryBackupClient | From | To | |
| Extract Interface | 1 | ||
| Extract Interface io.atomix.primitive.partition.ManagedPrimaryElectionService from classes [io.atomix.election.impl.LeaderElectorPrimaryElectionService] | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type serviceName : String to protocol : PrimaryBackupServerProtocol in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Attribute Type communicationService : ClusterCommunicationService to descriptor : PrimitiveDescriptor in class io.atomix.protocols.backup.proxy.PrimaryBackupProxy | From | To | |
| Change Attribute Type serverName : String to protocol : PrimaryBackupServerProtocol in class io.atomix.protocols.backup.impl.PrimaryBackupSession | From | To | |
| Change Attribute Type sessions : DefaultServiceSessions to sessions : PrimaryBackupServiceSessions in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceContext | From | To | |
| Change Attribute Type sessions : Map<Long,Session> to sessions : Map<Long,PrimaryBackupSession> in class io.atomix.protocols.backup.service.impl.PrimaryBackupServiceSessions | From | To | |
| Change Attribute Type communicationService : ClusterCommunicationService to sessionIdService : SessionIdService in class io.atomix.protocols.backup.PrimaryBackupClient | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public request(primitive PrimitiveDescriptor, session long, node NodeId, operation PrimitiveOperation) : ExecuteRequest extracted from public execute(operation PrimitiveOperation) : CompletableFuture<byte[]> in class io.atomix.protocols.backup.proxy.PrimaryBackupProxy & moved to class io.atomix.protocols.backup.protocol.ExecuteRequest | From | To | |
| Extract And Move Method public request(primitiveType String) : MetadataRequest extracted from public getPrimitives(primitiveType PrimitiveType) : CompletableFuture<Set<String>> in class io.atomix.protocols.backup.PrimaryBackupClient & moved to class io.atomix.protocols.backup.protocol.MetadataRequest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter communicationService : ClusterCommunicationService to sessionIdService : SessionIdService in method public withSessionIdProvider(sessionIdService SessionIdService) : Builder in class io.atomix.protocols.backup.PrimaryBackupClient.Builder | From | To | |
| Rename Parameter sessionId : long to session : long in method public ExecuteRequest(primitive PrimitiveDescriptor, session long, node NodeId, operation PrimitiveOperation) in class io.atomix.protocols.backup.protocol.ExecuteRequest | From | To |