atomix 216596d0bae7a969f55282874584d01bcb06f2c8

216596d0bae7a969f55282874584d01bcb06f2c8

Files Diff

Added: 13
Removed: 7
Renamed: 0
Modified: 44

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass io.atomix.resource.AbstractResource from class io.atomix.resource.Resource	From	To
Change Parameter Type	4
Change Parameter Type type : int to type : ResourceType in method public GetResource(key String, type ResourceType, config Properties) in class io.atomix.manager.state.GetResource	From	To
Change Parameter Type type : ResourceType to config : Properties in method public AbstractValueState(config Properties) in class io.atomix.variables.state.AbstractValueState	From	To
Change Parameter Type type : int to type : ResourceType in method public GetResourceIfExists(key String, type ResourceType) in class io.atomix.manager.state.GetResourceIfExists	From	To
Change Parameter Type type : ResourceType to config : Properties in method protected ResourceStateMachine(config Properties) in class io.atomix.resource.ResourceStateMachine	From	To
Move Method	1
Move Method public config() : Properties from class io.atomix.resource.util.ResourceCommand.Configure to public config() : Properties from class io.atomix.manager.state.GetResource	From	To
Push Down Attribute	8
Push Down Attribute private state : State from class io.atomix.resource.Resource to private state : State from class io.atomix.resource.AbstractResource	From	To
Push Down Attribute protected client : CopycatClient from class io.atomix.resource.Resource to protected client : CopycatClient from class io.atomix.resource.AbstractResource	From	To
Push Down Attribute private readConsistency : ReadConsistency from class io.atomix.resource.Resource to private readConsistency : ReadConsistency from class io.atomix.resource.AbstractResource	From	To
Push Down Attribute private changeListeners : Set<StateChangeListener> from class io.atomix.resource.Resource to private changeListeners : Set<StateChangeListener> from class io.atomix.resource.AbstractResource	From	To
Push Down Attribute private writeConsistency : WriteConsistency from class io.atomix.resource.Resource to private writeConsistency : WriteConsistency from class io.atomix.resource.AbstractResource	From	To
Push Down Attribute protected config : Config from class io.atomix.resource.Resource to protected config : Config from class io.atomix.resource.AbstractResource	From	To
Push Down Attribute protected options : Options from class io.atomix.resource.Resource to protected options : Options from class io.atomix.resource.AbstractResource	From	To
Push Down Attribute private type : ResourceType from class io.atomix.resource.Resource to private type : ResourceType from class io.atomix.resource.AbstractResource	From	To
Move Attribute	3
Move Attribute private type : ResourceType from class io.atomix.resource.ResourceStateMachine to private type : ResourceType from class io.atomix.resource.AbstractResource	From	To
Move Attribute private config : Properties from class io.atomix.resource.util.ResourceCommand.Configure to protected config : Properties from class io.atomix.resource.ResourceStateMachine	From	To
Move Attribute private config : Properties from class io.atomix.resource.util.ResourceCommand.Configure to private config : Properties from class io.atomix.resource.util.ResourceInstance	From	To
Move Class	1
Move Class io.atomix.resource.Resource.StateChangeListener moved to io.atomix.resource.AbstractResource.StateChangeListener	From	To
Extract Method	2
Extract Method protected createServers(live int, total int, config Resource.Config) : List<CopycatServer> extracted from protected createServers(live int, total int) : List<CopycatServer> in class io.atomix.testing.AbstractCopycatTest	From	To
Extract Method protected createServer(address Address, config Resource.Config) : CopycatServer extracted from protected createServer(address Address) : CopycatServer in class io.atomix.testing.AbstractCopycatTest	From	To
Push Down Method	24
Push Down Method private onStateChange(state CopycatClient.State) : void from class io.atomix.resource.Resource to private onStateChange(state CopycatClient.State) : void from class io.atomix.resource.AbstractResource	From	To
Push Down Method public context() : ThreadContext from class io.atomix.resource.Resource to public context() : ThreadContext from class io.atomix.resource.AbstractResource	From	To
Push Down Method protected submit(command Command<R>) : CompletableFuture<R> from class io.atomix.resource.Resource to protected submit(command Command<R>) : CompletableFuture<R> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public close() : CompletableFuture<Void> from class io.atomix.resource.Resource to public close() : CompletableFuture<Void> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public equals(object Object) : boolean from class io.atomix.resource.Resource to public equals(object Object) : boolean from class io.atomix.resource.AbstractResource	From	To
Push Down Method public isOpen() : boolean from class io.atomix.resource.Resource to public isOpen() : boolean from class io.atomix.resource.AbstractResource	From	To
Push Down Method public toString() : String from class io.atomix.resource.Resource to public toString() : String from class io.atomix.resource.AbstractResource	From	To
Push Down Method protected submit(query Query<R>) : CompletableFuture<R> from class io.atomix.resource.Resource to protected submit(query Query<R>) : CompletableFuture<R> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public readConsistency() : ReadConsistency from class io.atomix.resource.Resource to public readConsistency() : ReadConsistency from class io.atomix.resource.AbstractResource	From	To
Push Down Method protected submit(query Query<R>, consistency ReadConsistency) : CompletableFuture<R> from class io.atomix.resource.Resource to protected submit(query Query<R>, consistency ReadConsistency) : CompletableFuture<R> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public state() : State from class io.atomix.resource.Resource to public state() : State from class io.atomix.resource.AbstractResource	From	To
Push Down Method public type() : ResourceType from class io.atomix.resource.Resource to public type() : ResourceType from class io.atomix.resource.AbstractResource	From	To
Push Down Method public writeConsistency() : WriteConsistency from class io.atomix.resource.Resource to public writeConsistency() : WriteConsistency from class io.atomix.resource.AbstractResource	From	To
Push Down Method protected Resource(client CopycatClient, config Properties, options Properties) from class io.atomix.resource.Resource to protected AbstractResource(client CopycatClient, options Properties) from class io.atomix.resource.AbstractResource	From	To
Push Down Method public config() : Config from class io.atomix.resource.Resource to public config() : Config from class io.atomix.resource.AbstractResource	From	To
Push Down Method public options() : Options from class io.atomix.resource.Resource to public options() : Options from class io.atomix.resource.AbstractResource	From	To
Push Down Method public isClosed() : boolean from class io.atomix.resource.Resource to public isClosed() : boolean from class io.atomix.resource.AbstractResource	From	To
Push Down Method public open() : CompletableFuture<T> from class io.atomix.resource.Resource to public open() : CompletableFuture<T> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public hashCode() : int from class io.atomix.resource.Resource to public hashCode() : int from class io.atomix.resource.AbstractResource	From	To
Push Down Method protected submit(command Command<R>, consistency WriteConsistency) : CompletableFuture<R> from class io.atomix.resource.Resource to protected submit(command Command<R>, consistency WriteConsistency) : CompletableFuture<R> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public with(consistency WriteConsistency) : T from class io.atomix.resource.Resource to public with(consistency WriteConsistency) : T from class io.atomix.resource.AbstractResource	From	To
Push Down Method public delete() : CompletableFuture<Void> from class io.atomix.resource.Resource to public delete() : CompletableFuture<Void> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public onStateChange(callback Consumer<State>) : Listener<State> from class io.atomix.resource.Resource to public onStateChange(callback Consumer<State>) : Listener<State> from class io.atomix.resource.AbstractResource	From	To
Push Down Method public with(consistency ReadConsistency) : T from class io.atomix.resource.Resource to public with(consistency ReadConsistency) : T from class io.atomix.resource.AbstractResource	From	To
Inline Method	1
Inline Method public resource() : Class<? extends Resource> inlined to public factory() : Class<? extends ResourceFactory<?>> in class io.atomix.resource.ResourceType	From	To
Change Return Type	2
Change Return Type ResourceFactory to Class<? extends ResourceFactory<?>> in method public factory() : Class<? extends ResourceFactory<?>> in class io.atomix.resource.ResourceType	From	To
Change Return Type int to ResourceType in method public type() : ResourceType in class io.atomix.manager.state.GetResource	From	To
Extract Superclass	1
Extract Superclass io.atomix.resource.AbstractResource from classes [io.atomix.collections.DistributedMap, io.atomix.collections.DistributedMultiMap, io.atomix.collections.DistributedQueue, io.atomix.collections.DistributedSet, io.atomix.coordination.DistributedGroup, io.atomix.coordination.DistributedLock, io.atomix.AtomixClientTest.TestResource, io.atomix.AtomixClientTest.ValueResource, io.atomix.AtomixReplicaTest.TestResource, io.atomix.AtomixReplicaTest.ValueResource, io.atomix.messaging.DistributedMessageBus, io.atomix.messaging.DistributedTaskQueue, io.atomix.messaging.DistributedTopic, io.atomix.variables.AbstractDistributedValue]	From	To
Rename Attribute	1
Rename Attribute stateMachine : Class<? extends ResourceStateMachine> to factory : Class<? extends ResourceFactory<?>> in class io.atomix.resource.ResourceType	From	To
Change Attribute Type	2
Change Attribute Type type : int to type : ResourceType in class io.atomix.manager.state.GetResource	From	To
Change Attribute Type stateMachine : Class<? extends ResourceStateMachine> to factory : Class<? extends ResourceFactory<?>> in class io.atomix.resource.ResourceType	From	To
Rename Parameter	2
Rename Parameter type : ResourceType to config : Properties in method public AbstractValueState(config Properties) in class io.atomix.variables.state.AbstractValueState	From	To
Rename Parameter type : ResourceType to config : Properties in method protected ResourceStateMachine(config Properties) in class io.atomix.resource.ResourceStateMachine	From	To

216596d0bae7a969f55282874584d01bcb06f2c8

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: