atomix 5a4ce28c51d2d1aa3f61c908f10a358be500470e

5a4ce28c51d2d1aa3f61c908f10a358be500470e

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public getServiceRegistry() : RaftServiceRegistry renamed to public getServices() : RaftServiceRegistry in class io.atomix.protocols.raft.impl.RaftContext	From	To
Rename Method public getFactory(type String) : Supplier<RaftService> renamed to public get(name String) : DefaultServiceContext in class io.atomix.protocols.raft.impl.RaftServiceRegistry	From	To
Move And Rename Method	1
Move And Rename Method private incrementLoadCounter() : void from class io.atomix.protocols.raft.impl.RaftServiceManager to public increment() : void from class io.atomix.protocols.raft.utils.LoadMonitor	From	To
Change Parameter Type	1
Change Parameter Type registry : RaftServiceRegistry to serviceFactories : RaftServiceFactoryRegistry in method public RaftContext(name String, type RaftMember.Type, localMemberId MemberId, protocol RaftServerProtocol, storage RaftStorage, serviceFactories RaftServiceFactoryRegistry, threadModel ThreadModel, threadPoolSize int) in class io.atomix.protocols.raft.impl.RaftContext	From	To
Move Method	13
Move Method private snapshotServices(services List<DefaultServiceContext>, force boolean) : CompletableFuture<Void> from class io.atomix.protocols.raft.impl.RaftServiceManager to private snapshotServices(services List<DefaultServiceContext>, force boolean) : CompletableFuture<Void> from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private rescheduleSnapshots(services List<DefaultServiceContext>, attempt int, futures List<CompletableFuture<Void>>) : CompletableFuture<Void> from class io.atomix.protocols.raft.impl.RaftServiceManager to private rescheduleSnapshots(services List<DefaultServiceContext>, force boolean, attempt int, futures List<CompletableFuture<Void>>) : CompletableFuture<Void> from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private shouldCompact() : boolean from class io.atomix.protocols.raft.impl.RaftServiceManager to private shouldCompact() : boolean from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private snapshotServices(services List<DefaultServiceContext>, force boolean, attempt int, futures List<CompletableFuture<Void>>) : CompletableFuture<Void> from class io.atomix.protocols.raft.impl.RaftServiceManager to private snapshotServices(services List<DefaultServiceContext>, force boolean, attempt int, futures List<CompletableFuture<Void>>) : CompletableFuture<Void> from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private scheduleCompaction(lastApplied long, startTime long) : void from class io.atomix.protocols.raft.impl.RaftServiceManager to private scheduleCompaction(lastApplied long, startTime long) : void from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private compactLogs(compactIndex long, startTime long) : void from class io.atomix.protocols.raft.impl.RaftServiceManager to private compactLogs(compactIndex long, startTime long) : void from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method public toString() : String from class io.atomix.protocols.raft.impl.RaftServiceRegistry to public toString() : String from class io.atomix.protocols.raft.impl.RaftServiceFactoryRegistry	From	To
Move Method private recordCompactionTime(time long) : void from class io.atomix.protocols.raft.impl.RaftServiceManager to private recordCompactionTime(time long) : void from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method public size() : int from class io.atomix.protocols.raft.impl.RaftServiceRegistry to public size() : int from class io.atomix.protocols.raft.impl.RaftServiceFactoryRegistry	From	To
Move Method private selectService(services List<DefaultServiceContext>, force boolean) : DefaultServiceContext from class io.atomix.protocols.raft.impl.RaftServiceManager to private selectService(services List<DefaultServiceContext>, force boolean) : DefaultServiceContext from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private getCompactionTime() : long from class io.atomix.protocols.raft.impl.RaftServiceManager to private getCompactionTime() : long from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private scheduleSnapshots() : void from class io.atomix.protocols.raft.impl.RaftServiceManager to private scheduleSnapshots() : void from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Method private scheduleCompletion(serviceContext DefaultServiceContext, snapshotIndex long) : CompletableFuture<Void> from class io.atomix.protocols.raft.impl.RaftServiceManager to private scheduleCompletion(serviceContext DefaultServiceContext, snapshotIndex long) : CompletableFuture<Void> from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Change Return Type	2
Change Return Type void to CompletableFuture<Void> in method private appendInitialEntries() : CompletableFuture<Void> in class io.atomix.protocols.raft.roles.LeaderRole	From	To
Change Return Type Supplier<RaftService> to DefaultServiceContext in method public get(name String) : DefaultServiceContext in class io.atomix.protocols.raft.impl.RaftServiceRegistry	From	To
Move Attribute	13
Move Attribute private DEFAULT_COMPACTION_TIME : long from class io.atomix.protocols.raft.impl.RaftServiceManager to private DEFAULT_COMPACTION_TIME : long from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private lastCompacted : long from class io.atomix.protocols.raft.impl.RaftServiceManager to private lastCompacted : long from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private COMPACTION_WINDOW_SIZE : int from class io.atomix.protocols.raft.impl.RaftServiceManager to private COMPACTION_WINDOW_SIZE : int from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private threadContext : ThreadContext from class io.atomix.protocols.raft.impl.RaftServiceManager to private threadContext : ThreadContext from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private stateMachines : Map<String,Supplier<RaftService>> from class io.atomix.protocols.raft.impl.RaftServiceRegistry to private stateMachines : Map<String,Supplier<RaftService>> from class io.atomix.protocols.raft.impl.RaftServiceFactoryRegistry	From	To
Move Attribute private HIGH_LOAD_THRESHOLD : int from class io.atomix.protocols.raft.impl.RaftServiceManager to private HIGH_LOAD_THRESHOLD : int from class io.atomix.protocols.raft.impl.RaftContext	From	To
Move Attribute private compactionStats : DescriptiveStatistics from class io.atomix.protocols.raft.impl.RaftServiceManager to private compactionStats : DescriptiveStatistics from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private LOAD_WINDOW : int from class io.atomix.protocols.raft.impl.RaftServiceManager to private LOAD_WINDOW : int from class io.atomix.protocols.raft.impl.RaftContext	From	To
Move Attribute private SNAPSHOT_INTERVAL : Duration from class io.atomix.protocols.raft.impl.RaftServiceManager to private SNAPSHOT_INTERVAL : Duration from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private MIN_COMPACT_INTERVAL : Duration from class io.atomix.protocols.raft.impl.RaftServiceManager to private MIN_COMPACT_INTERVAL : Duration from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private COMPACTION_TIME_FACTOR : int from class io.atomix.protocols.raft.impl.RaftServiceManager to private COMPACTION_TIME_FACTOR : int from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private random : Random from class io.atomix.protocols.raft.impl.RaftServiceManager to private random : Random from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Move Attribute private LOAD_WINDOW_SIZE : int from class io.atomix.protocols.raft.impl.RaftServiceManager to private LOAD_WINDOW_SIZE : int from class io.atomix.protocols.raft.impl.RaftContext	From	To
Extract Class	2
Extract Class io.atomix.protocols.raft.impl.RaftServiceFactoryRegistry from class io.atomix.protocols.raft.impl.RaftServiceRegistry	From	To
Extract Class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor from class io.atomix.protocols.raft.impl.RaftServiceManager	From	To
Rename Attribute	2
Rename Attribute stateMachines : Map<String,Supplier<RaftService>> to services : Map<String,DefaultServiceContext> in class io.atomix.protocols.raft.impl.RaftServiceRegistry	From	To
Rename Attribute registry : RaftServiceRegistry to serviceFactories : RaftServiceFactoryRegistry in class io.atomix.protocols.raft.impl.RaftContext	From	To
Extract Method	5
Extract Method private appendEntry(index long, entry RaftLogEntry, writer RaftLogWriter, future CompletableFuture<AppendResponse>) : boolean extracted from protected appendEntries(request AppendRequest, future CompletableFuture<AppendResponse>) : void in class io.atomix.protocols.raft.roles.PassiveRole	From	To
Extract Method public compact() : CompletableFuture<Void> extracted from private compactLogs(compactIndex long, startTime long) : void in class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor	From	To
Change Attribute Type	4
Change Attribute Type stateMachines : Map<String,Supplier<RaftService>> to services : Map<String,DefaultServiceContext> in class io.atomix.protocols.raft.impl.RaftServiceRegistry	From	To
Change Attribute Type services : Map<String,DefaultServiceContext> to services : RaftServiceRegistry in class io.atomix.protocols.raft.impl.RaftServiceManager	From	To
Change Attribute Type registry : RaftServiceRegistry to serviceFactories : RaftServiceFactoryRegistry in class io.atomix.protocols.raft.impl.RaftContext	From	To
Change Attribute Type serviceRegistry : RaftServiceRegistry to serviceRegistry : RaftServiceFactoryRegistry in class io.atomix.protocols.raft.RaftServer.Builder	From	To
Extract And Move Method	1
Extract And Move Method public register(service DefaultServiceContext) : void extracted from private getOrInitializeService(serviceId ServiceId, serviceType ServiceType, serviceName String) : DefaultServiceContext in class io.atomix.protocols.raft.impl.RaftServiceManager & moved to class io.atomix.protocols.raft.impl.RaftServiceRegistry	From	To
Rename Parameter	2
Rename Parameter type : String to name : String in method public get(name String) : DefaultServiceContext in class io.atomix.protocols.raft.impl.RaftServiceRegistry	From	To
Rename Parameter registry : RaftServiceRegistry to serviceFactories : RaftServiceFactoryRegistry in method public RaftContext(name String, type RaftMember.Type, localMemberId MemberId, protocol RaftServerProtocol, storage RaftStorage, serviceFactories RaftServiceFactoryRegistry, threadModel ThreadModel, threadPoolSize int) in class io.atomix.protocols.raft.impl.RaftContext	From	To

5a4ce28c51d2d1aa3f61c908f10a358be500470e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: