8404706b4ca2481f38e1344b5856da173ed4ba93
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public getStateMachine() : RaftServiceManager renamed to public getServiceManager() : RaftServiceManager in class io.atomix.protocols.raft.impl.RaftContext | From | To | |
| Rename Method private restoreService(reader SnapshotReader) : RaftServiceContext renamed to private installService(reader SnapshotReader) : void in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Rename Method public getSnapshotById(id PrimitiveId) : Snapshot renamed to public getSnapshot(index long) : Snapshot in class io.atomix.protocols.raft.storage.snapshot.SnapshotStore | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public toString() : String from class io.atomix.protocols.raft.storage.snapshot.MemorySnapshot to public toString() : String from class io.atomix.protocols.raft.storage.snapshot.Snapshot | From | To | |
| Move And Rename Method | 3 | ||
| Move And Rename Method private snapshotServices(rescheduleAfterCompletion boolean, force boolean) : CompletableFuture<Void> from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor to private takeSnapshots(rescheduleAfterCompletion boolean, force boolean) : CompletableFuture<Void> from class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Move And Rename Method public takeSnapshot(index long) : CompletableFuture<Long> from class io.atomix.protocols.raft.service.RaftServiceContext to private takeSnapshots(index long) : CompletableFuture<Snapshot> from class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Move And Rename Method private restoreSession(reader SnapshotReader, service RaftServiceContext) : void from class io.atomix.protocols.raft.impl.RaftServiceManager to public installSnapshot(reader SnapshotReader) : void from class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type id : PrimitiveId to index : long in method public getSnapshot(index long) : Snapshot in class io.atomix.protocols.raft.storage.snapshot.SnapshotStore | From | To | |
| Move Method | 2 | ||
| Move Method public executor() : ThreadContext from class io.atomix.protocols.raft.service.RaftServiceContext to public executor() : ThreadContext from class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Move Method private isRunningOutOfDiskSpace() : boolean from class io.atomix.protocols.raft.storage.compactor.RaftLogCompactor to private isRunningOutOfDiskSpace() : boolean from class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type | 16 | ||
| Change Return Type RaftServiceContext to void in method private installService(reader SnapshotReader) : void in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type CompletableFuture<Long> to long in method public openSession(index long, timestamp long, session RaftSession) : long in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Return Type CompletableFuture<OperationResult> to OperationResult in method public executeCommand(index long, sequence long, timestamp long, session RaftSession, operation PrimitiveOperation) : OperationResult in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Return Type CompletableFuture<Boolean> to boolean in method public keepAlive(index long, timestamp long, session RaftSession, commandSequence long, eventIndex long) : boolean in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Return Type void to OperationResult in method private applyCommand(index long, sequence long, timestamp long, operation PrimitiveOperation, session RaftSession) : OperationResult in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Return Type void to OperationResult in method private sequenceCommand(index long, sequence long, session RaftSession) : OperationResult in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Return Type CompletableFuture<long[]> to long[] in method private applyKeepAlive(entry Indexed<KeepAliveEntry>) : long[] in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type CompletableFuture<Long> to CompletableFuture<Snapshot> in method private takeSnapshots(index long) : CompletableFuture<Snapshot> in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type CompletableFuture<Void> to void in method public closeSession(index long, timestamp long, session RaftSession, expired boolean) : void in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Return Type CompletableFuture<Void> to void in method private applyCloseSession(entry Indexed<CloseSessionEntry>) : void in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type CompletableFuture<MetadataResult> to MetadataResult in method private applyMetadata(entry Indexed<MetadataEntry>) : MetadataResult in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type CompletableFuture<Long> to long in method private applyOpenSession(entry Indexed<OpenSessionEntry>) : long in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type CompletableFuture<Void> to void in method public keepAliveSessions(index long, timestamp long) : void in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Change Return Type CompletableFuture<OperationResult> to OperationResult in method private applyCommand(entry Indexed<CommandEntry>) : OperationResult in class io.atomix.protocols.raft.impl.RaftServiceManager | From | To | |
| Change Return Type Journal<TestEntry> to SegmentedJournal<TestEntry> in method private createJournal(storageLevel StorageLevel) : SegmentedJournal<TestEntry> in class io.atomix.storage.journal.JournalTest | From | To | |
| Change Return Type CompletableFuture<Void> to void in method public completeKeepAlive(index long, timestamp long) : void in class io.atomix.protocols.raft.service.RaftServiceContext | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute serviceSnapshots : Map<PrimitiveId,Snapshot> to snapshots : NavigableMap<Long,Snapshot> in class io.atomix.protocols.raft.storage.snapshot.SnapshotStore | From | To | |
| Extract Variable | 2 | ||
| Extract Variable manager : RaftServiceManager in method private createSession(sessionId long) : RaftSession from class io.atomix.protocols.raft.service.RaftSessionsTest | From | To | |
| Extract Variable manager : RaftServiceManager in method private createSession(sessionId long) : RaftSession from class io.atomix.protocols.raft.session.RaftSessionRegistryTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type serviceSnapshots : Map<PrimitiveId,Snapshot> to snapshots : NavigableMap<Long,Snapshot> in class io.atomix.protocols.raft.storage.snapshot.SnapshotStore | From | To | |
| Inline Variable | 1 | ||
| Inline Variable nextSnapshot : Snapshot in method protected appendEntries(member RaftMemberContext) : void from class io.atomix.protocols.raft.roles.LeaderAppender | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter id : PrimitiveId to index : long in method public getSnapshot(index long) : Snapshot in class io.atomix.protocols.raft.storage.snapshot.SnapshotStore | From | To | |
| Rename Parameter serviceName : String to serverName : String in method package createSnapshotFileName(serverName String, index long) : String in class io.atomix.protocols.raft.storage.snapshot.SnapshotFile | From | To | |
| Rename Parameter serviceName : String to serverName : String in method package createSnapshotFile(directory File, serverName String, index long) : File in class io.atomix.protocols.raft.storage.snapshot.SnapshotFile | From | To |