b34d7b8cd7e1d7af1c38f0e23770acd7ec6d9054
Files Diff
- Added: 11
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public testSendAutoTimeout() : void renamed to public testSendAndReceiveWithDynamicTimeout() : void in class io.atomix.cluster.messaging.impl.NettyMessagingServiceTest | From | To | |
| Rename Method public testSendTimeout() : void renamed to public testSendAndReceiveWithFixedTimeout() : void in class io.atomix.cluster.messaging.impl.NettyMessagingServiceTest | From | To | |
| Rename Method private executeOnTemporaryConnection(address Address, type String, callback Function<ClientConnection,CompletableFuture<T>>, executor Executor) : CompletableFuture<T> renamed to private executeOnTransientConnection(address Address, callback Function<ClientConnection,CompletableFuture<T>>, executor Executor) : CompletableFuture<T> in class io.atomix.cluster.messaging.impl.NettyMessagingService | From | To | |
| Rename Method private getOrCreateRemoteClientConnection(channel Channel) : RemoteClientConnection renamed to private getOrCreateClientConnection(channel Channel) : RemoteClientConnection in class io.atomix.cluster.messaging.impl.NettyMessagingService | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public close() : void from class io.atomix.cluster.messaging.impl.NettyMessagingService.RemoteClientConnection to public close() : void from class io.atomix.cluster.messaging.impl.AbstractClientConnection | From | To | |
| Pull Up Method private dispatch(message ProtocolReply) : void from class io.atomix.cluster.messaging.impl.NettyMessagingService.RemoteClientConnection to public dispatch(message ProtocolReply) : void from class io.atomix.cluster.messaging.impl.AbstractClientConnection | From | To | |
| Move Method | 3 | ||
| Move Method private getChannelOffset(messageType String) : int from class io.atomix.cluster.messaging.impl.NettyMessagingService to private getChannelOffset(messageType String) : int from class io.atomix.cluster.messaging.impl.ChannelPool | From | To | |
| Move Method private getChannel(address Address, messageType String) : CompletableFuture<Channel> from class io.atomix.cluster.messaging.impl.NettyMessagingService to package getChannel(address Address, messageType String) : CompletableFuture<Channel> from class io.atomix.cluster.messaging.impl.ChannelPool | From | To | |
| Move Method private getChannelPool(address Address) : List<CompletableFuture<Channel>> from class io.atomix.cluster.messaging.impl.NettyMessagingService to private getChannelPool(address Address) : List<CompletableFuture<Channel>> from class io.atomix.cluster.messaging.impl.ChannelPool | From | To | |
| Move Attribute | 7 | ||
| Move Attribute private EMPTY_PAYLOAD : byte[] from class io.atomix.cluster.messaging.impl.NettyMessagingService to private EMPTY_PAYLOAD : byte[] from class io.atomix.cluster.messaging.impl.RemoteServerConnection | From | To | |
| Move Attribute private MAX_TIMEOUT_MILLIS : long from class io.atomix.cluster.messaging.impl.NettyMessagingService to private MAX_TIMEOUT_MILLIS : long from class io.atomix.cluster.messaging.impl.AbstractClientConnection | From | To | |
| Move Attribute private EMPTY_PAYLOAD : byte[] from class io.atomix.cluster.messaging.impl.NettyMessagingService to private EMPTY_PAYLOAD : byte[] from class io.atomix.cluster.messaging.impl.LocalServerConnection | From | To | |
| Move Attribute private channels : Map<Address,List<CompletableFuture<Channel>>> from class io.atomix.cluster.messaging.impl.NettyMessagingService to private channels : Map<Address,List<CompletableFuture<Channel>>> from class io.atomix.cluster.messaging.impl.ChannelPool | From | To | |
| Move Attribute private MIN_SAMPLES : int from class io.atomix.cluster.messaging.impl.NettyMessagingService to private MIN_SAMPLES : int from class io.atomix.cluster.messaging.impl.AbstractClientConnection | From | To | |
| Move Attribute private MIN_TIMEOUT_MILLIS : long from class io.atomix.cluster.messaging.impl.NettyMessagingService to private MIN_TIMEOUT_MILLIS : long from class io.atomix.cluster.messaging.impl.AbstractClientConnection | From | To | |
| Move Attribute private WINDOW_SIZE : int from class io.atomix.cluster.messaging.impl.NettyMessagingService to private WINDOW_SIZE : int from class io.atomix.cluster.messaging.impl.AbstractClientConnection | From | To | |
| Extract Class | 2 | ||
| Extract Class io.atomix.cluster.messaging.impl.ChannelPool from class io.atomix.cluster.messaging.impl.NettyMessagingService | From | To | |
| Extract Class io.atomix.cluster.messaging.impl.AbstractClientConnection from class io.atomix.cluster.messaging.impl.NettyMessagingService | From | To | |
| Move Class | 3 | ||
| Move Class io.atomix.cluster.messaging.impl.NettyMessagingService.ServerConnection moved to io.atomix.cluster.messaging.impl.ServerConnection | From | To | |
| Move Class io.atomix.cluster.messaging.impl.NettyMessagingService.RemoteClientConnection moved to io.atomix.cluster.messaging.impl.RemoteClientConnection | From | To | |
| Move Class io.atomix.cluster.messaging.impl.NettyMessagingService.ClientConnection moved to io.atomix.cluster.messaging.impl.ClientConnection | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass io.atomix.cluster.messaging.impl.AbstractClientConnection from classes [io.atomix.cluster.messaging.impl.RemoteClientConnection] | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute localClientConnection : LocalClientConnection to localConnection : LocalClientConnection in class io.atomix.cluster.messaging.impl.NettyMessagingService | From | To | |
| Rename Attribute clientConnections : Map<Channel,RemoteClientConnection> to connections : Map<Channel,RemoteClientConnection> in class io.atomix.cluster.messaging.impl.NettyMessagingService | From | To | |
| Extract Interface | 1 | ||
| Extract Interface io.atomix.cluster.messaging.impl.Connection from classes [io.atomix.cluster.messaging.impl.ClientConnection, io.atomix.cluster.messaging.impl.ServerConnection] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type handlers : Map<String,BiConsumer<ProtocolRequest,ServerConnection>> to handlers : HandlerRegistry in class io.atomix.cluster.messaging.impl.NettyMessagingService | From | To |