0d773c5079f778af0d491c827c22057ade959956
Files Diff
- Added: 21
- Removed: 1
- Renamed: 0
- Modified: 266
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method public call() : File from class com.amazonaws.services.s3.transfer.DownloadCallable to public call() : File from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Pull Up Method private isTimeoutEnabled() : boolean from class com.amazonaws.services.s3.transfer.DownloadCallable to private isTimeoutEnabled() : boolean from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type s3 : AmazonS3 to serviceCall : Callable<S3Object> in method public DownloadS3ObjectCallable(serviceCall Callable<S3Object>, destinationFile File, position long) in class com.amazonaws.services.s3.transfer.internal.DownloadS3ObjectCallable | From | To | |
| Pull Up Attribute | 7 | ||
| Pull Up Attribute private futures : List<Future<Long>> from class com.amazonaws.services.s3.transfer.DownloadCallable to protected futures : List<Future<Long>> from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Pull Up Attribute private timedExecutor : ScheduledExecutorService from class com.amazonaws.services.s3.transfer.DownloadCallable to private timedExecutor : ScheduledExecutorService from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Pull Up Attribute private isDownloadParallel : boolean from class com.amazonaws.services.s3.transfer.DownloadCallable to private isDownloadParallel : boolean from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Pull Up Attribute private timeout : long from class com.amazonaws.services.s3.transfer.DownloadCallable to private timeout : long from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Pull Up Attribute private executor : ExecutorService from class com.amazonaws.services.s3.transfer.DownloadCallable to protected executor : ExecutorService from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Pull Up Attribute private dstfile : File from class com.amazonaws.services.s3.transfer.DownloadCallable to protected dstfile : File from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Pull Up Attribute private latch : CountDownLatch from class com.amazonaws.services.s3.transfer.DownloadCallable to private latch : CountDownLatch from class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Rename Class | 1 | ||
| Rename Class com.amazonaws.services.s3.transfer.internal.DownloadPartCallable renamed to com.amazonaws.services.s3.transfer.internal.DownloadS3ObjectCallable | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable from classes [com.amazonaws.services.s3.transfer.DownloadCallable] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute s3 : AmazonS3 to serviceCall : Callable<S3Object> in class com.amazonaws.services.s3.transfer.internal.DownloadS3ObjectCallable | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.amazonaws.services.s3.transfer.AbortableTransfer from classes [com.amazonaws.services.s3.transfer.Download] | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type download : DownloadImpl to download : AbstractTransfer in class com.amazonaws.services.s3.transfer.internal.DownloadMonitor | From | To | |
| Change Attribute Type s3 : AmazonS3 to serviceCall : Callable<S3Object> in class com.amazonaws.services.s3.transfer.internal.DownloadS3ObjectCallable | From | To | |
| Extract Method | 2 | ||
| Extract Method private postProcessS3Object(s3Object S3Object, skipClientSideValidation boolean, listener ProgressListener) : void extracted from public getObject(getObjectRequest GetObjectRequest) : S3Object in class com.amazonaws.services.s3.AmazonS3Client | From | To | |
| Extract Method private cleanupAfterException() : void extracted from public call() : File in class com.amazonaws.services.s3.transfer.internal.AbstractDownloadCallable | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter s3 : AmazonS3 to serviceCall : Callable<S3Object> in method public DownloadS3ObjectCallable(serviceCall Callable<S3Object>, destinationFile File, position long) in class com.amazonaws.services.s3.transfer.internal.DownloadS3ObjectCallable | From | To |