69f90164d3d47a67bb0a0b45e69aff35adea621a
Files Diff
- Added: 154
- Removed: 0
- Renamed: 0
- Modified: 196
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Move And Rename Method | 1 | ||
Move And Rename Method package of(sourceType Class<S>, targetType Class<T>) : DynamoDBTypeConverter<S,T> from class com.amazonaws.services.dynamodbv2.datamodeling.StandardTypeConverters to public getConverter(sourceType Class<S>, targetType Class<T>) : DynamoDBTypeConverter<S,T> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.AbstractDelegateFactory | From | To | |
Move And Inline Method | 3 | ||
Move And Inline Method package join(sourceType Class<S>, targetType Class<T>) : DynamoDBTypeConverter<S,T> moved from class com.amazonaws.services.dynamodbv2.datamodeling.StandardTypeConverters.Scalar to class com.amazonaws.services.dynamodbv2.datamodeling.StandardTypeConverters & inlined to public getConverter(sourceType Class<S>, targetType Class<T>) : DynamoDBTypeConverter<S,T> | From | To | |
Move And Inline Method public expectedExists(value V) : ExpectedAttributeValue moved from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperFieldModel to class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTableMapper & inlined to public deleteIfExists(object T) : void | From | To | |
Move And Inline Method public expectedExists(value V) : ExpectedAttributeValue moved from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperFieldModel to class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTableMapper & inlined to public saveIfExists(object T) : void | From | To | |
Change Parameter Type | 8 | ||
Change Parameter Type clazz : Class<?> to clazz : Class<T> in method public generateDeleteTableRequest(clazz Class<T>, config DynamoDBMapperConfig) : DeleteTableRequest in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper | From | To | |
Change Parameter Type clazz : Class<?> to clazz : Class<T> in method public generateCreateTableRequest(clazz Class<T>, config DynamoDBMapperConfig) : CreateTableRequest in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper | From | To | |
Change Parameter Type s3cc : S3ClientCache to s3Links : S3Link.Factory in method private ConversionSchemaFactory(s3Links S3Link.Factory) in class com.amazonaws.services.dynamodbv2.datamodeling.StandardModelFactories.ConversionSchemaFactory | From | To | |
Change Parameter Type batch : Map<String,List<WriteRequest>> to batch : StringListMap<WriteRequest> in method private writeOneBatch(batch StringListMap<WriteRequest>, batchWriteRetryStrategy BatchWriteRetryStrategy) : List<FailedBatch> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper | From | To | |
Change Parameter Type type : ParamType<Collection<V>> to type : ParamType<List<V>> in method public newConverter(type ParamType<List<V>>) : DynamoDBTypeConverter<AttributeValue,List<V>> in class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectList | From | To | |
Change Parameter Type delegate : DynamoDBTypeConverterFactory to builder : Builder in method private OverrideFactory(builder Builder) in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.OverrideFactory | From | To | |
Change Parameter Type field : DynamoDBMapperFieldModel to field : DynamoDBMapperFieldModel<T,Object> in method public with(field DynamoDBMapperFieldModel<T,Object>) : Builder<T> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel.Builder | From | To | |
Change Parameter Type s3cc : S3ClientCache to s3Links : S3Link.Factory in method package of(s3Links S3Link.Factory) : DynamoDBMapperModelFactory.Factory in class com.amazonaws.services.dynamodbv2.datamodeling.StandardModelFactories | From | To | |
Move Method | 4 | ||
Move Method private transformAttributeUpdates(clazz Class<?>, tableName String, keys Map<String,AttributeValue>, updateValues Map<String,AttributeValueUpdate>, config DynamoDBMapperConfig) : Map<String,AttributeValueUpdate> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper to private transformAttributeUpdates(clazz Class<?>, tableName String, keys Map<String,AttributeValue>, updateValues Map<String,AttributeValueUpdate>, config DynamoDBMapperConfig) : Map<String,AttributeValueUpdate> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper.SaveObjectHandler | From | To | |
Move Method public join(source DynamoDBTypeConverter<S,T>, target DynamoDBTypeConverter<T,U>) : DynamoDBTypeConverter<S,U> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.OverrideFactory to package join(source DynamoDBTypeConverter<S,T>, target DynamoDBTypeConverter<T,U>) : DynamoDBTypeConverter<S,U> from class com.amazonaws.services.dynamodbv2.datamodeling.StandardTypeConverters | From | To | |
Move Method public config() : DynamoDBMapperConfig from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTableMapper to public config() : DynamoDBMapperConfig from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperConfig.TableNameOverride | From | To | |
Move Method private convertToItem(putValues Map<String,AttributeValueUpdate>) : Map<String,AttributeValue> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper to private convertToItem(putValues Map<String,AttributeValueUpdate>) : Map<String,AttributeValue> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper.SaveObjectHandler | From | To | |
Pull Up Attribute | 2 | ||
Pull Up Attribute private config : DynamoDBMapperConfig from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper to private config : DynamoDBMapperConfig from class com.amazonaws.services.dynamodbv2.datamodeling.AbstractDynamoDBMapper | From | To | |
Pull Up Attribute private delegate : DynamoDBTypeConverterFactory from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.OverrideFactory to private delegate : DynamoDBTypeConverterFactory from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.AbstractDelegateFactory | From | To | |
Rename Class | 4 | ||
Rename Class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectToStringSet renamed to com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectStringSet | From | To | |
Rename Class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectSetOrList renamed to com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectList | From | To | |
Rename Class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectDocumentMap renamed to com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.DocumentObjectMap | From | To | |
Rename Class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectStringKeyMap renamed to com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectMap | From | To | |
Extract Variable | 2 | ||
Extract Variable value : AttributeValue in method private withRangeKey(rangeKey R) : Key<H,R> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel.Key | From | To | |
Extract Variable value : AttributeValue in method private withHashKey(hashKey H) : Key<H,R> from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel.Key | From | To | |
Change Variable Type | 5 | ||
Change Variable Type o : Collection<T> to o : List<T> in method package join(scalar DynamoDBTypeConverter<S,T>) : DynamoDBTypeConverter<List<S>,List<T>> in class com.amazonaws.services.dynamodbv2.datamodeling.StandardTypeConverters.Vector.LIST | From | To | |
Change Variable Type model : DynamoDBMapperTableModel<Object> to model : DynamoDBMapperTableModel<T> in method public generateCreateTableRequest(clazz Class<T>, config DynamoDBMapperConfig) : CreateTableRequest in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper | From | To | |
Change Variable Type field : DynamoDBMapperFieldModel<Object,Object> to field : DynamoDBMapperFieldModel<T,Object> in method public generateCreateTableRequest(clazz Class<T>, config DynamoDBMapperConfig) : CreateTableRequest in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper | From | To | |
Change Variable Type requestItems : HashMap<String,List<WriteRequest>> to requestItems : StringListMap<WriteRequest> in method public batchWrite(objectsToWrite Iterable<? extends Object>, objectsToDelete Iterable<? extends Object>, config DynamoDBMapperConfig) : List<FailedBatch> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper | From | To | |
Change Variable Type entry : Map.Entry<Key<?,?>,DynamoDBTypeConverter<?,?>> to entry : Entry<Entry<Class<?>,Class<?>>,DynamoDBTypeConverter<?,?>> in method public getConverter(sourceType Class<S>, targetType Class<T>) : DynamoDBTypeConverter<S,T> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.OverrideFactory | From | To | |
Extract Method | 5 | ||
Extract Method public marshallIntoObjects(clazz Class<T>, itemAttributes List<Map<String,AttributeValue>>, config DynamoDBMapperConfig) : List<T> extracted from public marshallIntoObjects(clazz Class<T>, itemAttributes List<Map<String,AttributeValue>>) : List<T> in class com.amazonaws.services.dynamodbv2.datamodeling.AbstractDynamoDBMapper | From | To | |
Extract Method public generateCreateTableRequest(clazz Class<T>, config DynamoDBMapperConfig) : CreateTableRequest extracted from public generateCreateTableRequest(clazz Class<?>) : CreateTableRequest in class com.amazonaws.services.dynamodbv2.datamodeling.AbstractDynamoDBMapper | From | To | |
Extract Method public generateDeleteTableRequest(clazz Class<T>, config DynamoDBMapperConfig) : DeleteTableRequest extracted from public generateDeleteTableRequest(clazz Class<?>) : DeleteTableRequest in class com.amazonaws.services.dynamodbv2.datamodeling.AbstractDynamoDBMapper | From | To | |
Extract Method public marshallIntoObject(clazz Class<T>, itemAttributes Map<String,AttributeValue>, config DynamoDBMapperConfig) : T extracted from public marshallIntoObject(clazz Class<T>, itemAttributes Map<String,AttributeValue>) : T in class com.amazonaws.services.dynamodbv2.datamodeling.AbstractDynamoDBMapper | From | To | |
Extract Method package merge(overrides DynamoDBMapperConfig) : DynamoDBMapperConfig extracted from public DynamoDBMapperConfig(defaults DynamoDBMapperConfig, overrides DynamoDBMapperConfig) in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperConfig | From | To | |
Rename Method | 2 | ||
Rename Method package newFactory(s3cc S3ClientCache) : DynamoDBMapperModelFactory.Factory renamed to package of(s3Links S3Link.Factory) : DynamoDBMapperModelFactory.Factory in class com.amazonaws.services.dynamodbv2.datamodeling.StandardModelFactories | From | To | |
Rename Method public asKey(hashKey H, rangeKey R) : T renamed to public createKey(hashKey H, rangeKey R) : T in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel | From | To | |
Pull Up Method | 2 | ||
Pull Up Method protected getTableName(clazz Class<?>, object Object, config DynamoDBMapperConfig) : String from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper to protected getTableName(clazz Class<?>, object Object, config DynamoDBMapperConfig) : String from class com.amazonaws.services.dynamodbv2.datamodeling.AbstractDynamoDBMapper | From | To | |
Pull Up Method protected getTableName(clazz Class<?>, config DynamoDBMapperConfig) : String from class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper to protected getTableName(clazz Class<?>, config DynamoDBMapperConfig) : String from class com.amazonaws.services.dynamodbv2.datamodeling.AbstractDynamoDBMapper | From | To | |
Rename Variable | 1 | ||
Rename Variable rules : Rules<V> to factory : Rules<V> in method package of(config DynamoDBMapperConfig, s3Links S3Link.Factory, models DynamoDBMapperModelFactory.Factory) : RuleFactory<V> in class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules | From | To | |
Inline Method | 2 | ||
Inline Method public field(keyType KeyType) : DynamoDBMapperFieldModel<T,V> inlined to public rangeKey() : DynamoDBMapperFieldModel<T,R> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel | From | To | |
Inline Method public field(keyType KeyType) : DynamoDBMapperFieldModel<T,V> inlined to public hashKey() : DynamoDBMapperFieldModel<T,H> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel | From | To | |
Change Return Type | 2 | ||
Change Return Type DynamoDBTypeConverter<AttributeValue,Collection<V>> to DynamoDBTypeConverter<AttributeValue,List<V>> in method public newConverter(type ParamType<List<V>>) : DynamoDBTypeConverter<AttributeValue,List<V>> in class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.ObjectList | From | To | |
Change Return Type DynamoDBTypeConverter<List<S>,Collection<T>> to DynamoDBTypeConverter<List<S>,List<T>> in method package join(scalar DynamoDBTypeConverter<S,T>) : DynamoDBTypeConverter<List<S>,List<T>> in class com.amazonaws.services.dynamodbv2.datamodeling.StandardTypeConverters.Vector.LIST | From | To | |
Extract Superclass | 1 | ||
Extract Superclass com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.AbstractDelegateFactory from classes [com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.OverrideFactory] | From | To | |
Rename Attribute | 2 | ||
Rename Attribute factory : DynamoDBMapperModelFactory.Factory to models : DynamoDBMapperModelFactory.Factory in class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.DocumentObjectMap | From | To | |
Rename Attribute s3cc : S3ClientCache to s3Links : S3Link.Factory in class com.amazonaws.services.dynamodbv2.datamodeling.StandardModelFactories.ConversionSchemaFactory | From | To | |
Change Attribute Type | 3 | ||
Change Attribute Type overrides : Map<Key<?,?>,DynamoDBTypeConverter<?,?>> to overrides : Map<Entry<Class<?>,Class<?>>,DynamoDBTypeConverter<?,?>> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.OverrideFactory | From | To | |
Change Attribute Type map : ConverterMap<?> to map : ConverterMap<Object> in class com.amazonaws.services.dynamodbv2.datamodeling.StandardTypeConverters.Scalar | From | To | |
Change Attribute Type s3cc : S3ClientCache to s3Links : S3Link.Factory in class com.amazonaws.services.dynamodbv2.datamodeling.StandardModelFactories.ConversionSchemaFactory | From | To | |
Extract And Move Method | 4 | ||
Extract And Move Method private isRequestEntityTooLarge() : boolean extracted from private writeOneBatch(batch Map<String,List<WriteRequest>>, batchWriteRetryStrategy BatchWriteRetryStrategy) : List<FailedBatch> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper & moved to class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper.FailedBatch | From | To | |
Extract And Move Method private isThrottling() : boolean extracted from private containsThrottlingException(failedBatches List<FailedBatch>) : boolean in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper & moved to class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper.FailedBatch | From | To | |
Extract And Move Method public getAndConvert(object T) : AttributeValue extracted from public convert(object T) : Map<String,AttributeValue> in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel & moved to class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperFieldModel | From | To | |
Extract And Move Method public unconvertAndSet(object T, value AttributeValue) : void extracted from public unconvert(object Map<String,AttributeValue>) : T in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperTableModel & moved to class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapperFieldModel | From | To | |
Rename Parameter | 6 | ||
Rename Parameter converters : DynamoDBTypeConverterFactory to scalars : DynamoDBTypeConverterFactory in method private Rules(scalars DynamoDBTypeConverterFactory) in class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules | From | To | |
Rename Parameter s3cc : S3ClientCache to s3Links : S3Link.Factory in method private ConversionSchemaFactory(s3Links S3Link.Factory) in class com.amazonaws.services.dynamodbv2.datamodeling.StandardModelFactories.ConversionSchemaFactory | From | To | |
Rename Parameter factory : DynamoDBMapperModelFactory.Factory to models : DynamoDBMapperModelFactory.Factory in method private DocumentObjectMap(config DynamoDBMapperConfig, models DynamoDBMapperModelFactory.Factory) in class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules.Rules.DocumentObjectMap | From | To | |
Rename Parameter delegate : DynamoDBTypeConverterFactory to builder : Builder in method private OverrideFactory(builder Builder) in class com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTypeConverterFactory.OverrideFactory | From | To | |
Rename Parameter s3cc : S3ClientCache to s3Links : S3Link.Factory in method package of(s3Links S3Link.Factory) : DynamoDBMapperModelFactory.Factory in class com.amazonaws.services.dynamodbv2.datamodeling.StandardModelFactories | From | To | |
Rename Parameter factory : DynamoDBMapperModelFactory.Factory to models : DynamoDBMapperModelFactory.Factory in method package of(config DynamoDBMapperConfig, s3Links S3Link.Factory, models DynamoDBMapperModelFactory.Factory) : RuleFactory<V> in class com.amazonaws.services.dynamodbv2.datamodeling.StandardConverterRules | From | To |