fb2aaf101dfc9a55d67d3c5b45c2afc37e8ddecb
Files Diff
- Added: 19
- Removed: 1
- Renamed: 0
- Modified: 136
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method private skipContentMd5IntegrityCheck(request AmazonWebServiceRequest) : boolean from class com.amazonaws.services.s3.AmazonS3Client to public skipMd5CheckPerRequest(request AmazonWebServiceRequest) : boolean from class com.amazonaws.services.s3.internal.ServiceUtils | From | To | |
| Move And Rename Method private validIP(IP String) : boolean from class com.amazonaws.services.s3.AmazonS3Client to package isValidIpV4Address(ipAddr String) : boolean from class com.amazonaws.services.s3.internal.S3RequestEndpointResolver | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type bucketName : String to endpointResolver : S3RequestEndpointResolver in method public S3V4AuthErrorRetryStrategy(endpointResolver S3RequestEndpointResolver) in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Move Method | 1 | ||
| Move Method private convertToVirtualHostEndpoint(bucketName String) : URI from class com.amazonaws.services.s3.AmazonS3Client to private convertToVirtualHostEndpoint(endpoint URI, bucketName String) : URI from class com.amazonaws.services.s3.internal.S3RequestEndpointResolver | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private conditionExpression : String from class com.amazonaws.services.dynamodbv2.document.spec.PutItemSpec to private conditionExpression : String from class com.amazonaws.services.dynamodbv2.xspec.PutItemExpressionSpec | From | To | |
| Move Attribute private bucketName : String from class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy to private bucketName : String from class com.amazonaws.services.s3.internal.S3RequestEndpointResolver | From | To | |
| Extract Class | 1 | ||
| Extract Class com.amazonaws.services.s3.internal.S3RequestEndpointResolver from class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Extract Variable | 2 | ||
| Extract Variable awsRequestId : String in method private handleResponse(request Request<?>, responseHandler HttpResponseHandler<AmazonWebServiceResponse<T>>, method HttpRequestBase, httpResponse HttpResponse, apacheHttpResponse HttpResponse, executionContext ExecutionContext, isHeaderReqIdAvail boolean) : T from class com.amazonaws.http.AmazonHttpClient | From | To | |
| Extract Variable etag : String in method public downloadToFile(s3Object S3Object, dstfile File, performIntegrityCheck boolean, appendData boolean, expectedFileLength long) : void from class com.amazonaws.services.s3.internal.ServiceUtils | From | To | |
| Extract Method | 3 | ||
| Extract Method private buildRetryParams(signer AWSS3V4Signer, endpoint URI) : AuthRetryParameters extracted from public shouldRetryWithAuthParam(request Request<?>, ase AmazonServiceException) : AuthRetryParameters in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Extract Method private isSignerOverridden() : boolean extracted from protected createSigner(request Request<?>, bucketName String, key String) : Signer in class com.amazonaws.services.s3.AmazonS3Client | From | To | |
| Extract Method private buildSigV4Signer(region String) : AWSS3V4Signer extracted from public shouldRetryWithAuthParam(request Request<?>, ase AmazonServiceException) : AuthRetryParameters in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Rename Method | 2 | ||
| Rename Method public shouldRetryWithAuthParam(request Request<?>, ase AmazonServiceException) : AuthRetryParameters renamed to private redirectToS3External() : AuthRetryParameters in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Rename Method private logRequestId(res HttpResponse) : HttpResponse renamed to private logHeaderRequestId(res HttpResponse) : boolean in class com.amazonaws.http.AmazonHttpClient | From | To | |
| Rename Variable | 2 | ||
| Rename Variable putRequest : boolean to isPutRequest : boolean in method private isKMSPutRequest(originalRequest AmazonWebServiceRequest) : boolean in class com.amazonaws.services.s3.AmazonS3Client | From | To | |
| Rename Variable serviceName : String to serviceNameForEndpoint : String in method public setRegion(region Region) : void in class com.amazonaws.AmazonWebServiceClient | From | To | |
| Change Return Type | 1 | ||
| Change Return Type HttpResponse to boolean in method private logHeaderRequestId(res HttpResponse) : boolean in class com.amazonaws.http.AmazonHttpClient | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable bucketEndpoint : URI to endpoint : URI in method private buildRetryParams(signer AWSS3V4Signer, endpoint URI) : AuthRetryParameters in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute bucketName : String to endpointResolver : S3RequestEndpointResolver in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Rename Attribute S3_SERVICE_NAME : String to S3_SERVICE_DISPLAY_NAME : String in class com.amazonaws.services.s3.internal.Constants | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type bucketName : String to endpointResolver : S3RequestEndpointResolver in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Rename Parameter | 9 | ||
| Rename Parameter expression : String to projectionExpression : String in method public withProjectionExpression(projectionExpression String) : ScanSpec in class com.amazonaws.services.dynamodbv2.document.spec.ScanSpec | From | To | |
| Rename Parameter bucketName : String to endpointResolver : S3RequestEndpointResolver in method public S3V4AuthErrorRetryStrategy(endpointResolver S3RequestEndpointResolver) in class com.amazonaws.services.s3.internal.S3V4AuthErrorRetryStrategy | From | To | |
| Rename Parameter expression : String to projectionExpression : String in method public withProjectionExpression(projectionExpression String) : QuerySpec in class com.amazonaws.services.dynamodbv2.document.spec.QuerySpec | From | To | |
| Rename Parameter expression : String to filterExpression : String in method public withFilterExpression(filterExpression String) : ScanSpec in class com.amazonaws.services.dynamodbv2.document.spec.ScanSpec | From | To | |
| Rename Parameter conditionalExpression : String to filterExpression : String in method public query(hashKey KeyAttribute, rangeKeyCondition RangeKeyCondition, filterExpression String, nameMap Map<String,String>, valueMap Map<String,Object>) : ItemCollection<QueryOutcome> in class com.amazonaws.services.dynamodbv2.document.internal.QueryImpl | From | To | |
| Rename Parameter IP : String to ipAddr : String in method package isValidIpV4Address(ipAddr String) : boolean in class com.amazonaws.services.s3.internal.S3RequestEndpointResolver | From | To | |
| Rename Parameter expression : String to projectionExpression : String in method public withProjectionExpression(projectionExpression String) : GetItemSpec in class com.amazonaws.services.dynamodbv2.document.spec.GetItemSpec | From | To | |
| Rename Parameter p : ExecOneRequestParams to execParams : ExecOneRequestParams in method private executeOneRequest(request Request<?>, responseHandler HttpResponseHandler<AmazonWebServiceResponse<T>>, errorResponseHandler HttpResponseHandler<AmazonServiceException>, execContext ExecutionContext, awsRequestMetrics AWSRequestMetrics, execParams ExecOneRequestParams) : Response<T> in class com.amazonaws.http.AmazonHttpClient | From | To | |
| Rename Parameter expression : String to filterExpression : String in method public withFilterExpression(filterExpression String) : QuerySpec in class com.amazonaws.services.dynamodbv2.document.spec.QuerySpec | From | To |