32e8d95c79bd8678527080ec6478a373305db66b
Files Diff
- Added: 6
- Removed: 1
- Renamed: 0
- Modified: 35
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public setBinary_annotations(binary_annotations List<BinaryAnnotation>) : Span renamed to public setBinaryAnnotations(binary_annotations List<BinaryAnnotation>) : Span in class com.twitter.zipkin.gen.Span | From | To | |
| Rename Method public setService_name(service_name String) : Endpoint renamed to package Endpoint(service_name String, ipv4 int, port Short) in class com.twitter.zipkin.gen.Endpoint | From | To | |
| Rename Method public findByValue(value int) : AnnotationType renamed to public fromValue(value int) : AnnotationType in class com.twitter.zipkin.gen.AnnotationType | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public getValue() : String moved from class com.twitter.zipkin.gen.Annotation to class com.twitter.zipkin.gen.BinaryAnnotation & inlined to public hashCode() : int | From | To | |
| Change Parameter Type | 5 | ||
| Change Parameter Type value : String to value : byte[] in method package BinaryAnnotation(key String, value byte[], type AnnotationType, host Endpoint) in class com.twitter.zipkin.gen.BinaryAnnotation | From | To | |
| Change Parameter Type debug : boolean to debug : Boolean in method public setDebug(debug Boolean) : Span in class com.twitter.zipkin.gen.Span | From | To | |
| Change Parameter Type duration : long to duration : Long in method public setDuration(duration Long) : Span in class com.twitter.zipkin.gen.Span | From | To | |
| Change Parameter Type parent_id : long to parent_id : Long in method public setParent_id(parent_id Long) : Span in class com.twitter.zipkin.gen.Span | From | To | |
| Change Parameter Type timestamp : long to timestamp : Long in method public setTimestamp(timestamp Long) : Span in class com.twitter.zipkin.gen.Span | From | To | |
| Rename Variable | 5 | ||
| Rename Variable expectedAnnodation : BinaryAnnotation to expectedAnnotation : BinaryAnnotation in method public testSubmitBinaryAnnotationIntValue() : void in class com.github.kristofa.brave.AnnotationSubmitterTest | From | To | |
| Rename Variable expectedBinaryAnnoration2 : BinaryAnnotation to expectedBinaryAnnotation2 : BinaryAnnotation in method public testCollectAfterAddingTwoDefaultAnnotations() : void in class com.github.kristofa.brave.LoggingSpanCollectorTest | From | To | |
| Rename Variable expectedBinaryAnnoration : BinaryAnnotation to expectedBinaryAnnotation : BinaryAnnotation in method public testCollectAfterAddingTwoDefaultAnnotations() : void in class com.github.kristofa.brave.LoggingSpanCollectorTest | From | To | |
| Rename Variable expectedBinaryAnnoration : BinaryAnnotation to expectedBinaryAnnotation : BinaryAnnotation in method public testCollectAfterAddingDefaultAnnotations() : void in class com.github.kristofa.brave.LoggingSpanCollectorTest | From | To | |
| Rename Variable expectedAnnodation : BinaryAnnotation to expectedAnnotation : BinaryAnnotation in method public testSubmitBinaryAnnotationStringValue() : void in class com.github.kristofa.brave.AnnotationSubmitterTest | From | To | |
| Change Return Type | 6 | ||
| Change Return Type long to Long in method public getDuration() : Long in class com.twitter.zipkin.gen.Span | From | To | |
| Change Return Type void to Span in method public addToBinary_annotations(elem BinaryAnnotation) : Span in class com.twitter.zipkin.gen.Span | From | To | |
| Change Return Type long to Long in method public getParent_id() : Long in class com.twitter.zipkin.gen.Span | From | To | |
| Change Return Type void to Span in method public addToAnnotations(elem Annotation) : Span in class com.twitter.zipkin.gen.Span | From | To | |
| Change Return Type boolean to Boolean in method public isDebug() : Boolean in class com.twitter.zipkin.gen.Span | From | To | |
| Change Return Type long to Long in method public getTimestamp() : Long in class com.twitter.zipkin.gen.Span | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type drained : Queue<Span> to drained : List<Span> in method public flush() : void in class com.github.kristofa.brave.http.HttpSpanCollector | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type debug : boolean to debug : Boolean in class com.twitter.zipkin.gen.Span | From | To | |
| Change Attribute Type duration : long to duration : Long in class com.twitter.zipkin.gen.Span | From | To | |
| Change Attribute Type timestamp : long to timestamp : Long in class com.twitter.zipkin.gen.Span | From | To | |
| Change Attribute Type value : ByteBuffer to value : byte[] in class com.twitter.zipkin.gen.BinaryAnnotation | From | To | |
| Change Attribute Type parent_id : long to parent_id : Long in class com.twitter.zipkin.gen.Span | From | To | |
| Change Attribute Type port : short to port : Short in class com.twitter.zipkin.gen.Endpoint | From | To | |
| Extract And Move Method | 16 | ||
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public testSetServerSend() : void in class com.github.kristofa.brave.ServerTracerTest & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public testSetClientSent() : void in class com.github.kristofa.brave.ClientTracerTest & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public testSubmitAnnotationSpanEndpointString() : void in class com.github.kristofa.brave.AnnotationSubmitterTest & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public testSetServerReceived() : void in class com.github.kristofa.brave.ServerTracerTest & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public testSetClientSentServerAddress() : void in class com.github.kristofa.brave.ClientTracerTest & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public submitAnnotation(value String) : void in class com.github.kristofa.brave.AnnotationSubmitter & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(serviceName String, ipv4 int, port int) : Endpoint extracted from public testSetServerReceivedSentClientAddress() : void in class com.github.kristofa.brave.ServerTracerTest & moved to class com.twitter.zipkin.gen.Endpoint | From | To | |
| Extract And Move Method public create(key String, value String, endpoint Endpoint) : BinaryAnnotation extracted from public testCollectAfterAddingTwoDefaultAnnotations() : void in class com.github.kristofa.brave.LoggingSpanCollectorTest & moved to class com.twitter.zipkin.gen.BinaryAnnotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from package submitStartAnnotation(annotationName String) : void in class com.github.kristofa.brave.AnnotationSubmitter & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(serviceName String, ipv4 int) : Endpoint extracted from public setup() : void in class com.github.kristofa.brave.AnnotationSubmitterTest & moved to class com.twitter.zipkin.gen.Endpoint | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public testSetClientReceived() : void in class com.github.kristofa.brave.ClientTracerTest & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from package submitEndAnnotation(annotationName String, spanCollector SpanCollector) : boolean in class com.github.kristofa.brave.AnnotationSubmitter & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(key String, value String, endpoint Endpoint) : BinaryAnnotation extracted from public testCollectAfterAddingDefaultAnnotations() : void in class com.github.kristofa.brave.LoggingSpanCollectorTest & moved to class com.twitter.zipkin.gen.BinaryAnnotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public testSetServerReceivedSentClientAddress() : void in class com.github.kristofa.brave.ServerTracerTest & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(timestamp long, value String, endpoint Endpoint) : Annotation extracted from public submitAnnotation(value String, timestamp long) : void in class com.github.kristofa.brave.AnnotationSubmitter & moved to class com.twitter.zipkin.gen.Annotation | From | To | |
| Extract And Move Method public create(serviceName String, ipv4 int, port int) : Endpoint extracted from public testSetClientSentServerAddress() : void in class com.github.kristofa.brave.ClientTracerTest & moved to class com.twitter.zipkin.gen.Endpoint | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter that : Object to o : Object in method public equals(o Object) : boolean in class com.twitter.zipkin.gen.BinaryAnnotation | From | To | |
| Rename Parameter that : Object to o : Object in method public equals(o Object) : boolean in class com.twitter.zipkin.gen.Endpoint | From | To | |
| Rename Parameter that : Object to o : Object in method public equals(o Object) : boolean in class com.twitter.zipkin.gen.Span | From | To | |
| Rename Parameter thrifts : byte[] to json : byte[] in method package postSpans(json byte[]) : void in class com.github.kristofa.brave.http.HttpSpanCollector | From | To | |
| Rename Parameter that : Object to o : Object in method public equals(o Object) : boolean in class com.twitter.zipkin.gen.Annotation | From | To |