brave 3ab3725e2a9cd012837986010fc17364c5ade1a1

3ab3725e2a9cd012837986010fc17364c5ade1a1

Files Diff

Added: 0
Removed: 3
Renamed: 0
Modified: 19

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	8
Rename Method package _debug(debug boolean) : void renamed to package debug(debug boolean) : InternalBuilder in class brave.propagation.TraceIdContext.InternalBuilder	From	To
Rename Method public builder_notSampled() : void renamed to public notSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public builder_defaultIsEmpty() : void renamed to public defaultIsEmpty() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method package _sampled(sampled Boolean) : void renamed to package sampled(sampled Boolean) : InternalBuilder in class brave.propagation.TraceIdContext.InternalBuilder	From	To
Rename Method package _sampled(sampled boolean) : void renamed to package sampled(sampled boolean) : InternalBuilder in class brave.propagation.TraceIdContext.InternalBuilder	From	To
Rename Method public builder_nullSampled() : void renamed to public nullSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public builder_debugImpliesSampled() : void renamed to public debugImpliesSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public create_sampledTrueDebugFalse() : void renamed to public sampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Push Down Method	2
Push Down Method package parseSpanId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.InternalMutableTraceContext to package parseSpanId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.TraceContext.InternalBuilder	From	To
Push Down Method package parseParentId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.InternalMutableTraceContext to package parseParentId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.TraceContext.InternalBuilder	From	To
Pull Up Method	1
Pull Up Method package logger() : Logger from class brave.propagation.TraceContext.Builder to package logger() : Logger from class brave.propagation.TraceContext.InternalBuilder	From	To
Extract Subclass	1
Extract Subclass brave.propagation.TraceContext.InternalBuilder from class brave.propagation.InternalMutableTraceContext	From	To
Move Method	27
Move Method public parseTraceId_64bit() : void from class brave.propagation.InternalMutableTraceContextTest to public parseTraceId_64bit() : void from class brave.propagation.TraceIdContextTest	From	To
Move Method public parseParentId_malformedReturnsFalse() : void from class brave.propagation.InternalMutableTraceContextTest to public parseParentId_malformedReturnsFalse() : void from class brave.propagation.TraceContextTest	From	To
Move Method public ensureImmutable_convertsToSingletonList() : void from class brave.propagation.InternalMutableTraceContextTest to public ensureImmutable_convertsToSingletonList() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseParentId() : void from class brave.propagation.InternalMutableTraceContextTest to public parseParentId() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseTraceId_short128bit() : void from class brave.propagation.InternalMutableTraceContextTest to public parseTraceId_short128bit() : void from class brave.propagation.TraceIdContextTest	From	To
Move Method package parseGoodSpanId(spanIdString String) : MutableTraceContext from class brave.propagation.InternalMutableTraceContextTest to package parseGoodSpanId(spanIdString String) : TestBuilder from class brave.propagation.TraceContextTest	From	To
Move Method public ensureImmutable_doesntCopyImmutableList() : void from class brave.propagation.InternalMutableTraceContextTest to public ensureImmutable_doesntCopyImmutableList() : void from class brave.propagation.TraceContextTest	From	To
Move Method package parseBadTraceId(traceIdString String) : void from class brave.propagation.InternalMutableTraceContextTest to package parseBadTraceId(traceIdString String) : void from class brave.propagation.TraceIdContextTest	From	To
Move Method public ensureImmutable_returnsImmutableEmptyList() : void from class brave.propagation.InternalMutableTraceContextTest to public ensureImmutable_returnsImmutableEmptyList() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseTraceId_short64bit() : void from class brave.propagation.InternalMutableTraceContextTest to public parseTraceId_short64bit() : void from class brave.propagation.TraceIdContextTest	From	To
Move Method public parseSpanId_short64bit() : void from class brave.propagation.InternalMutableTraceContextTest to public parseSpanId_short64bit() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseSpanId() : void from class brave.propagation.InternalMutableTraceContextTest to public parseSpanId() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseTraceId_whenFineDisabledNoLogs() : void from class brave.propagation.InternalMutableTraceContextTest to public parseTraceId_whenFineDisabledNoLogs() : void from class brave.propagation.TraceIdContextTest	From	To
Move Method public ensureImmutable_returnsEmptyList() : void from class brave.propagation.InternalMutableTraceContextTest to public ensureImmutable_returnsEmptyList() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseTraceId_malformedReturnsFalse() : void from class brave.propagation.InternalMutableTraceContextTest to public parseTraceId_malformedReturnsFalse() : void from class brave.propagation.TraceIdContextTest	From	To
Move Method public parseSpanId_whenFineDisabledNoLogs() : void from class brave.propagation.InternalMutableTraceContextTest to public parseSpanId_whenFineDisabledNoLogs() : void from class brave.propagation.TraceContextTest	From	To
Move Method package parseBadParentId(parentIdString String) : void from class brave.propagation.InternalMutableTraceContextTest to package parseBadParentId(parentIdString String) : void from class brave.propagation.TraceContextTest	From	To
Move Method package parseBadSpanId(spanIdString String) : void from class brave.propagation.InternalMutableTraceContextTest to package parseBadSpanId(spanIdString String) : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseParentId_short64bit() : void from class brave.propagation.InternalMutableTraceContextTest to public parseParentId_short64bit() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseTraceId_128bit() : void from class brave.propagation.InternalMutableTraceContextTest to public parseTraceId_128bit() : void from class brave.propagation.TraceIdContextTest	From	To
Move Method package parseGoodParentId(parentIdString String) : MutableTraceContext from class brave.propagation.InternalMutableTraceContextTest to package parseGoodParentId(parentIdString String) : TestBuilder from class brave.propagation.TraceContextTest	From	To
Move Method package parseGoodTraceID(traceIdString String) : MutableTraceContext from class brave.propagation.InternalMutableTraceContextTest to package parseGoodTraceID(traceIdString String) : TestBuilder from class brave.propagation.TraceIdContextTest	From	To
Move Method public parseParentId_null_is_ok() : void from class brave.propagation.InternalMutableTraceContextTest to public parseParentId_null_is_ok() : void from class brave.propagation.TraceContextTest	From	To
Move Method public ensureImmutable_doesntCopyUnmodifiableList() : void from class brave.propagation.InternalMutableTraceContextTest to public ensureImmutable_doesntCopyUnmodifiableList() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseParentId_whenFineDisabledNoLogs() : void from class brave.propagation.InternalMutableTraceContextTest to public parseParentId_whenFineDisabledNoLogs() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseSpanId_malformedReturnsFalse() : void from class brave.propagation.InternalMutableTraceContextTest to public parseSpanId_malformedReturnsFalse() : void from class brave.propagation.TraceContextTest	From	To
Move Method public ensureImmutable_doesntCopySingletonList() : void from class brave.propagation.InternalMutableTraceContextTest to public ensureImmutable_doesntCopySingletonList() : void from class brave.propagation.TraceContextTest	From	To
Inline Method	1
Inline Method package parseBuilderFromBytes(bytes byte[]) : TraceContext.Builder inlined to public parseBytes(bytes byte[]) : TraceContext in class brave.grpc.TraceContextBinaryMarshaller	From	To
Change Return Type	6
Change Return Type MutableTraceContext to TestBuilder in method package parseGoodTraceID(traceIdString String) : TestBuilder in class brave.propagation.TraceIdContextTest	From	To
Change Return Type MutableTraceContext to TestBuilder in method package parseGoodSpanId(spanIdString String) : TestBuilder in class brave.propagation.TraceContextTest	From	To
Change Return Type void to InternalBuilder in method package sampled(sampled Boolean) : InternalBuilder in class brave.propagation.TraceIdContext.InternalBuilder	From	To
Change Return Type void to InternalBuilder in method package sampled(sampled boolean) : InternalBuilder in class brave.propagation.TraceIdContext.InternalBuilder	From	To
Change Return Type void to InternalBuilder in method package debug(debug boolean) : InternalBuilder in class brave.propagation.TraceIdContext.InternalBuilder	From	To
Change Return Type MutableTraceContext to TestBuilder in method package parseGoodParentId(parentIdString String) : TestBuilder in class brave.propagation.TraceContextTest	From	To
Push Down Attribute	2
Push Down Attribute package parentId : long from class brave.propagation.InternalMutableTraceContext to package parentId : long from class brave.propagation.TraceContext.InternalBuilder	From	To
Push Down Attribute package spanId : long from class brave.propagation.InternalMutableTraceContext to package spanId : long from class brave.propagation.TraceContext.InternalBuilder	From	To
Move Attribute	4
Move Attribute package logger : Logger from class brave.propagation.InternalMutableTraceContextTest to package logger : Logger from class brave.propagation.TraceContextTest	From	To
Move Attribute package messages : List<String> from class brave.propagation.InternalMutableTraceContextTest to package messages : List<String> from class brave.propagation.TraceContextTest	From	To
Move Attribute package logger : Logger from class brave.propagation.InternalMutableTraceContextTest to package logger : Logger from class brave.propagation.TraceIdContextTest	From	To
Move Attribute package messages : List<String> from class brave.propagation.InternalMutableTraceContextTest to package messages : List<String> from class brave.propagation.TraceIdContextTest	From	To
Move And Rename Class	2
Move And Rename Class brave.propagation.InternalMutableTraceContext moved and renamed to brave.propagation.TraceIdContext.InternalBuilder	From	To
Move And Rename Class brave.propagation.InternalMutableTraceContextTest.MutableTraceContext moved and renamed to brave.propagation.TraceContextTest.TestBuilder	From	To
Extract Superclass	1
Extract Superclass brave.propagation.TraceContext.InternalBuilder from classes [brave.propagation.TraceContext.Builder]	From	To
Change Variable Type	2
Change Variable Type extractedTrace : TraceContext.Builder to extractedTrace : TraceContext in method public extract(carrier C) : TraceContextOrSamplingFlags in class brave.grpc.GrpcPropagation.GrpcExtractor	From	To
Change Variable Type tags : Tags to tags : GrpcPropagation.Tags in method public interceptCall(call ServerCall<ReqT,RespT>, headers Metadata, next ServerCallHandler<ReqT,RespT>) : ServerCall.Listener<ReqT> in class brave.grpc.TracingServerInterceptor	From	To

3ab3725e2a9cd012837986010fc17364c5ade1a1

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: