brave 44bc290657e916594edf301daa6c30ce08a2e1c9

44bc290657e916594edf301daa6c30ce08a2e1c9

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 19

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	8
Rename Method public nullSampled() : void renamed to public builder_nullSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public debugImpliesSampled() : void renamed to public builder_debugImpliesSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public notSampled() : void renamed to public builder_notSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public sampled() : void renamed to public create_sampledTrueDebugFalse() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method package debug(debug boolean) : InternalBuilder renamed to package _debug(debug boolean) : void in class brave.propagation.InternalMutableTraceContext	From	To
Rename Method public defaultIsEmpty() : void renamed to public builder_defaultIsEmpty() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method package sampled(sampled Boolean) : InternalBuilder renamed to package _sampled(sampled Boolean) : void in class brave.propagation.InternalMutableTraceContext	From	To
Rename Method package sampled(sampled boolean) : InternalBuilder renamed to package _sampled(sampled boolean) : void in class brave.propagation.InternalMutableTraceContext	From	To
Move Method	30
Move Method public parseTraceId_128bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_128bit() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseTraceId_64bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_64bit() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseSpanId() : void from class brave.propagation.TraceContextTest to public parseSpanId() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method package parseGoodTraceID(traceIdString String) : TestBuilder from class brave.propagation.TraceIdContextTest to package parseGoodTraceID(traceIdString String) : MutableTraceContext from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseParentId() : void from class brave.propagation.TraceContextTest to public parseParentId() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseTraceId_whenFineDisabledNoLogs() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_whenFineDisabledNoLogs() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public ensureImmutable_doesntCopyImmutableList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_doesntCopyImmutableList() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method package parseBadTraceId(traceIdString String) : void from class brave.propagation.TraceIdContextTest to package parseBadTraceId(traceIdString String) : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseSpanId_short64bit() : void from class brave.propagation.TraceContextTest to public parseSpanId_short64bit() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public ensureImmutable_returnsImmutableEmptyList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_returnsImmutableEmptyList() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method package parseGoodSpanId(spanIdString String) : TestBuilder from class brave.propagation.TraceContextTest to package parseGoodSpanId(spanIdString String) : MutableTraceContext from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseSpanId_malformedReturnsFalse() : void from class brave.propagation.TraceContextTest to public parseSpanId_malformedReturnsFalse() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseTraceId_short64bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_short64bit() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseParentId_short64bit() : void from class brave.propagation.TraceContextTest to public parseParentId_short64bit() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public ensureImmutable_doesntCopySingletonList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_doesntCopySingletonList() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseParentId_whenFineDisabledNoLogs() : void from class brave.propagation.TraceContextTest to public parseParentId_whenFineDisabledNoLogs() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public ensureImmutable_returnsEmptyList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_returnsEmptyList() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method package parseBadSpanId(spanIdString String) : void from class brave.propagation.TraceContextTest to package parseBadSpanId(spanIdString String) : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseSpanId_whenFineDisabledNoLogs() : void from class brave.propagation.TraceContextTest to public parseSpanId_whenFineDisabledNoLogs() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseTraceId_malformedReturnsFalse() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_malformedReturnsFalse() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public ensureImmutable_doesntCopyUnmodifiableList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_doesntCopyUnmodifiableList() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseParentId_null_is_ok() : void from class brave.propagation.TraceContextTest to public parseParentId_null_is_ok() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public debugImpliesSampled() : void from class brave.propagation.TraceIdContextTest to public debugImpliesSampled() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method package parseBadParentId(parentIdString String) : void from class brave.propagation.TraceContextTest to package parseBadParentId(parentIdString String) : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method package parseGoodParentId(parentIdString String) : TestBuilder from class brave.propagation.TraceContextTest to package parseGoodParentId(parentIdString String) : MutableTraceContext from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseTraceId_short128bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_short128bit() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method package logger() : Logger from class brave.propagation.TraceContext.InternalBuilder to package logger() : Logger from class brave.propagation.TraceContext.Builder	From	To
Move Method public ensureImmutable_convertsToSingletonList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_convertsToSingletonList() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public canUsePrimitiveOverloads() : void from class brave.propagation.TraceIdContextTest to public canUsePrimitiveOverloads() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Method public parseParentId_malformedReturnsFalse() : void from class brave.propagation.TraceContextTest to public parseParentId_malformedReturnsFalse() : void from class brave.propagation.InternalMutableTraceContextTest	From	To
Change Return Type	6
Change Return Type TestBuilder to MutableTraceContext in method package parseGoodParentId(parentIdString String) : MutableTraceContext in class brave.propagation.InternalMutableTraceContextTest	From	To
Change Return Type TestBuilder to MutableTraceContext in method package parseGoodTraceID(traceIdString String) : MutableTraceContext in class brave.propagation.InternalMutableTraceContextTest	From	To
Change Return Type TestBuilder to MutableTraceContext in method package parseGoodSpanId(spanIdString String) : MutableTraceContext in class brave.propagation.InternalMutableTraceContextTest	From	To
Change Return Type InternalBuilder to void in method package _sampled(sampled Boolean) : void in class brave.propagation.InternalMutableTraceContext	From	To
Change Return Type InternalBuilder to void in method package _sampled(sampled boolean) : void in class brave.propagation.InternalMutableTraceContext	From	To
Change Return Type InternalBuilder to void in method package _debug(debug boolean) : void in class brave.propagation.InternalMutableTraceContext	From	To
Move Attribute	4
Move Attribute package logger : Logger from class brave.propagation.TraceContextTest to package logger : Logger from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Attribute package messages : List<String> from class brave.propagation.TraceIdContextTest to package messages : List<String> from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Attribute package logger : Logger from class brave.propagation.TraceIdContextTest to package logger : Logger from class brave.propagation.InternalMutableTraceContextTest	From	To
Move Attribute package messages : List<String> from class brave.propagation.TraceContextTest to package messages : List<String> from class brave.propagation.InternalMutableTraceContextTest	From	To
Extract Class	2
Extract Class brave.propagation.InternalMutableTraceContextTest from class brave.propagation.TraceIdContextTest	From	To
Extract Class brave.propagation.InternalMutableTraceContextTest from class brave.propagation.TraceContextTest	From	To
Move And Rename Class	2
Move And Rename Class brave.propagation.TraceContextTest.TestBuilder moved and renamed to brave.propagation.InternalMutableTraceContextTest.MutableTraceContext	From	To
Move And Rename Class brave.propagation.TraceIdContext.InternalBuilder moved and renamed to brave.propagation.InternalMutableTraceContext	From	To
Change Variable Type	2
Change Variable Type tags : GrpcPropagation.Tags to tags : Tags in method public interceptCall(call ServerCall<ReqT,RespT>, headers Metadata, next ServerCallHandler<ReqT,RespT>) : ServerCall.Listener<ReqT> in class brave.grpc.TracingServerInterceptor	From	To
Change Variable Type extractedTrace : TraceContext to extractedTrace : TraceContext.Builder in method public extract(carrier C) : TraceContextOrSamplingFlags in class brave.grpc.GrpcPropagation.GrpcExtractor	From	To
Extract Method	1
Extract Method package parseBuilderFromBytes(bytes byte[]) : TraceContext.Builder extracted from public parseBytes(bytes byte[]) : TraceContext in class brave.grpc.TraceContextBinaryMarshaller	From	To

44bc290657e916594edf301daa6c30ce08a2e1c9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: