74cc5af061325bf69203e3392596b1ee68d1e2f2
Files Diff
- Added: 2
- Removed: 2
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method package postSpans(json byte[]) : void renamed to protected sendSpans(json byte[]) : void in class com.github.kristofa.brave.http.HttpSpanCollector | From | To | |
| Pull Up Method | 6 | ||
| Pull Up Method public flush() : void from class com.github.kristofa.brave.http.HttpSpanCollector to public flush() : void from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Pull Up Method public collect(span Span) : void from class com.github.kristofa.brave.kafka.KafkaSpanCollector to public collect(span Span) : void from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Pull Up Method public addDefaultAnnotation(key String, value String) : void from class com.github.kristofa.brave.http.HttpSpanCollector to public addDefaultAnnotation(key String, value String) : void from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Pull Up Method public collect(span Span) : void from class com.github.kristofa.brave.http.HttpSpanCollector to public collect(span Span) : void from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Pull Up Method public addDefaultAnnotation(key String, value String) : void from class com.github.kristofa.brave.kafka.KafkaSpanCollector to public addDefaultAnnotation(key String, value String) : void from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Pull Up Method public close() : void from class com.github.kristofa.brave.http.HttpSpanCollector to public close() : void from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private defaultPropertiesWith(bootstrapServers String) : Properties from class com.github.kristofa.brave.kafka.KafkaSpanCollector to public builder(bootstrapServers String) : Builder from class com.github.kristofa.brave.kafka.KafkaSpanCollector.Config | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type span : com.twitter.zipkin.gen.Span to span : Span in method public collect(span Span) : void in class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Properties to Builder in method public builder(bootstrapServers String) : Builder in class com.github.kristofa.brave.kafka.KafkaSpanCollector.Config | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute private pending : BlockingQueue<Span> from class com.github.kristofa.brave.http.HttpSpanCollector to private pending : BlockingQueue<Span> from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Pull Up Attribute private flusher : Flusher from class com.github.kristofa.brave.http.HttpSpanCollector to private flusher : Flusher from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Pull Up Attribute private metrics : SpanCollectorMetricsHandler from class com.github.kristofa.brave.http.HttpSpanCollector to private metrics : SpanCollectorMetricsHandler from class com.github.kristofa.brave.AbstractSpanCollector | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.github.kristofa.brave.kafka.ITKafkaSpanCollector.EventsHandler moved and renamed to com.github.kristofa.brave.kafka.KafkaSpanCollectorTest.TestMetricsHander | From | To | |
| Move Class | 1 | ||
| Move Class com.github.kristofa.brave.http.HttpSpanCollector.Flusher moved to com.github.kristofa.brave.AbstractSpanCollector.Flusher | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.github.kristofa.brave.AbstractSpanCollector from classes [com.github.kristofa.brave.http.HttpSpanCollector, com.github.kristofa.brave.kafka.KafkaSpanCollector] | From | To |