86bc99a1bcd6afebcb117c6893e9669ecd5b45b2
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 22
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method package getNewSpanParent() : Span renamed to package maybeParent() : Span in class com.github.kristofa.brave.LocalTracer | From | To | |
Move And Rename Method | 1 | ||
Move And Rename Method package toBrave(input zipkin.Span) : Span from class com.github.kristofa.brave.SpanCollectorReporterAdapter to public fromZipkin(in zipkin.Span) : Span from class com.github.kristofa.brave.internal.DefaultSpanCodec | From | To | |
Move Method | 3 | ||
Move Method private from(host Endpoint) : zipkin.Endpoint from class com.twitter.zipkin.gen.Span to private from(host Endpoint) : zipkin.Endpoint from class com.github.kristofa.brave.internal.DefaultSpanCodec | From | To | |
Move Method public toSpan_128() : void from class com.github.kristofa.brave.SpanIdTest to public toSpan_128() : void from class com.twitter.zipkin.gen.SpanTest | From | To | |
Move Method public toZipkin() : zipkin.Span from class com.twitter.zipkin.gen.Span to public toZipkin(span Span) : zipkin.Span from class com.github.kristofa.brave.internal.DefaultSpanCodec | From | To | |
Rename Variable | 9 | ||
Rename Variable newSpanId : SpanId to newContext : SpanId in method public startNewSpan_rootSpanWith64bitTraceId() : void in class com.github.kristofa.brave.LocalTracerTest | From | To | |
Rename Variable id : SpanId to context : SpanId in method public setStateCurrentTrace(traceId long, spanId long, parentSpanId Long, name String) : void in class com.github.kristofa.brave.ServerTracer | From | To | |
Rename Variable newSpanId : SpanId to newContext : SpanId in method public startNewSpan_rootSpanWith128bitTraceId() : void in class com.github.kristofa.brave.LocalTracerTest | From | To | |
Rename Variable expectedSpanId : SpanId to expectedContext : SpanId in method public startNewSpan() : void in class com.github.kristofa.brave.LocalTracerTest | From | To | |
Rename Variable spanId : SpanId to nextContext : SpanId in method public setStateUnknown(spanName String) : void in class com.github.kristofa.brave.ServerTracer | From | To | |
Rename Variable newSpanId : SpanId to newContext : SpanId in method public startNewSpan_whenParentHas128bitTraceId() : void in class com.github.kristofa.brave.LocalTracerTest | From | To | |
Rename Variable spanId : SpanId to context : SpanId in method public handle(adapter ServerRequestAdapter) : void in class com.github.kristofa.brave.ServerRequestInterceptor | From | To | |
Rename Variable spanId : SpanId to context : SpanId in method public handle(adapter ClientRequestAdapter) : void in class com.github.kristofa.brave.ClientRequestInterceptor | From | To | |
Rename Variable newSpanId : SpanId to newContext : SpanId in method public testStartNewSpanSampleTruePartOfExistingSpan() : void in class com.github.kristofa.brave.ClientTracerTest | From | To | |
Replace Variable With Attribute | 2 | ||
Replace Variable With Attribute finished : Span to span : Span in method public finishSpan_lessThanMicrosRoundUp() : void in class com.github.kristofa.brave.LocalTracerTest | From | To | |
Replace Variable With Attribute finished : Span to span : Span in method public finishSpan() : void in class com.github.kristofa.brave.LocalTracerTest | From | To | |
Rename Attribute | 3 | ||
Rename Attribute mockEndpoint : Endpoint to endpoint : Endpoint in class com.github.kristofa.brave.ServerTracerTest | From | To | |
Rename Attribute PARENT_SPAN_ID : SpanId to PARENT_CONTEXT : SpanId in class com.github.kristofa.brave.LocalTracerTest | From | To | |
Rename Attribute SPAN_ID : SpanId to CONTEXT : SpanId in class com.github.kristofa.brave.ServerTracerTest | From | To | |
Inline Variable | 5 | ||
Inline Variable finished : Span in method public setClientReceived_usesPreciseDuration() : void from class com.github.kristofa.brave.ClientTracerTest | From | To | |
Inline Variable finished : Span in method public finishSpan_lessThanMicrosRoundUp() : void from class com.github.kristofa.brave.LocalTracerTest | From | To | |
Inline Variable finished : Span in method public finishSpan() : void from class com.github.kristofa.brave.LocalTracerTest | From | To | |
Inline Variable clientRecv : Span in method public testSetClientReceived() : void from class com.github.kristofa.brave.ClientTracerTest | From | To | |
Inline Variable finished : Span in method public setClientReceived_lessThanMicrosRoundUp() : void from class com.github.kristofa.brave.ClientTracerTest | From | To | |
Extract Method | 1 | ||
Extract Method public fromZipkin(in zipkin.Span) : Span extracted from public readSpan(bytes byte[]) : Span in class com.github.kristofa.brave.internal.DefaultSpanCodec | From | To | |
Extract And Move Method | 2 | ||
Extract And Move Method package nextContext(maybeParent Span) : SpanId extracted from public setStateUnknown(spanName String) : void in class com.github.kristofa.brave.ServerTracer & moved to class com.github.kristofa.brave.AnnotationSubmitter | From | To | |
Extract And Move Method package random(random Random) : Builder extracted from public setup() : void in class com.github.kristofa.brave.ServerTracerTest & moved to class com.github.kristofa.brave.Brave.Builder | From | To | |
Rename Parameter | 2 | ||
Rename Parameter input : zipkin.Span to in : zipkin.Span in method public fromZipkin(in zipkin.Span) : Span in class com.github.kristofa.brave.internal.DefaultSpanCodec | From | To | |
Rename Parameter spanId : SpanId to context : SpanId in method public setStateCurrentTrace(context SpanId, spanName String) : void in class com.github.kristofa.brave.ServerTracer | From | To |