brave 9060ecb17f608bbe00d05272d3dae281473dd9e1

9060ecb17f608bbe00d05272d3dae281473dd9e1

Files Diff

Added: 2
Removed: 1
Renamed: 0
Modified: 15

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	4
Pull Up Method package tracingBuilder(sampler Sampler) : Tracing.Builder from class brave.http.ITHttpServer to package tracingBuilder(sampler Sampler) : Tracing.Builder from class brave.http.ITHttp	From	To
Pull Up Method package collectedSpans() : List<Span> from class brave.http.ITHttpClient to package collectedSpans() : List<Span> from class brave.http.ITHttp	From	To
Pull Up Method package tracingBuilder(sampler Sampler) : Tracing.Builder from class brave.http.ITHttpClient to package tracingBuilder(sampler Sampler) : Tracing.Builder from class brave.http.ITHttp	From	To
Pull Up Method protected collectedSpans() : List<Span> from class brave.http.ITHttpServer to package collectedSpans() : List<Span> from class brave.http.ITHttp	From	To
Change Parameter Type	3
Change Parameter Type handler : HttpServletHandler to handler : HttpServerHandler<HttpServletRequest,HttpServletResponse> in method package abstract handleAsync(handler HttpServerHandler<HttpServletRequest,HttpServletResponse>, request HttpServletRequest, span Span) : void in class brave.servlet.ServletRuntime	From	To
Change Parameter Type handler : HttpServletHandler to handler : HttpServerHandler<HttpServletRequest,HttpServletResponse> in method package handleAsync(handler HttpServerHandler<HttpServletRequest,HttpServletResponse>, request HttpServletRequest, span Span) : void in class brave.servlet.ServletRuntime.Servlet3	From	To
Change Parameter Type handler : HttpServletHandler to handler : HttpServerHandler<HttpServletRequest,HttpServletResponse> in method package handleAsync(handler HttpServerHandler<HttpServletRequest,HttpServletResponse>, request HttpServletRequest, span Span) : void in class brave.servlet.ServletRuntime.Servlet25	From	To
Pull Up Attribute	11
Pull Up Attribute package storage : InMemoryStorage from class brave.http.ITHttpServer to package storage : InMemoryStorage from class brave.http.ITHttp	From	To
Pull Up Attribute protected httpTracing : HttpTracing from class brave.http.ITHttpServer to protected httpTracing : HttpTracing from class brave.http.ITHttp	From	To
Pull Up Attribute package local : Endpoint from class brave.http.ITHttpServer to package local : Endpoint from class brave.http.ITHttp	From	To
Pull Up Attribute public thrown : ExpectedException from class brave.http.ITHttpClient to public thrown : ExpectedException from class brave.http.ITHttp	From	To
Pull Up Attribute protected currentTraceContext : CurrentTraceContext from class brave.http.ITHttpClient to protected currentTraceContext : CurrentTraceContext from class brave.http.ITHttp	From	To
Pull Up Attribute public server : MockWebServer from class brave.http.ITHttpClient to public server : MockWebServer from class brave.http.ITHttp	From	To
Pull Up Attribute package storage : InMemoryStorage from class brave.http.ITHttpClient to package storage : InMemoryStorage from class brave.http.ITHttp	From	To
Pull Up Attribute package local : Endpoint from class brave.http.ITHttpClient to package local : Endpoint from class brave.http.ITHttp	From	To
Pull Up Attribute public thrown : ExpectedException from class brave.http.ITHttpServer to public thrown : ExpectedException from class brave.http.ITHttp	From	To
Pull Up Attribute protected httpTracing : HttpTracing from class brave.http.ITHttpClient to protected httpTracing : HttpTracing from class brave.http.ITHttp	From	To
Pull Up Attribute protected currentTraceContext : CurrentTraceContext from class brave.http.ITHttpServer to protected currentTraceContext : CurrentTraceContext from class brave.http.ITHttp	From	To
Change Return Type	2
Change Return Type Req to void in method public handleReceive(request Req, span Span) : void in class brave.http.HttpServerHandler	From	To
Change Return Type Req to void in method public handleSend(request Req, span Span) : void in class brave.http.HttpClientHandler	From	To
Move Class	1
Move Class brave.servlet.HttpServletHandler.HttpServletAdapter moved to brave.servlet.HttpServletAdapter	From	To
Extract Superclass	1
Extract Superclass brave.http.ITHttp from classes [brave.http.ITHttpClient, brave.http.ITHttpServer]	From	To
Extract Variable	3
Extract Variable span : Span in method public filter(request ClientRequestContext, response ClientResponseContext) : void from class brave.jaxrs2.TracingClientFilter	From	To
Extract Variable response : ClientHttpResponse in method public intercept(request HttpRequest, body byte[], execution ClientHttpRequestExecution) : ClientHttpResponse from class brave.spring.web.TracingClientHttpRequestInterceptor	From	To
Extract Variable response : Response in method public intercept(chain Chain) : Response from class brave.okhttp3.TracingCallFactory.TracingNetworkInterceptor	From	To
Change Attribute Type	3
Change Attribute Type handler : HttpServletHandler to handler : HttpServerHandler<HttpServletRequest,HttpServletResponse> in class brave.spring.webmvc.TracingHandlerInterceptor	From	To
Change Attribute Type handler : HttpServletHandler to handler : HttpServerHandler<HttpServletRequest,HttpServletResponse> in class brave.servlet.TracingFilter	From	To
Change Attribute Type handler : HttpServletHandler to handler : HttpServerHandler<HttpServletRequest,HttpServletResponse> in class brave.sparkjava.SparkTracing	From	To
Extract And Move Method	5
Extract And Move Method public create(adapter HttpAdapter<Req,Resp>, parser HttpClientParser) : HttpClientHandler extracted from package TracingClientFilter(httpTracing HttpTracing) in class brave.jaxrs2.TracingClientFilter & moved to class brave.http.HttpClientHandler	From	To
Extract And Move Method public create(adapter HttpAdapter<Req,Resp>, parser HttpClientParser) : HttpClientHandler extracted from package TracingHttpAsyncClientBuilder(httpTracing HttpTracing) in class brave.httpasyncclient.TracingHttpAsyncClientBuilder & moved to class brave.http.HttpClientHandler	From	To
Extract And Move Method public create(adapter HttpAdapter<Req,Resp>, parser HttpClientParser) : HttpClientHandler extracted from package TracingHttpClientBuilder(httpTracing HttpTracing) in class brave.httpclient.TracingHttpClientBuilder & moved to class brave.http.HttpClientHandler	From	To
Extract And Move Method public create(adapter HttpAdapter<Req,Resp>, parser HttpClientParser) : HttpClientHandler extracted from package TracingCallFactory(httpTracing HttpTracing, ok OkHttpClient) in class brave.okhttp3.TracingCallFactory & moved to class brave.http.HttpClientHandler	From	To
Extract And Move Method public create(adapter HttpAdapter<Req,Resp>, parser HttpClientParser) : HttpClientHandler extracted from package TracingClientHttpRequestInterceptor(httpTracing HttpTracing) in class brave.spring.web.TracingClientHttpRequestInterceptor & moved to class brave.http.HttpClientHandler	From	To
Rename Parameter	2
Rename Parameter handler : Object to o : Object in method public afterCompletion(request HttpServletRequest, response HttpServletResponse, o Object, ex Exception) : void in class brave.spring.webmvc.TracingHandlerInterceptor	From	To
Rename Parameter handler : Object to o : Object in method public preHandle(request HttpServletRequest, response HttpServletResponse, o Object) : boolean in class brave.spring.webmvc.TracingHandlerInterceptor	From	To

9060ecb17f608bbe00d05272d3dae281473dd9e1

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: