beac719e4718441bc17fbe9670a14721d92a135f
Files Diff
- Added: 7
- Removed: 6
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 2 | ||
| Merge Attribute [mockTraceFilter : TraceFilter, mockTraceFilter2 : TraceFilter] to mockTraceSampler : TraceSampler in class com.github.kristofa.brave.ClientTracerTest | From | To | |
| Merge Attribute [mockTraceFilter1 : TraceFilter, mockTraceFilter2 : TraceFilter] to mockTraceSampler : TraceSampler in class com.github.kristofa.brave.ServerTracerTest | From | To | |
| Rename Method | 3 | ||
| Rename Method public testFirstTraceFilterFalse() : void renamed to public testTraceSamplerFalse() : void in class com.github.kristofa.brave.ClientTracerTest | From | To | |
| Rename Method public testSetStateUnknownTraceFiltersTrue() : void renamed to public testSetStateUnknownTraceSamplerTrue() : void in class com.github.kristofa.brave.ServerTracerTest | From | To | |
| Rename Method public testSetStateUnknownTraceFiltersFalse() : void renamed to public testSetStateUnknownTraceSamplerFalse() : void in class com.github.kristofa.brave.ServerTracerTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable newSpanId : long to newTraceId : long in method public setStateUnknown(spanName String) : void in class com.github.kristofa.brave.ServerTracer | From | To | |
| Change Return Type | 1 | ||
| Change Return Type int to float in method private getSampleRate() : float in class com.github.kristofa.brave.sampler.ZooKeeperTraceSampler | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.github.kristofa.brave.tracefilter.ZooKeeperSamplingTraceFilter moved and renamed to com.github.kristofa.brave.sampler.ZooKeeperTraceSampler | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.github.kristofa.brave.TraceSampler from classes [com.github.kristofa.brave.sampler.ZooKeeperTraceSampler] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute mockTraceFilter : TraceFilter to mockTraceSampler : TraceSampler in class com.github.kristofa.brave.BraveTest | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type DEFAULT_SAMPLE_RATE : int to DEFAULT_SAMPLE_RATE : float in class com.github.kristofa.brave.sampler.ZooKeeperTraceSampler | From | To | |
| Change Attribute Type mockTraceFilter : TraceFilter to mockTraceSampler : TraceSampler in class com.github.kristofa.brave.BraveTest | From | To | |
| Extract And Move Method | 4 | ||
| Extract And Move Method public traceSampler(traceSampler TraceSampler) : Builder extracted from public setup() : void in class com.github.kristofa.brave.BraveTest & moved to class com.github.kristofa.brave.Brave.Builder | From | To | |
| Extract And Move Method public traceSampler(traceSampler TraceSampler) : Builder extracted from public setup() : void in class com.github.kristofa.brave.ServerTracerTest & moved to class com.github.kristofa.brave.Brave.Builder | From | To | |
| Extract And Move Method public traceSampler(traceSampler TraceSampler) : Builder extracted from public setup() : void in class com.github.kristofa.brave.ClientTracerTest & moved to class com.github.kristofa.brave.Brave.Builder | From | To | |
| Extract And Move Method public traceSampler(traceSampler TraceSampler) : Builder extracted from private Brave(builder Builder) in class com.github.kristofa.brave.Brave & moved to class com.github.kristofa.brave.Brave.Builder | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter filters : List<TraceFilter> to ignored : List<TraceFilter> in method public traceFilters(ignored List<TraceFilter>) : Builder in class com.github.kristofa.brave.Brave.Builder | From | To |