f34a05f47fc5cb82670112d6a75e5b888f51eb04
Files Diff
- Added: 13
- Removed: 10
- Renamed: 0
- Modified: 28
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public unloadable_afterBasicUsage() : void from class brave.internal.recorder.SpanReporterClassLoaderTest to public unloadable_afterErrorReporting() : void from class brave.internal.recorder.PendingSpansClassLoaderTest | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass brave.internal.firehose.FirehoseHandlers.NoopAwareFirehose from class brave.internal.recorder.SpanReporter | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type spanReporter : SpanReporter to firehoseHandler : FirehoseHandler in method package Tracer(clock Clock, propagationFactory Propagation.Factory, firehoseHandler FirehoseHandler, pendingSpans PendingSpans, sampler Sampler, currentTraceContext CurrentTraceContext, traceId128Bit boolean, supportsJoin boolean, alwaysSampleLocal boolean, noop AtomicBoolean) in class brave.Tracer | From | To | |
| Move Method | 2 | ||
| Move Method public unloadable_afterErrorReporting() : void from class brave.internal.recorder.SpanReporterClassLoaderTest to public unloadable_afterErrorReporting() : void from class brave.internal.recorder.PendingSpansClassLoaderTest | From | To | |
| Move Method public sampled(sampled boolean, flags int) : int from class brave.internal.TraceContexts to public sampled(sampled boolean, flags int) : int from class brave.internal.InternalPropagation | From | To | |
| Move Attribute | 8 | ||
| Move Attribute package errorParser : ErrorParser from class brave.RealScopedSpan to package errorParser : ErrorParser from class brave.internal.firehose.MutableSpanConverter | From | To | |
| Move Attribute public FLAG_DEBUG : int from class brave.internal.TraceContexts to public FLAG_DEBUG : int from class brave.internal.InternalPropagation | From | To | |
| Move Attribute public FLAG_SAMPLED : int from class brave.internal.TraceContexts to public FLAG_SAMPLED : int from class brave.internal.InternalPropagation | From | To | |
| Move Attribute public FLAG_SAMPLED_SET : int from class brave.internal.TraceContexts to public FLAG_SAMPLED_SET : int from class brave.internal.InternalPropagation | From | To | |
| Move Attribute package errorParser : ErrorParser from class brave.RealSpan to package errorParser : ErrorParser from class brave.internal.firehose.MutableSpanConverter | From | To | |
| Move Attribute package noop : AtomicBoolean from class brave.internal.recorder.SpanReporter to package noop : AtomicBoolean from class brave.Tracing.Default | From | To | |
| Move Attribute package errorParser : ErrorParser from class brave.Tracer to package errorParser : ErrorParser from class brave.internal.firehose.MutableSpanConverter | From | To | |
| Move Attribute public FLAG_SHARED : int from class brave.internal.TraceContexts to public FLAG_SHARED : int from class brave.internal.InternalPropagation | From | To | |
| Push Down Attribute | 2 | ||
| Push Down Attribute package noop : AtomicBoolean from class brave.Tracing to package noop : AtomicBoolean from class brave.Tracing.Default | From | To | |
| Push Down Attribute package noop : AtomicBoolean from class brave.internal.recorder.SpanReporter to package noop : AtomicBoolean from class brave.internal.firehose.FirehoseHandlers.NoopAwareFirehose | From | To | |
| Rename Class | 1 | ||
| Rename Class brave.internal.TraceContextsTest renamed to brave.internal.InternalPropagationTest | From | To | |
| Move And Rename Class | 2 | ||
| Move And Rename Class brave.internal.recorder.SpanReporter moved and renamed to brave.firehose.FirehoseHandler | From | To | |
| Move And Rename Class brave.internal.recorder.MutableSpanConverter moved and renamed to brave.internal.firehose.MutableSpanConverter.Consumer | From | To | |
| Move Class | 5 | ||
| Move Class brave.internal.recorder.MutableSpanConverterTest moved to brave.internal.firehose.MutableSpanConverterTest | From | To | |
| Move Class brave.internal.recorder.MutableSpanBenchmarks moved to brave.firehose.MutableSpanBenchmarks | From | To | |
| Move Class brave.internal.recorder.SpanReporterClassLoaderTest.ErrorReporting moved to brave.internal.recorder.PendingSpansClassLoaderTest.ErrorReporting | From | To | |
| Move Class brave.internal.recorder.MutableSpanConverterBenchmarks moved to brave.internal.firehose.MutableSpanConverterBenchmarks | From | To | |
| Move Class brave.internal.recorder.MutableSpan moved to brave.firehose.MutableSpan | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type reporter : SpanReporter to firehoseHandler : FirehoseHandler in method package Default(builder Builder) in class brave.Tracing.Default | From | To | |
| Extract Variable | 1 | ||
| Extract Variable zipkinFirehose : FirehoseHandler in method package Default(builder Builder) from class brave.Tracing.Default | From | To | |
| Push Down Method | 3 | ||
| Push Down Method public toString() : String from class brave.internal.recorder.SpanReporter to public toString() : String from class brave.internal.firehose.FirehoseHandlers.NoopAwareFirehose | From | To | |
| Push Down Method public setNoop(noop boolean) : void from class brave.Tracing to public setNoop(noop boolean) : void from class brave.Tracing.Default | From | To | |
| Push Down Method public isNoop() : boolean from class brave.Tracing to public isNoop() : boolean from class brave.Tracing.Default | From | To | |
| Rename Variable | 3 | ||
| Rename Variable reporter : SpanReporter to firehoseHandler : FirehoseHandler in method package Default(builder Builder) in class brave.Tracing.Default | From | To | |
| Rename Variable traceContext : TraceContext to context : TraceContext in method public sampled(sampled Boolean) : TraceContextOrSamplingFlags in class brave.propagation.TraceContextOrSamplingFlags | From | To | |
| Rename Variable traceContext : TraceContext to context : TraceContext in method public sampled(sampled boolean) : TraceContextOrSamplingFlags in class brave.propagation.TraceContextOrSamplingFlags | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute map : PendingSpans to pendingSpans : PendingSpans in class brave.internal.recorder.PendingSpansTest | From | To | |
| Rename Attribute reporter : Reporter<zipkin2.Span> to spanReporter : Reporter<zipkin2.Span> in class brave.Tracing.Builder | From | To | |
| Rename Attribute spanReporter : SpanReporter to firehoseHandler : FirehoseHandler in class brave.Tracer | From | To | |
| Rename Attribute reporter : Reporter<zipkin2.Span> to zipkinHandler : FirehoseHandler in class brave.internal.recorder.PendingSpans | From | To | |
| Change Package | 2 | ||
| Change Package brave.internal.recorder to brave.firehose | From | To | |
| Change Package brave.internal.recorder to brave.internal.firehose | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type spanReporter : SpanReporter to firehoseHandler : FirehoseHandler in class brave.Tracer | From | To | |
| Change Attribute Type reporter : Reporter<zipkin2.Span> to zipkinHandler : FirehoseHandler in class brave.internal.recorder.PendingSpans | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter spanReporter : SpanReporter to firehoseHandler : FirehoseHandler in method package Tracer(clock Clock, propagationFactory Propagation.Factory, firehoseHandler FirehoseHandler, pendingSpans PendingSpans, sampler Sampler, currentTraceContext CurrentTraceContext, traceId128Bit boolean, supportsJoin boolean, alwaysSampleLocal boolean, noop AtomicBoolean) in class brave.Tracer | From | To | |
| Rename Parameter extra : List<Object> to immutableExtra : List<Object> in method protected contextWithExtra(context TraceContext, immutableExtra List<Object>) : TraceContext in class brave.internal.PropagationFieldsFactory | From | To | |
| Rename Parameter reporter : Reporter<zipkin2.Span> to spanReporter : Reporter<zipkin2.Span> in method public spanReporter(spanReporter Reporter<zipkin2.Span>) : Builder in class brave.Tracing.Builder | From | To |