brave f97bd6d0f9e01312a1a6c7a907cc05a658d0fa2e

f97bd6d0f9e01312a1a6c7a907cc05a658d0fa2e

Files Diff

Added: 7
Removed: 2
Renamed: 0
Modified: 37

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Merge Attribute	1
Merge Attribute [FIELD1 : String, FIELD2 : String] to factory : PropagationFieldsFactory in class brave.internal.PropagationFieldsFactoryTest	From	To
Change Parameter Type	1
Change Parameter Type builder : Builder<?> to builder : Builder in method protected CurrentTraceContext(builder Builder) in class brave.propagation.CurrentTraceContext	From	To
Move Method	17
Move Method public ensureImmutable_convertsToSingletonList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_convertsToSingletonList() : void from class brave.internal.ListsTest	From	To
Move Method public ensureImmutable_returnsEmptyList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_returnsEmptyList() : void from class brave.internal.ListsTest	From	To
Move Method public parseTraceId_short128bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_short128bit() : void from class brave.propagation.TraceContextTest	From	To
Move Method public ensureImmutable_doesntCopyImmutableList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_doesntCopyImmutableList() : void from class brave.internal.ListsTest	From	To
Move Method package parseSpanId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.TraceContext.InternalBuilder to package parseSpanId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.TraceContext.Builder	From	To
Move Method package parseBadTraceId(traceIdString String) : void from class brave.propagation.TraceIdContextTest to package parseBadTraceId(traceIdString String) : void from class brave.propagation.TraceContextTest	From	To
Move Method public ensureImmutable_doesntCopySingletonList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_doesntCopySingletonList() : void from class brave.internal.ListsTest	From	To
Move Method public parseTraceId_64bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_64bit() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseTraceId_128bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_128bit() : void from class brave.propagation.TraceContextTest	From	To
Move Method public parseTraceId_short64bit() : void from class brave.propagation.TraceIdContextTest to public parseTraceId_short64bit() : void from class brave.propagation.TraceContextTest	From	To
Move Method package parseGoodTraceID(traceIdString String) : TestBuilder from class brave.propagation.TraceIdContextTest to package parseGoodTraceID(traceIdString String) : TraceContext.Builder from class brave.propagation.TraceContextTest	From	To
Move Method package invalidIdLength(key Object, length int, max int) : boolean from class brave.propagation.TraceIdContext.InternalBuilder to package invalidIdLength(key Object, length int, max int) : boolean from class brave.propagation.TraceContext.Builder	From	To
Move Method package parseTraceId(traceIdString String, key Object) : boolean from class brave.propagation.TraceIdContext.InternalBuilder to package parseTraceId(traceIdString String, key Object) : boolean from class brave.propagation.TraceContext.Builder	From	To
Move Method public ensureImmutable_returnsImmutableEmptyList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_returnsImmutableEmptyList() : void from class brave.internal.ListsTest	From	To
Move Method package maybeLogNotLowerHex(key Object, notLowerHex String) : void from class brave.propagation.TraceIdContext.InternalBuilder to package maybeLogNotLowerHex(key Object, notLowerHex String) : void from class brave.propagation.TraceContext.Builder	From	To
Move Method public ensureImmutable_doesntCopyUnmodifiableList() : void from class brave.propagation.TraceContextTest to public ensureImmutable_doesntCopyUnmodifiableList() : void from class brave.internal.ListsTest	From	To
Move Method package parseParentId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.TraceContext.InternalBuilder to package parseParentId(getter Propagation.Getter<C,K>, carrier C, key K) : boolean from class brave.propagation.TraceContext.Builder	From	To
Move Attribute	11
Move Attribute package FLAG_SAMPLED : int from class brave.propagation.SamplingFlags to public FLAG_SAMPLED : int from class brave.internal.TraceContexts	From	To
Move Attribute package flags : int from class brave.propagation.TraceIdContext.InternalBuilder to package flags : int from class brave.propagation.TraceIdContext.Builder	From	To
Move Attribute package traceIdHigh : long from class brave.propagation.TraceIdContext.InternalBuilder to package traceIdHigh : long from class brave.propagation.TraceIdContext.Builder	From	To
Move Attribute package context : TraceContext from class brave.internal.recorder.PendingSpans.LookupKey to package context : TraceContext from class brave.internal.TraceContextsTest	From	To
Move Attribute package parentId : long from class brave.propagation.TraceContext.InternalBuilder to package parentId : long from class brave.propagation.TraceContext.Builder	From	To
Move Attribute package FLAG_SAMPLED_SET : int from class brave.propagation.SamplingFlags to public FLAG_SAMPLED_SET : int from class brave.internal.TraceContexts	From	To
Move Attribute private context : TraceContext from class brave.internal.PropagationFields to package context : TraceContext from class brave.internal.TraceContextsTest	From	To
Move Attribute package spanId : long from class brave.propagation.TraceContext.InternalBuilder to package spanId : long from class brave.propagation.TraceContext.Builder	From	To
Move Attribute package FLAG_SHARED : int from class brave.propagation.TraceContext to public FLAG_SHARED : int from class brave.internal.TraceContexts	From	To
Move Attribute package FLAG_DEBUG : int from class brave.propagation.SamplingFlags to public FLAG_DEBUG : int from class brave.internal.TraceContexts	From	To
Move Attribute package traceId : long from class brave.propagation.TraceIdContext.InternalBuilder to package traceId : long from class brave.propagation.TraceIdContext.Builder	From	To
Extract Class	2
Extract Class brave.internal.ListsTest from class brave.propagation.TraceContextTest	From	To
Extract Class brave.internal.TraceContexts from class brave.propagation.SamplingFlags	From	To
Rename Class	2
Rename Class brave.grpc.TraceContextBinaryMarshallerTest renamed to brave.grpc.TraceContextBinaryFormatTest	From	To
Rename Class brave.grpc.TraceContextBinaryMarshaller renamed to brave.grpc.TraceContextBinaryFormat	From	To
Extract Variable	1
Extract Variable joined : TraceContext in method public join_setsShared() : void from class brave.TracerTest	From	To
Change Variable Type	7
Change Variable Type builder : TestBuilder to builder : TraceContext.Builder in method public parseParentId() : void in class brave.propagation.TraceContextTest	From	To
Change Variable Type builder : TestBuilder to builder : TraceContext.Builder in method public parseParentId_short64bit() : void in class brave.propagation.TraceContextTest	From	To
Change Variable Type fields : PredefinedPropagationFields to fields : Extra in method public extract(carrier C) : TraceContextOrSamplingFlags in class brave.propagation.ExtraFieldPropagation.ExtraFieldExtractor	From	To
Change Variable Type builder : TestBuilder to builder : TraceContext.Builder in method public parseParentId_null_is_ok() : void in class brave.propagation.TraceContextTest	From	To
Change Variable Type builder : TestBuilder to builder : TraceContext.Builder in method public parseSpanId_short64bit() : void in class brave.propagation.TraceContextTest	From	To
Change Variable Type builder : TestBuilder to builder : TraceContext.Builder in method public parseSpanId() : void in class brave.propagation.TraceContextTest	From	To
Change Variable Type tags : GrpcPropagation.Tags to tags : Tags in method public interceptCall(call ServerCall<ReqT,RespT>, headers Metadata, next ServerCallHandler<ReqT,RespT>) : ServerCall.Listener<ReqT> in class brave.grpc.TracingServerInterceptor	From	To
Extract Method	1
Extract Method package _toSpan(decorated TraceContext) : Span extracted from public toSpan(context TraceContext) : Span in class brave.Tracer	From	To
Rename Method	9
Rename Method public canUsePrimitiveOverloads() : void renamed to public canUsePrimitiveOverloads_false() : void in class brave.propagation.TraceContextTest	From	To
Rename Method public debugImpliesSampled() : void renamed to public builder_debugImpliesSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public notSampled() : void renamed to public builder_notSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public sampled() : void renamed to public builder_nullSampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public debugImpliesSampled() : void renamed to public canUsePrimitiveOverloads_false() : void in class brave.propagation.TraceIdContextTest	From	To
Rename Method public defaultIsEmpty() : void renamed to public builder_defaultIsEmpty() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public nullSampled() : void renamed to public builder_sampled() : void in class brave.propagation.SamplingFlagsTest	From	To
Rename Method public parseSpanId_whenFineDisabledNoLogs() : void renamed to public parseTraceId_malformedReturnsFalse() : void in class brave.propagation.TraceContextTest	From	To
Rename Method public canUsePrimitiveOverloads() : void renamed to public canUsePrimitiveOverloads_true() : void in class brave.propagation.TraceIdContextTest	From	To
Rename Variable	3
Rename Variable extracted : TraceContextOrSamplingFlags to toTest : TraceContextOrSamplingFlags in method public contextWhenIdsAreSet() : void in class brave.propagation.TraceContextOrSamplingFlagsTest	From	To
Rename Variable extracted : TraceContextOrSamplingFlags to toTest : TraceContextOrSamplingFlags in method public flags() : void in class brave.propagation.TraceContextOrSamplingFlagsTest	From	To
Rename Variable extracted : TraceContextOrSamplingFlags to toTest : TraceContextOrSamplingFlags in method public contextWhenIdsAndSamplingAreSet() : void in class brave.propagation.TraceContextOrSamplingFlagsTest	From	To
Inline Method	4
Inline Method private sampled(flags int) : Boolean inlined to public sampled() : Boolean in class brave.propagation.SamplingFlags	From	To
Inline Method package getAll(extraList List<Object>) : Map<String,String> inlined to public getAll(context TraceContext) : Map<String,String> in class brave.propagation.ExtraFieldPropagation	From	To
Inline Method package getAll(extraList List<Object>) : Map<String,String> inlined to public getAll(extracted TraceContextOrSamplingFlags) : Map<String,String> in class brave.propagation.ExtraFieldPropagation	From	To
Inline Method package newContextBuilder(parent TraceContext, sampler Sampler) : TraceContext.Builder inlined to public nextSpan(extracted TraceContextOrSamplingFlags) : Span in class brave.Tracer	From	To
Change Return Type	4
Change Return Type TestBuilder to TraceContext.Builder in method package parseGoodTraceID(traceIdString String) : TraceContext.Builder in class brave.propagation.TraceContextTest	From	To
Change Return Type TestBuilder to TraceContext.Builder in method package parseGoodParentId(parentIdString String) : TraceContext.Builder in class brave.propagation.TraceContextTest	From	To
Change Return Type TestBuilder to TraceContext.Builder in method package parseGoodSpanId(spanIdString String) : TraceContext.Builder in class brave.propagation.TraceContextTest	From	To
Change Return Type B to Builder in method public addScopeDecorator(scopeDecorator ScopeDecorator) : Builder in class brave.propagation.CurrentTraceContext.Builder	From	To
Rename Attribute	1
Rename Attribute context : TraceIdContext to base : TraceIdContext in class brave.propagation.TraceIdContextTest	From	To
Change Attribute Type	1
Change Attribute Type GRPC_TRACE_BIN : Metadata.Key<TraceContext> to GRPC_TRACE_BIN : Metadata.Key<byte[]> in class brave.grpc.GrpcPropagation	From	To
Extract And Move Method	1
Extract And Move Method package debug(debug boolean, flags int) : int extracted from public debug(debug boolean) : Builder in class brave.propagation.SamplingFlags.Builder & moved to class brave.propagation.SamplingFlags	From	To

f97bd6d0f9e01312a1a6c7a907cc05a658d0fa2e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: