326e615d414da2832bcb8aa595b1eeafa42c10dc
Files Diff
- Added: 4
- Removed: 8
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 7 | ||
| Change Parameter Type servers : Collection<KubernetesServer> to servers : List<S> in method public chooseServer(servers List<S>) : S in class org.apache.camel.impl.remote.RoundRobinServiceCallLoadBalancer | From | To | |
| Change Parameter Type loadBalancer : ServiceCallLoadBalancer<ServiceCallServer> to loadBalancer : ServiceCallLoadBalancer<S> in method public setLoadBalancer(loadBalancer ServiceCallLoadBalancer<S>) : void in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Parameter Type serverListStrategy : ServiceCallServerListStrategy<ServiceCallServer> to serverListStrategy : ServiceCallServerListStrategy<S> in method public serverListStrategy(serverListStrategy ServiceCallServerListStrategy<S>) : DefaultServiceCallProcessor in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Parameter Type loadBalancer : ServiceCallLoadBalancer<ServiceCallServer> to loadBalancer : ServiceCallLoadBalancer<S> in method public loadBalancer(loadBalancer ServiceCallLoadBalancer<S>) : DefaultServiceCallProcessor in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Parameter Type serverListStrategy : ServiceCallServerListStrategy<ServiceCallServer> to serverListStrategy : ServiceCallServerListStrategy<S> in method public setServerListStrategy(serverListStrategy ServiceCallServerListStrategy<S>) : void in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Parameter Type definition : ProcessorDefinition<?> to definition : ServiceCallDefinition in method protected createProcessor(routeContext RouteContext, definition ServiceCallDefinition, cfg C) : Processor in class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Change Parameter Type definition : ProcessorDefinition<?> to definition : ServiceCallDefinition in method protected createProcessor(routeContext RouteContext, definition ServiceCallDefinition, cfg RibbonConfiguration) : Processor in class org.apache.camel.component.ribbon.processor.RibbonProcessorFactory | From | To | |
| Move Method | 4 | ||
| Move Method public getInitialListOfServers(name String) : Collection<ServiceCallServer> from class org.apache.camel.component.consul.processor.service.ConsulServiceCallServerListStrategy to public getInitialListOfServers(name String) : List<T> from class org.apache.camel.impl.remote.DefaultServiceCallServerListStrategy | From | To | |
| Move Method private configureProperties(routeContext RouteContext, config ServiceCallConfigurationDefinition, configRef ServiceCallConfigurationDefinition) : Map<String,String> from class org.apache.camel.component.ribbon.processor.RibbonProcessorFactory to protected configureProperties(routeContext RouteContext, config ServiceCallConfigurationDefinition, configRef ServiceCallConfigurationDefinition) : Map<String,String> from class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Move Method public chooseServer(servers Collection<KubernetesServer>) : KubernetesServer from class org.apache.camel.component.kubernetes.processor.RoundRobinBalancer to public chooseServer(servers List<S>) : S from class org.apache.camel.impl.remote.RoundRobinServiceCallLoadBalancer | From | To | |
| Move Method public createProcessor(routeContext RouteContext, definition ProcessorDefinition<?>) : Processor from class org.apache.camel.component.kubernetes.processor.KubernetesProcessorFactory to protected createProcessor(routeContext RouteContext, definition ServiceCallDefinition, cfg C) : Processor from class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private configuration : KubernetesConfiguration from class org.apache.camel.component.kubernetes.processor.KubernetesClientServiceCallProcessor to private configuration : KubernetesConfiguration from class org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategy | From | To | |
| Move Attribute private dnsDomain : String from class org.apache.camel.component.kubernetes.processor.KubernetesDnsServiceCallProcessor to private dnsDomain : String from class org.apache.camel.component.kubernetes.KubernetesConfiguration | From | To | |
| Move Attribute private dnsDomain : String from class org.apache.camel.component.kubernetes.processor.KubernetesDnsServiceCallExpression to private dnsDomain : String from class org.apache.camel.component.kubernetes.KubernetesConfiguration | From | To | |
| Inline Variable | 1 | ||
| Inline Variable sc : ServiceCallDefinition in method public createProcessor(routeContext RouteContext, definition ProcessorDefinition<?>) : Processor from class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Extract Method | 5 | ||
| Extract Method protected chooseServer(exchange Exchange, serviceName String) : S extracted from public process(exchange Exchange, callback AsyncCallback) : boolean in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Extract Method protected builtInLoadBalancer(conf C, name String) : Optional<ServiceCallLoadBalancer> extracted from protected configureLoadBalancer(routeContext RouteContext, config ServiceCallConfigurationDefinition) : ServiceCallLoadBalancer in class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Extract Method protected builtInLoadBalancer(conf C, name String) : Optional<ServiceCallLoadBalancer> extracted from protected configureLoadBalancer(routeContext RouteContext, sd ServiceCallDefinition) : ServiceCallLoadBalancer in class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Extract Method public getNamespace() : String extracted from public KubernetesServiceCallServerListStrategy(namespace String, portName String, client AutoAdaptableKubernetesClient) in class org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategy | From | To | |
| Extract Method protected createProcessor(routeContext RouteContext, definition ServiceCallDefinition, cfg C) : Processor extracted from public createProcessor(routeContext RouteContext, definition ProcessorDefinition<?>) : Processor in class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Push Down Method | 1 | ||
| Push Down Method public getUpdatedListOfServers(name String) : Collection<KubernetesServer> from class org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategy to public getUpdatedListOfServers(name String) : List<ServiceCallServer> from class org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategies.Client | From | To | |
| Pull Up Method | 4 | ||
| Pull Up Method protected doStart() : void from class org.apache.camel.component.consul.processor.service.ConsulServiceCallServerListStrategy to protected doStart() : void from class org.apache.camel.impl.remote.DefaultServiceCallServerListStrategy | From | To | |
| Pull Up Method protected doStop() : void from class org.apache.camel.component.consul.processor.service.ConsulServiceCallServerListStrategy to protected doStop() : void from class org.apache.camel.impl.remote.DefaultServiceCallServerListStrategy | From | To | |
| Pull Up Method protected doStop() : void from class org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategy to protected doStop() : void from class org.apache.camel.impl.remote.DefaultServiceCallServerListStrategy | From | To | |
| Pull Up Method protected doStart() : void from class org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategy to protected doStart() : void from class org.apache.camel.impl.remote.DefaultServiceCallServerListStrategy | From | To | |
| Rename Variable | 1 | ||
| Rename Variable lb : ServiceCallServerListStrategy to sl : ServiceCallServerListStrategy in method protected configureServerListStrategy(conf C, routeContext RouteContext, config ServiceCallConfigurationDefinition) : ServiceCallServerListStrategy in class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Change Return Type | 10 | ||
| Change Return Type Collection<ServiceCallServer> to List<T> in method public getInitialListOfServers(name String) : List<T> in class org.apache.camel.impl.remote.DefaultServiceCallServerListStrategy | From | To | |
| Change Return Type Collection<RibbonServer> to List<RibbonServer> in method public getUpdatedListOfServers(name String) : List<RibbonServer> in class org.apache.camel.component.ribbon.processor.RibbonServiceCallStaticServerListStrategy | From | To | |
| Change Return Type Collection<T> to List<T> in method public getInitialListOfServers(name String) : List<T> in class org.apache.camel.spi.ServiceCallServerListStrategy | From | To | |
| Change Return Type KubernetesServer to S in method public chooseServer(servers List<S>) : S in class org.apache.camel.impl.remote.RoundRobinServiceCallLoadBalancer | From | To | |
| Change Return Type ServiceCallLoadBalancer<ServiceCallServer> to ServiceCallLoadBalancer<S> in method public getLoadBalancer() : ServiceCallLoadBalancer<S> in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Return Type Collection<KubernetesServer> to List<ServiceCallServer> in method public getUpdatedListOfServers(name String) : List<ServiceCallServer> in class org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategies.Client | From | To | |
| Change Return Type Collection<ServiceCallServer> to List<ServiceCallServer> in method public getUpdatedListOfServers(name String) : List<ServiceCallServer> in class org.apache.camel.component.consul.processor.service.ConsulServiceCallServerListStrategies.OnDemand | From | To | |
| Change Return Type Collection<T> to List<T> in method public getUpdatedListOfServers(name String) : List<T> in class org.apache.camel.spi.ServiceCallServerListStrategy | From | To | |
| Change Return Type ServiceCallServerListStrategy<ServiceCallServer> to ServiceCallServerListStrategy<S> in method public getServerListStrategy() : ServiceCallServerListStrategy<S> in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Return Type Collection<RibbonServer> to List<RibbonServer> in method public getInitialListOfServers(name String) : List<RibbonServer> in class org.apache.camel.component.ribbon.processor.RibbonServiceCallStaticServerListStrategy | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable ref : String to name : String in method protected builtInLoadBalancer(conf C, name String) : Optional<ServiceCallLoadBalancer> in class org.apache.camel.impl.remote.DefaultServiceCallProcessorFactory | From | To | |
| Parameterize Variable rc : RibbonConfiguration to cfg : RibbonConfiguration in method protected createProcessor(routeContext RouteContext, definition ServiceCallDefinition, cfg RibbonConfiguration) : Processor in class org.apache.camel.component.ribbon.processor.RibbonProcessorFactory | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.camel.impl.remote.DefaultServiceCallServerListStrategy from classes [org.apache.camel.component.consul.processor.service.ConsulServiceCallServerListStrategy, org.apache.camel.component.kubernetes.processor.KubernetesServiceCallServerListStrategy] | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type serviceCallExpression : RibbonServiceCallExpression to serviceCallExpression : DefaultServiceCallExpression in class org.apache.camel.component.ribbon.processor.RibbonServiceCallProcessor | From | To | |
| Change Attribute Type serverListStrategy : ServiceCallServerListStrategy<ServiceCallServer> to serverListStrategy : ServiceCallServerListStrategy<S> in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Attribute Type loadBalancer : ServiceCallLoadBalancer<ServiceCallServer> to loadBalancer : ServiceCallLoadBalancer<S> in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Change Attribute Type serviceCallExpression : ServiceCallExpressionSupport to serviceCallExpression : Expression in class org.apache.camel.impl.remote.DefaultServiceCallProcessor | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter namespace : String to dnsServicePart : String in method protected buildCamelEndpointUri(name String, uri String, contextPath String, scheme String, dnsServicePart String) : String in class org.apache.camel.component.kubernetes.processor.KubernetesDnsServiceCallExpression | From | To |