camel 91121843801aed6411b7c91da3b1e502e2d35009

91121843801aed6411b7c91da3b1e502e2d35009

Files Diff

Added: 27
Removed: 9
Renamed: 0
Modified: 25

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public onAfterRoute(route Route, exchange Exchange) : void from class org.apache.camel.component.mllp.impl.AcknowledgmentSynchronizationAdapter to private sendAcknowledgement(originalHl7MessageBytes byte[], exchange Exchange) : void from class org.apache.camel.component.mllp.MllpTcpServerConsumer.ClientSocketThread	From	To
Move And Inline Method	1
Move And Inline Method package resetConnection(socket Socket) : void moved from class org.apache.camel.test.junit.rule.mllp.MllpServerResource to class org.apache.camel.test.junit.rule.mllp.MllpServerResource.ServerSocketThread & inlined to public run() : void	From	To
Change Parameter Type	1
Change Parameter Type route : Route to originalHl7MessageBytes : byte[] in method private sendAcknowledgement(originalHl7MessageBytes byte[], exchange Exchange) : void in class org.apache.camel.component.mllp.MllpTcpServerConsumer.ClientSocketThread	From	To
Move Method	3
Move Method protected covertBytesToPrintFriendlyString(hl7Bytes byte[]) : String from class org.apache.camel.component.mllp.MllpException to public covertBytesToPrintFriendlyString(hl7Bytes byte[], startPosition int, length int) : String from class org.apache.camel.component.mllp.MllpComponent	From	To
Move Method public resetConnection(socket Socket) : void from class org.apache.camel.component.mllp.impl.MllpUtil to package resetConnection() : void from class org.apache.camel.test.junit.rule.mllp.MllpServerResource.ClientSocketThread	From	To
Move Method public isLogPhi() : boolean from class org.apache.camel.component.mllp.MllpException to public isLogPhi() : boolean from class org.apache.camel.component.mllp.MllpComponent	From	To
Pull Up Attribute	3
Pull Up Attribute private hl7Message : byte[] from class org.apache.camel.component.mllp.MllpAcknowledgementException to private hl7Message : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Attribute private hl7Acknowledgement : byte[] from class org.apache.camel.component.mllp.MllpAcknowledgementException to private hl7Acknowledgement : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Attribute private hl7Message : byte[] from class org.apache.camel.component.mllp.MllpTimeoutException to private hl7Message : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Move Attribute	7
Move Attribute package EXCEPTION_MESSAGE : String from class org.apache.camel.component.mllp.MllpWriteExceptionTest to package EXCEPTION_MESSAGE : String from class org.apache.camel.component.mllp.MllpTimeoutException	From	To
Move Attribute package EXCEPTION_MESSAGE : String from class org.apache.camel.component.mllp.MllpTimeoutExceptionTest to package EXCEPTION_MESSAGE : String from class org.apache.camel.component.mllp.MllpTimeoutException	From	To
Move Attribute package timeout : MockEndpoint from class org.apache.camel.component.mllp.MllpTcpClientProducerTest to package timeout : MockEndpoint from class org.apache.camel.component.mllp.MllpTcpServerConsumerTest	From	To
Move Attribute package EXCEPTION_MESSAGE : String from class org.apache.camel.component.mllp.MllpFrameExceptionTest to package EXCEPTION_MESSAGE : String from class org.apache.camel.component.mllp.MllpTimeoutException	From	To
Move Attribute package acknowledgementGenerator : Hl7AcknowledgementGenerator from class org.apache.camel.component.mllp.impl.AcknowledgmentSynchronizationAdapter to package acknowledgementGenerator : Hl7AcknowledgementGenerator from class org.apache.camel.component.mllp.MllpTcpServerConsumer	From	To
Move Attribute package timeout : MockEndpoint from class org.apache.camel.component.mllp.MllpTcpClientProducerTest to package timeout : MockEndpoint from class org.apache.camel.component.mllp.MllpTcpServerConsumerMessageValidationTest	From	To
Move Attribute package complete : MockEndpoint from class org.apache.camel.component.mllp.MllpTcpClientProducerAcknowledgementTest to package complete : MockEndpoint from class org.apache.camel.component.mllp.MllpTcpClientProducerConnectionErrorTest	From	To
Rename Class	1
Rename Class org.apache.camel.component.mllp.MllpAcknowledgementTimoutException renamed to org.apache.camel.component.mllp.MllpInvalidMessageException	From	To
Change Variable Type	1
Change Variable Type outstream : BufferedOutputStream to outputStream : OutputStream in method private uncheckedFlush(outputStream OutputStream) : void in class org.apache.camel.test.junit.rule.mllp.MllpServerResource.ClientSocketThread	From	To
Extract Method	2
Extract Method private uncheckedFlush(outputStream OutputStream) : void extracted from public run() : void in class org.apache.camel.test.junit.rule.mllp.MllpServerResource.ClientSocketThread	From	To
Extract Method private processAcknowledgment(hl7MessageBytes byte[], hl7AcknowledgementBytes byte[]) : String extracted from public process(exchange Exchange) : void in class org.apache.camel.component.mllp.MllpTcpClientProducer	From	To
Rename Method	8
Rename Method public disconnectAfterAcknowledgement(messageCount int) : boolean renamed to public closeSocketAfterAcknowledgement(messageCount int) : boolean in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Method public getDisconnectBeforeAcknowledgementModulus() : int renamed to public getCloseSocketBeforeAcknowledgementModulus() : int in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Method public setDisconnectAfterAcknowledgementModulus(disconnectAfterAcknowledgementModulus int) : void renamed to public setCloseSocketAfterAcknowledgementModulus(closeSocketAfterAcknowledgementModulus int) : void in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Method public getDisconnectAfterAcknowledgementModulus() : int renamed to public getCloseSocketAfterAcknowledgementModulus() : int in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Method public disconnectBeforeAcknowledgement(messageCount int) : boolean renamed to public closeSocketBeforeAcknowledgement(messageCount int) : boolean in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Method public testConnectWithoutData() : void renamed to public testConnectThenCloseWithoutData() : void in class org.apache.camel.component.mllp.MllpTcpServerConsumerConnectionTest	From	To
Rename Method public testLoopbackMultipleMessages() : void renamed to public testLoopbackWithMultipleMessages() : void in class org.apache.camel.component.mllp.MllpProducerConsumerLoopbackTest	From	To
Rename Method public setDisconnectBeforeAcknowledgementModulus(disconnectBeforeAcknowledgementModulus int) : void renamed to public setCloseSocketBeforeAcknowledgementModulus(closeSocketBeforeAcknowledgementModulus int) : void in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Pull Up Method	10
Pull Up Method public getMllpPayload() : byte[] from class org.apache.camel.component.mllp.MllpWriteException to public getHl7Acknowledgement() : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getMllpPayload() : byte[] from class org.apache.camel.component.mllp.MllpFrameException to public getHl7Message() : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getMessage() : String from class org.apache.camel.component.mllp.MllpFrameException to public getMessage() : String from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getHl7Message() : byte[] from class org.apache.camel.component.mllp.MllpAcknowledgementException to public getHl7Message() : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getMllpPayload() : byte[] from class org.apache.camel.component.mllp.MllpFrameException to public getHl7Acknowledgement() : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getMllpPayload() : byte[] from class org.apache.camel.component.mllp.MllpWriteException to public getHl7Message() : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getHl7Acknowledgement() : byte[] from class org.apache.camel.component.mllp.MllpAcknowledgementException to public getHl7Acknowledgement() : byte[] from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getMessage() : String from class org.apache.camel.component.mllp.MllpWriteException to public getMessage() : String from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getMessage() : String from class org.apache.camel.component.mllp.MllpTimeoutException to public getMessage() : String from class org.apache.camel.component.mllp.MllpException	From	To
Pull Up Method public getMessage() : String from class org.apache.camel.component.mllp.MllpAcknowledgementException to public getMessage() : String from class org.apache.camel.component.mllp.MllpException	From	To
Change Return Type	1
Change Return Type Exception to void in method package checkConnection() : void in class org.apache.camel.component.mllp.MllpTcpClientProducer	From	To
Parameterize Variable	2
Parameterize Variable acknowledgementBytes : byte[] to hl7AcknowledgementBytes : byte[] in method private processAcknowledgment(hl7MessageBytes byte[], hl7AcknowledgementBytes byte[]) : String in class org.apache.camel.component.mllp.MllpTcpClientProducer	From	To
Parameterize Variable outstream : BufferedOutputStream to outputStream : OutputStream in method private uncheckedFlush(outputStream OutputStream) : void in class org.apache.camel.test.junit.rule.mllp.MllpServerResource.ClientSocketThread	From	To
Extract Superclass	1
Extract Superclass org.apache.camel.component.mllp.MllpNegativeAcknowledgementException from classes [org.apache.camel.component.mllp.MllpApplicationErrorAcknowledgementException, org.apache.camel.component.mllp.MllpApplicationRejectAcknowledgementException, org.apache.camel.component.mllp.MllpCommitErrorAcknowledgementException, org.apache.camel.component.mllp.MllpCommitRejectAcknowledgementException]	From	To
Rename Attribute	6
Rename Attribute error : MockEndpoint to ae : MockEndpoint in class org.apache.camel.component.mllp.MllpTcpClientProducerAcknowledgementTest	From	To
Rename Attribute reject : MockEndpoint to ar : MockEndpoint in class org.apache.camel.component.mllp.MllpTcpClientProducerAcknowledgementTest	From	To
Rename Attribute disconnectBeforeAcknowledgementModulus : int to closeSocketBeforeAcknowledgementModulus : int in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Attribute accept : MockEndpoint to aa : MockEndpoint in class org.apache.camel.component.mllp.MllpTcpClientProducerAcknowledgementTest	From	To
Rename Attribute disconnectAfterAcknowledgementModulus : int to closeSocketAfterAcknowledgementModulus : int in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Attribute timeout : MockEndpoint to timeoutError : MockEndpoint in class org.apache.camel.component.mllp.MllpTcpClientProducerTest	From	To
Extract And Move Method	1
Extract And Move Method protected generateAcknowledgement(hl7Message String, acknowledgementCode String) : String extracted from private generateAcknowledgementMessage(hl7Message String, acknowledgementCode String) : String in class org.apache.camel.test.junit.rule.mllp.MllpServerResource.ClientSocketThread & moved to class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Parameter	9
Rename Parameter hl7Message : byte[] to partialHl7Message : byte[] in method public MllpTimeoutException(message String, partialHl7Message byte[]) in class org.apache.camel.component.mllp.MllpTimeoutException	From	To
Rename Parameter mllpPayload : byte[] to hl7Message : byte[] in method public MllpFrameException(message String, hl7Message byte[]) in class org.apache.camel.component.mllp.MllpFrameException	From	To
Rename Parameter hl7Message : byte[] to partialHl7Message : byte[] in method public MllpTimeoutException(message String, partialHl7Message byte[], cause Throwable) in class org.apache.camel.component.mllp.MllpTimeoutException	From	To
Rename Parameter mllpPayload : byte[] to hl7Message : byte[] in method public MllpFrameException(message String, hl7Message byte[], cause Throwable) in class org.apache.camel.component.mllp.MllpFrameException	From	To
Rename Parameter route : Route to originalHl7MessageBytes : byte[] in method private sendAcknowledgement(originalHl7MessageBytes byte[], exchange Exchange) : void in class org.apache.camel.component.mllp.MllpTcpServerConsumer.ClientSocketThread	From	To
Rename Parameter disconnectAfterAcknowledgementModulus : int to closeSocketAfterAcknowledgementModulus : int in method public setCloseSocketAfterAcknowledgementModulus(closeSocketAfterAcknowledgementModulus int) : void in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To
Rename Parameter mllpPayload : byte[] to hl7Message : byte[] in method public MllpWriteException(message String, hl7Message byte[]) in class org.apache.camel.component.mllp.MllpWriteException	From	To
Rename Parameter mllpPayload : byte[] to hl7Message : byte[] in method public MllpWriteException(message String, hl7Message byte[], cause Throwable) in class org.apache.camel.component.mllp.MllpWriteException	From	To
Rename Parameter disconnectBeforeAcknowledgementModulus : int to closeSocketBeforeAcknowledgementModulus : int in method public setCloseSocketBeforeAcknowledgementModulus(closeSocketBeforeAcknowledgementModulus int) : void in class org.apache.camel.test.junit.rule.mllp.MllpServerResource	From	To

91121843801aed6411b7c91da3b1e502e2d35009

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: