0675a62562fd63e147748cd282b2bb4f1fa235f3
Files Diff
- Added: 8
- Removed: 10
- Renamed: 0
- Modified: 33
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 7 | ||
| Rename Method public onRemovalEvent(event BeforeAccountRemovedEvent) : void renamed to public onCascadeEvent(event BeforeAccountRemovedEvent) : void in class org.eclipse.che.api.workspace.server.jpa.JpaWorkspaceDao.RemoveWorkspaceBeforeAccountRemovedEventSubscriber | From | To | |
| Rename Method public onRemovalEvent(event BeforeUserRemovedEvent) : void renamed to public onCascadeEvent(event BeforeUserRemovedEvent) : void in class org.eclipse.che.api.user.server.jpa.JpaPreferenceDao.RemovePreferencesBeforeUserRemovedEventSubscriber | From | To | |
| Rename Method public shouldFireEventOnRemoveExistedUser() : void renamed to public shouldFireUserRemovedEventOnRemoveExistedUser() : void in class org.eclipse.che.api.user.server.spi.tck.UserDaoTest | From | To | |
| Rename Method public onRemovalEvent(event BeforeUserRemovedEvent) : void renamed to public onCascadeEvent(event BeforeUserRemovedEvent) : void in class org.eclipse.che.api.factory.server.jpa.JpaFactoryDao.RemoveFactoriesBeforeUserRemovedEventSubscriber | From | To | |
| Rename Method public onRemovalEvent(event BeforeUserRemovedEvent) : void renamed to public onCascadeEvent(event BeforeUserRemovedEvent) : void in class org.eclipse.che.api.ssh.server.jpa.JpaSshDao.RemoveSshKeysBeforeUserRemovedEventSubscriber | From | To | |
| Rename Method public onRemovalEvent(event BeforeUserRemovedEvent) : void renamed to public onCascadeEvent(event BeforeUserRemovedEvent) : void in class org.eclipse.che.api.user.server.jpa.JpaProfileDao.RemoveProfileBeforeUserRemovedEventSubscriber | From | To | |
| Rename Method public onRemovalEvent(event BeforeWorkspaceRemovedEvent) : void renamed to public onCascadeEvent(event BeforeWorkspaceRemovedEvent) : void in class org.eclipse.che.api.workspace.server.jpa.JpaWorkspaceDao.RemoveSnapshotsBeforeWorkspaceRemovedEventSubscriber | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type eventClass : Class<CascadeRemovalEvent> to eventClass : Class<CascadeEvent> in method public shouldRollbackTransactionWhenFailedToRemoveAnyOfEntries(subscriberClass Class<CascadeEventSubscriber<CascadeEvent>>, eventClass Class<CascadeEvent>) : void in class org.eclipse.che.core.db.jpa.CascadeRemovalTest | From | To | |
| Change Parameter Type event : Object to event : T in method public publish(event T) : T in class org.eclipse.che.api.core.notification.EventService | From | To | |
| Change Parameter Type subscriberClass : Class<CascadeRemovalEventSubscriber<CascadeRemovalEvent>> to subscriberClass : Class<CascadeEventSubscriber<CascadeEvent>> in method public shouldRollbackTransactionWhenFailedToRemoveAnyOfEntries(subscriberClass Class<CascadeEventSubscriber<CascadeEvent>>, eventClass Class<CascadeEvent>) : void in class org.eclipse.che.core.db.jpa.CascadeRemovalTest | From | To | |
| Rename Variable | 3 | ||
| Rename Variable user : Optional<UserImpl> to userOpt : Optional<UserImpl> in method public remove(id String) : void in class org.eclipse.che.api.user.server.jpa.JpaUserDao | From | To | |
| Rename Variable firedUserId : String[] to firedEvent : UserRemovedEvent[] in method public shouldFireUserRemovedEventOnRemoveExistedUser() : void in class org.eclipse.che.api.user.server.spi.tck.UserDaoTest | From | To | |
| Rename Variable eventSubscriber : EventSubscriber to userRemovedSubscriber : EventSubscriber<UserRemovedEvent> in method public shouldFireUserRemovedEventOnRemoveExistedUser() : void in class org.eclipse.che.api.user.server.spi.tck.UserDaoTest | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to T in method public publish(event T) : T in class org.eclipse.che.api.core.notification.EventService | From | To | |
| Change Return Type RemovalContext to CascadeContext in method public fail(cause Exception) : CascadeContext in class org.eclipse.che.core.db.cascade.CascadeContext | From | To | |
| Change Return Type void to Optional<WorkspaceImpl> in method protected doRemove(id String) : Optional<WorkspaceImpl> in class org.eclipse.che.api.workspace.server.jpa.JpaWorkspaceDao | From | To | |
| Rename Class | 2 | ||
| Rename Class org.eclipse.che.api.user.server.event.BeforeUserPersistedEvent renamed to org.eclipse.che.api.user.server.event.PostUserPersistedEvent | From | To | |
| Rename Class org.eclipse.che.api.user.server.event.PostUserRemovedEvent renamed to org.eclipse.che.api.user.server.event.UserRemovedEvent | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.eclipse.che.core.db.event.RemovalContext moved and renamed to org.eclipse.che.core.db.cascade.CascadeContext | From | To | |
| Extract Superclass | 3 | ||
| Extract Superclass org.eclipse.che.core.db.cascade.CascadeEventSubscriber from classes [org.eclipse.che.api.factory.server.jpa.JpaFactoryDao.RemoveFactoriesBeforeUserRemovedEventSubscriber, org.eclipse.che.api.ssh.server.jpa.JpaSshDao.RemoveSshKeysBeforeUserRemovedEventSubscriber, org.eclipse.che.api.user.server.jpa.JpaPreferenceDao.RemovePreferencesBeforeUserRemovedEventSubscriber, org.eclipse.che.api.user.server.jpa.JpaProfileDao.RemoveProfileBeforeUserRemovedEventSubscriber, org.eclipse.che.api.workspace.server.jpa.JpaWorkspaceDao.RemoveWorkspaceBeforeAccountRemovedEventSubscriber, org.eclipse.che.api.workspace.server.jpa.JpaWorkspaceDao.RemoveSnapshotsBeforeWorkspaceRemovedEventSubscriber] | From | To | |
| Extract Superclass org.eclipse.che.core.db.cascade.event.PersistEvent from classes [org.eclipse.che.api.machine.server.event.RecipePersistedEvent, org.eclipse.che.api.user.server.event.PostUserPersistedEvent, org.eclipse.che.api.workspace.server.event.StackPersistedEvent] | From | To | |
| Extract Superclass org.eclipse.che.core.db.cascade.event.RemoveEvent from classes [org.eclipse.che.account.event.BeforeAccountRemovedEvent, org.eclipse.che.api.machine.server.event.BeforeRecipeRemovedEvent, org.eclipse.che.api.user.server.event.BeforeUserRemovedEvent, org.eclipse.che.api.workspace.server.event.BeforeStackRemovedEvent, org.eclipse.che.api.workspace.server.event.BeforeWorkspaceRemovedEvent] | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type firedUserId : String[] to firedEvent : UserRemovedEvent[] in method public shouldFireUserRemovedEventOnRemoveExistedUser() : void in class org.eclipse.che.api.user.server.spi.tck.UserDaoTest | From | To | |
| Change Variable Type eventSubscriber : EventSubscriber to userRemovedSubscriber : EventSubscriber<UserRemovedEvent> in method public shouldFireUserRemovedEventOnRemoveExistedUser() : void in class org.eclipse.che.api.user.server.spi.tck.UserDaoTest | From | To | |
| Extract Variable | 6 | ||
| Extract Variable manager : EntityManager in method protected doCreate(entity SshPairImpl) : void from class org.eclipse.che.api.ssh.server.jpa.JpaSshDao | From | To | |
| Extract Variable manage : EntityManager in method protected doCreate(user UserImpl) : void from class org.eclipse.che.api.user.server.jpa.JpaUserDao | From | To | |
| Extract Variable manager : EntityManager in method protected doUpdate(update WorkspaceImpl) : WorkspaceImpl from class org.eclipse.che.api.workspace.server.jpa.JpaWorkspaceDao | From | To | |
| Extract Variable manager : EntityManager in method protected doCreate(profile ProfileImpl) : void from class org.eclipse.che.api.user.server.jpa.JpaProfileDao | From | To | |
| Extract Variable manager : EntityManager in method protected doCreate(workspace WorkspaceImpl) : void from class org.eclipse.che.api.workspace.server.jpa.JpaWorkspaceDao | From | To | |
| Extract Variable manager : EntityManager in method protected doCreate(stack StackImpl) : void from class org.eclipse.che.api.workspace.server.jpa.JpaStackDao | From | To |