0c81935f217e23b11f7809f5e222c373da20e381
Files Diff
- Added: 7
- Removed: 0
- Renamed: 0
- Modified: 37
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public shouldAddServersConfsPortsFromMachineConfigToExposedPortsOnDevInstanceCreationFromRecipe() : void renamed to public shouldAddServersConfigsPortsFromMachineConfigToExposedPortsOnDevInstanceCreationFromRecipe() : void in class org.eclipse.che.plugin.docker.machine.MachineProviderImplTest | From | To | |
| Rename Method public getVersion() : String renamed to public getWorkspaceId() : String in class org.eclipse.che.api.environment.server.model.CheServicesEnvironmentImpl | From | To | |
| Rename Method public withVersion(version String) : CheServicesEnvironmentImpl renamed to public withWorkspaceId(workspaceId String) : CheServicesEnvironmentImpl in class org.eclipse.che.api.environment.server.model.CheServicesEnvironmentImpl | From | To | |
| Rename Method public setVersion(version String) : void renamed to public setWorkspaceId(workspaceId String) : void in class org.eclipse.che.api.environment.server.model.CheServicesEnvironmentImpl | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private applyAgents(env Environment, servicesEnvironment CheServicesEnvironmentImpl) : void from class org.eclipse.che.api.environment.server.CheEnvironmentEngine to public apply(envConfig Environment, internalEnv CheServicesEnvironmentImpl) : void from class org.eclipse.che.api.environment.server.AgentConfigApplier | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type agentConfigApplier : AgentConfigApplier to infrastructureProvisioner : InfrastructureProvisioner in method public CheEnvironmentEngine(snapshotDao SnapshotDao, machineInstanceProviders MachineInstanceProviders, machineLogsDir String, defaultMachineMemorySizeMB int, eventService EventService, environmentParser EnvironmentParser, startStrategy DefaultServicesStartStrategy, machineProvider MachineInstanceProvider, infrastructureProvisioner InfrastructureProvisioner, apiEndpoint String, recipeDownloader RecipeDownloader, containerNameGenerator ContainerNameGenerator, agentRegistry AgentRegistry) in class org.eclipse.che.api.environment.server.CheEnvironmentEngine | From | To | |
| Move Method | 1 | ||
| Move Method package escapePath(path String) : String from class org.eclipse.che.plugin.docker.machine.MachineProviderImpl to public escapePath(path String) : String from class org.eclipse.che.commons.lang.os.WindowsPathEscaper | From | To | |
| Rename Variable | 2 | ||
| Rename Variable environment : CheServicesEnvironmentImpl to internalEnv : CheServicesEnvironmentImpl in method private initializeEnvironment(namespace String, workspaceId String, envName String, envConfig Environment, networkId String, messageConsumer MessageConsumer<MachineLogMessage>) : void in class org.eclipse.che.api.environment.server.CheEnvironmentEngine | From | To | |
| Rename Variable that : AgentImpl to agent : AgentImpl in method public equals(o Object) : boolean in class org.eclipse.che.api.agent.server.model.impl.AgentImpl | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private agentConfigApplier : AgentConfigApplier from class org.eclipse.che.api.environment.server.CheEnvironmentEngine to private agentConfigApplier : AgentConfigApplier from class org.eclipse.che.api.environment.server.DefaultInfrastructureProvisioner | From | To | |
| Move Attribute private workspaceFolderPathProvider : WorkspaceFolderPathProvider from class org.eclipse.che.plugin.docker.machine.MachineProviderImpl to private workspaceFolderPathProvider : WorkspaceFolderPathProvider from class org.eclipse.che.plugin.docker.machine.local.LocalCheInfrastructureProvisioner | From | To | |
| Move Attribute private projectFolderPath : String from class org.eclipse.che.plugin.docker.machine.MachineProviderImpl to private projectFolderPath : String from class org.eclipse.che.plugin.docker.machine.local.LocalCheInfrastructureProvisioner | From | To | |
| Move Attribute package agentConfigApplier : AgentConfigApplier from class org.eclipse.che.api.environment.server.CheEnvironmentEngineTest to private agentConfigApplier : AgentConfigApplier from class org.eclipse.che.api.environment.server.DefaultInfrastructureProvisioner | From | To | |
| Move Attribute private workspaceFolderPathProvider : WorkspaceFolderPathProvider from class org.eclipse.che.plugin.docker.machine.MachineProviderImplTest to private workspaceFolderPathProvider : WorkspaceFolderPathProvider from class org.eclipse.che.plugin.docker.machine.local.LocalCheInfrastructureProvisioner | From | To | |
| Extract Class | 2 | ||
| Extract Class org.eclipse.che.plugin.docker.machine.local.LocalCheInfrastructureProvisioner from class org.eclipse.che.plugin.docker.machine.MachineProviderImpl | From | To | |
| Extract Class org.eclipse.che.commons.lang.os.WindowsPathEscaper from class org.eclipse.che.plugin.docker.machine.MachineProviderImpl | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute workspaceFolderPathProvider : WorkspaceFolderPathProvider to windowsPathEscaper : WindowsPathEscaper in class org.eclipse.che.plugin.docker.machine.MachineProviderImpl | From | To | |
| Rename Attribute agentConfigApplier : AgentConfigApplier to infrastructureProvisioner : InfrastructureProvisioner in class org.eclipse.che.api.environment.server.CheEnvironmentEngine | From | To | |
| Rename Attribute agentConfigApplier : AgentConfigApplier to infrastructureProvisioner : InfrastructureProvisioner in class org.eclipse.che.api.environment.server.CheEnvironmentEngineTest | From | To | |
| Rename Attribute version : String to workspaceId : String in class org.eclipse.che.api.environment.server.model.CheServicesEnvironmentImpl | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type workspaceFolderPathProvider : WorkspaceFolderPathProvider to windowsPathEscaper : WindowsPathEscaper in class org.eclipse.che.plugin.docker.machine.MachineProviderImpl | From | To | |
| Change Attribute Type agentConfigApplier : AgentConfigApplier to infrastructureProvisioner : InfrastructureProvisioner in class org.eclipse.che.api.environment.server.CheEnvironmentEngine | From | To | |
| Change Attribute Type agentConfigApplier : AgentConfigApplier to infrastructureProvisioner : InfrastructureProvisioner in class org.eclipse.che.api.environment.server.CheEnvironmentEngineTest | From | To | |
| Rename Parameter | 8 | ||
| Rename Parameter obj : Object to o : Object in method public equals(o Object) : boolean in class org.eclipse.che.api.agent.server.model.impl.AgentImpl | From | To | |
| Rename Parameter version : String to workspaceId : String in method public setWorkspaceId(workspaceId String) : void in class org.eclipse.che.api.environment.server.model.CheServicesEnvironmentImpl | From | To | |
| Rename Parameter version : String to workspaceId : String in method public withWorkspaceId(workspaceId String) : CheServicesEnvironmentImpl in class org.eclipse.che.api.environment.server.model.CheServicesEnvironmentImpl | From | To | |
| Rename Parameter agentConfigApplier : AgentConfigApplier to infrastructureProvisioner : InfrastructureProvisioner in method public CheEnvironmentEngine(snapshotDao SnapshotDao, machineInstanceProviders MachineInstanceProviders, machineLogsDir String, defaultMachineMemorySizeMB int, eventService EventService, environmentParser EnvironmentParser, startStrategy DefaultServicesStartStrategy, machineProvider MachineInstanceProvider, infrastructureProvisioner InfrastructureProvisioner, apiEndpoint String, recipeDownloader RecipeDownloader, containerNameGenerator ContainerNameGenerator, agentRegistry AgentRegistry) in class org.eclipse.che.api.environment.server.CheEnvironmentEngine | From | To | |
| Rename Parameter servicesEnvironment : CheServicesEnvironmentImpl to internalEnv : CheServicesEnvironmentImpl in method public apply(envConfig Environment, internalEnv CheServicesEnvironmentImpl) : void in class org.eclipse.che.api.environment.server.AgentConfigApplier | From | To | |
| Rename Parameter env : Environment to envConfig : Environment in method public apply(envConfig Environment, internalEnv CheServicesEnvironmentImpl) : void in class org.eclipse.che.api.environment.server.AgentConfigApplier | From | To | |
| Rename Parameter env : Environment to envConfig : Environment in method private initializeEnvironment(namespace String, workspaceId String, envName String, envConfig Environment, networkId String, messageConsumer MessageConsumer<MachineLogMessage>) : void in class org.eclipse.che.api.environment.server.CheEnvironmentEngine | From | To | |
| Rename Parameter projectFolderPath : String to networkDriver : String in method public MachineProviderImpl(docker DockerConnector, dockerConnectorConfiguration DockerConnectorConfiguration, dockerCredentials UserSpecificDockerRegistryCredentialsProvider, dockerMachineFactory DockerMachineFactory, dockerInstanceStopDetector DockerInstanceStopDetector, devMachineServers Set<ServerConf>, allMachinesServers Set<ServerConf>, devMachineSystemVolumes Set<String>, allMachinesSystemVolumes Set<String>, allMachinesExtraHosts String, doForcePullOnBuild boolean, privilegeMode boolean, devMachineEnvVariables Set<String>, allMachinesEnvVariables Set<String>, snapshotUseRegistry boolean, memorySwapMultiplier double, additionalNetworks Set<Set<String>>, networkDriver String, windowsPathEscaper WindowsPathEscaper) in class org.eclipse.che.plugin.docker.machine.MachineProviderImpl | From | To |