che 0d6c7795fa838a10a0638ae2e24d88f778f65526

0d6c7795fa838a10a0638ae2e24d88f778f65526

Files Diff

Added: 8
Removed: 0
Renamed: 0
Modified: 31

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method protected checkContainerIsRunning(container String) : void renamed to protected getRunningContainer(container String) : ContainerInfo in class org.eclipse.che.workspace.infrastructure.docker.DockerMachineStarter	From	To
Push Down Method	1
Push Down Method public getRuntime(id RuntimeIdentity) : InternalRuntime from class org.eclipse.che.api.workspace.server.spi.RuntimeInfrastructure to public prepare(id RuntimeIdentity, environment Environment) : RuntimeContext from class org.eclipse.che.api.workspace.server.WorkspaceRuntimesTest.TestInfrastructure	From	To
Change Parameter Type	1
Change Parameter Type workspaceManager : Provider<WorkspaceManager> to workspaceDao : WorkspaceDao in method public LocalWorkspaceFolderPathProvider(workspacesMountPoint String, workspaceDao WorkspaceDao) in class org.eclipse.che.workspace.infrastructure.docker.local.providers.LocalWorkspaceFolderPathProvider	From	To
Rename Variable	1
Rename Variable id : RuntimeIdentity to identity : RuntimeIdentity in method private recover() : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes	From	To
Change Return Type	4
Change Return Type InternalRuntime to DockerInternalRuntime in method public getRuntime() : DockerInternalRuntime in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeContext	From	To
Change Return Type void to ContainerInfo in method protected getRunningContainer(container String) : ContainerInfo in class org.eclipse.che.workspace.infrastructure.docker.DockerMachineStarter	From	To
Change Return Type InternalRuntime to RuntimeContext in method public prepare(id RuntimeIdentity, environment Environment) : RuntimeContext in class org.eclipse.che.api.workspace.server.WorkspaceRuntimesTest.TestInfrastructure	From	To
Change Return Type RuntimeContext to T in method public getContext() : T in class org.eclipse.che.api.workspace.server.spi.InternalRuntime	From	To
Move Attribute	3
Move Attribute private registryNamespace : String from class org.eclipse.che.workspace.infrastructure.docker.DockerMachineStarter to private registryNamespace : String from class org.eclipse.che.workspace.infrastructure.docker.DockerMachineCreator	From	To
Move Attribute private runtimeFactory : DockerRuntimeFactory from class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeInfrastructure to private runtimeFactory : DockerRuntimeFactory from class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeContext	From	To
Move Attribute private registry : String from class org.eclipse.che.workspace.infrastructure.docker.DockerMachineStarter to private registry : String from class org.eclipse.che.workspace.infrastructure.docker.DockerMachineCreator	From	To
Extract Class	1
Extract Class org.eclipse.che.workspace.infrastructure.docker.DockerMachineCreator from class org.eclipse.che.workspace.infrastructure.docker.DockerMachineStarter	From	To
Rename Attribute	6
Rename Attribute registry : String to machineCreator : DockerMachineCreator in class org.eclipse.che.workspace.infrastructure.docker.DockerMachineStarter	From	To
Rename Attribute dockerNetworkLifecycle : NetworkLifecycle to networks : NetworkLifecycle in class org.eclipse.che.workspace.infrastructure.docker.DockerInternalRuntime	From	To
Rename Attribute dockerRuntimeFactory : DockerRuntimeFactory to runtimeFactory : DockerRuntimeFactory in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeContext	From	To
Rename Attribute runtimeFactory : DockerRuntimeFactory to contextFactory : DockerRuntimeContextFactory in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeInfrastructure	From	To
Rename Attribute workspaceManager : Provider<WorkspaceManager> to workspaceDao : WorkspaceDao in class org.eclipse.che.workspace.infrastructure.docker.local.providers.LocalWorkspaceFolderPathProvider	From	To
Rename Attribute installerRegistry : InstallerRegistry to containers : DockerContainers in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeInfrastructure	From	To
Change Attribute Type	4
Change Attribute Type workspaceManager : Provider<WorkspaceManager> to workspaceDao : WorkspaceDao in class org.eclipse.che.workspace.infrastructure.docker.local.providers.LocalWorkspaceFolderPathProvider	From	To
Change Attribute Type installerRegistry : InstallerRegistry to containers : DockerContainers in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeInfrastructure	From	To
Change Attribute Type registry : String to machineCreator : DockerMachineCreator in class org.eclipse.che.workspace.infrastructure.docker.DockerMachineStarter	From	To
Change Attribute Type runtimeFactory : DockerRuntimeFactory to contextFactory : DockerRuntimeContextFactory in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeInfrastructure	From	To
Rename Parameter	6
Rename Parameter dockerRuntimeFactory : DockerRuntimeFactory to runtimeFactory : DockerRuntimeFactory in method public DockerRuntimeContext(infrastructure DockerRuntimeInfrastructure, identity RuntimeIdentity, environment Environment, dockerEnv DockerEnvironment, installerRegistry InstallerRegistry, startStrategy ContainersStartStrategy, runtimeFactory DockerRuntimeFactory, containers DockerContainers, sharedPool DockerSharedPool, consistencyChecker RuntimeConsistencyChecker, websocketEndpointBase String) in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeContext	From	To
Rename Parameter container : String to containerId : String in method public DockerMachine(containerId String, image String, docker DockerConnector, servers Map<String,ServerImpl>, registry String, snapshotUseRegistry boolean, registryNamespace String, dockerMachineStopDetector DockerMachineStopDetector) in class org.eclipse.che.workspace.infrastructure.docker.DockerMachine	From	To
Rename Parameter containerStarter : DockerMachineStarter to machineStarter : DockerMachineStarter in method private DockerInternalRuntime(context DockerRuntimeContext, urlRewriter URLRewriter, running boolean, networks NetworkLifecycle, machineStarter DockerMachineStarter, snapshotDao SnapshotDao, dockerRegistryClient DockerRegistryClient, eventService EventService, bootstrapperFactory DockerBootstrapperFactory, serverCheckerFactory ServerCheckerFactory, loggers MachineLoggersFactory) in class org.eclipse.che.workspace.infrastructure.docker.DockerInternalRuntime	From	To
Rename Parameter dockerNetworkLifecycle : NetworkLifecycle to networks : NetworkLifecycle in method private DockerInternalRuntime(context DockerRuntimeContext, urlRewriter URLRewriter, running boolean, networks NetworkLifecycle, machineStarter DockerMachineStarter, snapshotDao SnapshotDao, dockerRegistryClient DockerRegistryClient, eventService EventService, bootstrapperFactory DockerBootstrapperFactory, serverCheckerFactory ServerCheckerFactory, loggers MachineLoggersFactory) in class org.eclipse.che.workspace.infrastructure.docker.DockerInternalRuntime	From	To
Rename Parameter dockerEnvironment : DockerEnvironment to dockerEnv : DockerEnvironment in method public DockerRuntimeContext(infrastructure DockerRuntimeInfrastructure, identity RuntimeIdentity, environment Environment, dockerEnv DockerEnvironment, installerRegistry InstallerRegistry, startStrategy ContainersStartStrategy, runtimeFactory DockerRuntimeFactory, containers DockerContainers, sharedPool DockerSharedPool, consistencyChecker RuntimeConsistencyChecker, websocketEndpointBase String) in class org.eclipse.che.workspace.infrastructure.docker.DockerRuntimeContext	From	To
Rename Parameter workspaceManager : Provider<WorkspaceManager> to workspaceDao : WorkspaceDao in method public LocalWorkspaceFolderPathProvider(workspacesMountPoint String, workspaceDao WorkspaceDao) in class org.eclipse.che.workspace.infrastructure.docker.local.providers.LocalWorkspaceFolderPathProvider	From	To

0d6c7795fa838a10a0638ae2e24d88f778f65526

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: