1a40c22235cbe45cd0b09e97427cc8448aefe902
Files Diff
- Added: 2
- Removed: 2
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private devCommandToCommandImpls(devFile Devfile, devCommand Command) : List<CommandImpl> renamed to private devCommandToCommandImpl(devCommand Command, commandAction Action, toolOfCommand Tool) : CommandImpl in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in method public DevfileConverter(kubernetesToolApplier KubernetesToolApplier) in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Rename Variable | 5 | ||
| Rename Variable result : EnvironmentImpl to environment : EnvironmentImpl in method public shouldReturnEnvironmentWithCorrectRecipeTypeAndContentFromOSList() : void in class org.eclipse.che.api.devfile.server.KubernetesToolApplierTest | From | To | |
| Rename Variable yamlContent : String to devfileYaml : String in method public shouldBuildWorkspaceConfigFromYamlDevFile() : void in class org.eclipse.che.api.devfile.server.DevfileConverterTest | From | To | |
| Rename Variable result : EnvironmentImpl to environment : EnvironmentImpl in method public shouldReturnEnvironmentWithCorrectRecipeTypeAndContentFromK8SList() : void in class org.eclipse.che.api.devfile.server.KubernetesToolApplierTest | From | To | |
| Rename Variable jsonContent : String to workspaceConfigJson : String in method public shouldBuildYamlDevFileFromWorkspaceConfig() : void in class org.eclipse.che.api.devfile.server.DevfileConverterTest | From | To | |
| Rename Variable result : EnvironmentImpl to environment : EnvironmentImpl in method public shouldFilterRecipeWithGivenSelectors() : void in class org.eclipse.che.api.devfile.server.KubernetesToolApplierTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<CommandImpl> to CommandImpl in method private devCommandToCommandImpl(devCommand Command, commandAction Action, toolOfCommand Tool) : CommandImpl in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Rename Class | 2 | ||
| Rename Class org.eclipse.che.api.devfile.server.DevfileEnvironmentFactory renamed to org.eclipse.che.api.devfile.server.KubernetesToolApplier | From | To | |
| Rename Class org.eclipse.che.api.devfile.server.DevfileEnvironmentFactoryTest renamed to org.eclipse.che.api.devfile.server.KubernetesToolApplierTest | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable devAction : Action to commandAction : Action in method private devCommandToCommandImpl(devCommand Command, commandAction Action, toolOfCommand Tool) : CommandImpl in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Rename Attribute DEFAULT_RECIPE_CONTENT_TYPE : String to YAML_CONTENT_TYPE : String in class org.eclipse.che.api.devfile.server.KubernetesToolApplier | From | To | |
| Rename Attribute devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in class org.eclipse.che.api.devfile.server.DevfileManagerTest | From | To | |
| Rename Attribute devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in class org.eclipse.che.api.devfile.server.DevfileConverterTest | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Change Attribute Type devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in class org.eclipse.che.api.devfile.server.DevfileManagerTest | From | To | |
| Change Attribute Type devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in class org.eclipse.che.api.devfile.server.DevfileConverterTest | From | To | |
| Extract Method | 9 | ||
| Extract Method private getTestResource(resource String) : String extracted from public shouldThrowExceptionWhenUnconvertableContentProvided() : void in class org.eclipse.che.api.devfile.server.DevfileManagerTest | From | To | |
| Extract Method private getTestResource(resource String) : String extracted from public testValidateAndConvert() : void in class org.eclipse.che.api.devfile.server.DevfileManagerTest | From | To | |
| Extract Method private fillInCommands(config WorkspaceConfigImpl, devfile Devfile) : void extracted from public devFileToWorkspaceConfig(devfile Devfile, recipeFileContentProvider RecipeFileContentProvider) : WorkspaceConfigImpl in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Extract Method private getTestResource(resource String) : String extracted from public shouldBuildYamlDevFileFromWorkspaceConfig() : void in class org.eclipse.che.api.devfile.server.DevfileConverterTest | From | To | |
| Extract Method private fillInTools(config WorkspaceConfigImpl, devfile Devfile, contentProvider RecipeFileContentProvider) : void extracted from public devFileToWorkspaceConfig(devfile Devfile, recipeFileContentProvider RecipeFileContentProvider) : WorkspaceConfigImpl in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Extract Method private getTestResource(resource String) : String extracted from public shouldBuildWorkspaceConfigFromYamlDevFile() : void in class org.eclipse.che.api.devfile.server.DevfileConverterTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter recipeFileContentProvider : RecipeFileContentProvider to contentProvider : RecipeFileContentProvider in method public devFileToWorkspaceConfig(devfile Devfile, contentProvider RecipeFileContentProvider) : WorkspaceConfigImpl in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To | |
| Rename Parameter devfileEnvironmentFactory : DevfileEnvironmentFactory to kubernetesToolApplier : KubernetesToolApplier in method public DevfileConverter(kubernetesToolApplier KubernetesToolApplier) in class org.eclipse.che.api.devfile.server.DevfileConverter | From | To |