38ff5c084b5901960cc8825894e0677dd2ba93a7
Files Diff
- Added: 20
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public shouldProcessingRequestThenCreateHttpSessionAndPutUserIntoHttpSession() : void renamed to public testProcessRequestWithSubjectFromSession() : void in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Rename Variable | 4 | ||
| Rename Variable machineToken : String to token : String in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Rename Variable machineUser : Subject to subject : SubjectImpl in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Rename Variable subject : Subject to authorizedSubject : Subject in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.server.MachineLoginFilter | From | To | |
| Rename Variable tokenString : String to token : String in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.server.MachineLoginFilter | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private PRINCIPAL : String in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute registry : MachineTokenRegistry to tokenRegistry : MachineTokenRegistry in method public removeTokensShouldReturnUserToTokenMap() : void in class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenRegistryTest | From | To | |
| Rename Attribute | 6 | ||
| Rename Attribute USERNAME : String to USER_NAME : String in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Rename Attribute apiEndpoint : String to publicKey : PublicKey in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Rename Attribute servletResponseMock : HttpServletResponse to responseMock : HttpServletResponse in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Rename Attribute requestFactory : HttpJsonRequestFactory to workspaceId : String in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Rename Attribute MACHINE_TOKEN : String to machineToken : String in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Rename Attribute userMock : UserDto to subject : Subject in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Extract Variable | 5 | ||
| Extract Variable workspace1 : String in method public removeTokensShouldReturnUserToTokenMap() : void from class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenRegistryTest | From | To | |
| Extract Variable workspace2 : String in method public removeTokensShouldReturnUserToTokenMap() : void from class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenRegistryTest | From | To | |
| Extract Variable user1 : String in method public removeTokensShouldReturnUserToTokenMap() : void from class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenRegistryTest | From | To | |
| Extract Variable user2 : String in method public removeTokensShouldReturnUserToTokenMap() : void from class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenRegistryTest | From | To | |
| Extract Variable userName : String in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void from class org.eclipse.che.multiuser.machine.authentication.server.MachineLoginFilter | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type machineUser : Subject to subject : SubjectImpl in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Extract Method | 1 | ||
| Extract Method private createToken(userId String, workspaceId String) : String extracted from public getOrCreateToken(userId String, workspaceId String) : String in class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenRegistry | From | To | |
| Split Attribute | 2 | ||
| Split Attribute machineSubject : Subject to [subject : Subject, machineToken : String] in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Split Attribute jsonResponseMock : HttpJsonResponse to [PRINCIPAL : String, sessionMock : HttpSession] in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type apiEndpoint : String to publicKey : PublicKey in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Change Attribute Type requestFactory : HttpJsonRequestFactory to workspaceId : String in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Change Attribute Type userMock : UserDto to subject : Subject in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilterTest | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter apiEndpoint : String to workspaceId : String in method public MachineLoginFilter(workspaceId String, publicKey PublicKey, tokenExtractor RequestTokenExtractor) in class org.eclipse.che.multiuser.machine.authentication.agent.MachineLoginFilter | From | To | |
| Rename Parameter filterChain : FilterChain to chain : FilterChain in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.server.MachineLoginFilter | From | To | |
| Rename Parameter servletRequest : ServletRequest to request : ServletRequest in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.server.MachineLoginFilter | From | To | |
| Rename Parameter servletResponse : ServletResponse to response : ServletResponse in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.eclipse.che.multiuser.machine.authentication.server.MachineLoginFilter | From | To |