4b155fa57a67c2e9137b11c7dabf3a4840e878f4
Files Diff
- Added: 28
- Removed: 8
- Renamed: 0
- Modified: 50
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 6 | ||
| Pull Up Method public getName() : String from class org.eclipse.che.plugin.docker.machine.DockerProcess to public getName() : String from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Pull Up Method public getType() : String from class org.eclipse.che.plugin.docker.machine.DockerProcess to public getType() : String from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Pull Up Method public getAttributes() : Map<String,String> from class org.eclipse.che.plugin.docker.machine.DockerProcess to public getAttributes() : Map<String,String> from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Pull Up Method public getCommandLine() : String from class org.eclipse.che.plugin.docker.machine.DockerProcess to public getCommandLine() : String from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Pull Up Method public getPid() : int from class org.eclipse.che.plugin.docker.machine.DockerProcess to public getPid() : int from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Pull Up Method public getOutputChannel() : String from class org.eclipse.che.plugin.docker.machine.DockerProcess to public getOutputChannel() : String from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method package getRecipeByLocation(machineConfig MachineConfig) : Recipe from class org.eclipse.che.api.machine.server.MachineManager to public getRecipe(machineConfig MachineConfig) : RecipeImpl from class org.eclipse.che.api.machine.server.util.RecipeDownloader | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type machineConfig : MachineConfig to machineConfig : MachineConfigImpl in method private createMachine(machineConfig MachineConfigImpl, workspaceId String, environmentName String, instanceCreator MachineInstanceCreator, snapshot SnapshotImpl) : MachineImpl in class org.eclipse.che.api.machine.server.MachineManager | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute private pid : int from class org.eclipse.che.plugin.docker.machine.DockerProcess to private pid : int from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Pull Up Attribute private attributes : Map<String,String> from class org.eclipse.che.plugin.docker.machine.DockerProcess to private attributes : Map<String,String> from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Pull Up Attribute private outputChannel : String from class org.eclipse.che.plugin.docker.machine.DockerProcess to private outputChannel : String from class org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess | From | To | |
| Change Return Type | 3 | ||
| Change Return Type MachineSource to MachineSourceImpl in method public getSource() : MachineSourceImpl in class org.eclipse.che.api.machine.server.model.impl.MachineConfigImpl | From | To | |
| Change Return Type Limits to LimitsImpl in method public getLimits() : LimitsImpl in class org.eclipse.che.api.machine.server.model.impl.MachineConfigImpl | From | To | |
| Change Return Type Recipe to RecipeImpl in method public getRecipe(machineConfig MachineConfig) : RecipeImpl in class org.eclipse.che.api.machine.server.util.RecipeDownloader | From | To | |
| Move Attribute | 4 | ||
| Move Attribute public START_TERMINAL_COMMAND : String from class org.eclipse.che.plugin.docker.machine.ext.DockerMachineTerminalLauncher to public START_TERMINAL_COMMAND : String from class org.eclipse.che.plugin.docker.machine.DockerMachineImplTerminalLauncher | From | To | |
| Move Attribute private terminalStartCommand : String from class org.eclipse.che.plugin.docker.machine.ext.DockerMachineTerminalLauncher to private terminalStartCommand : String from class org.eclipse.che.plugin.docker.machine.DockerMachineImplTerminalLauncher | From | To | |
| Move Attribute private apiEndpoint : String from class org.eclipse.che.api.machine.server.MachineManager to private apiEndpoint : String from class org.eclipse.che.api.machine.server.util.RecipeDownloader | From | To | |
| Move Attribute private docker : DockerConnector from class org.eclipse.che.plugin.docker.machine.ext.DockerMachineTerminalLauncher to private docker : DockerConnector from class org.eclipse.che.plugin.docker.machine.DockerMachineImplTerminalLauncher | From | To | |
| Extract Class | 2 | ||
| Extract Class org.eclipse.che.api.machine.server.util.RecipeDownloader from class org.eclipse.che.api.machine.server.MachineManager | From | To | |
| Extract Class org.eclipse.che.plugin.docker.machine.DockerMachineImplTerminalLauncher from class org.eclipse.che.plugin.docker.machine.ext.DockerMachineTerminalLauncher | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.eclipse.che.plugin.docker.machine.ext.DockerMachineTerminalLauncher moved and renamed to org.eclipse.che.api.machine.server.terminal.MachineTerminalLauncher | From | To | |
| Move Class | 7 | ||
| Move Class org.eclipse.che.api.machine.server.WsAgentLauncherImplTest moved to org.eclipse.che.api.machine.server.wsagent.WsAgentLauncherImplTest | From | To | |
| Move Class org.eclipse.che.api.machine.server.impl.AbstractInstance moved to org.eclipse.che.api.machine.server.spi.impl.AbstractInstance | From | To | |
| Move Class org.eclipse.che.api.machine.server.InstanceStateEvent moved to org.eclipse.che.api.machine.server.event.InstanceStateEvent | From | To | |
| Move Class org.eclipse.che.api.machine.server.impl.InstanceKeyImpl moved to org.eclipse.che.api.machine.server.spi.impl.InstanceKeyImpl | From | To | |
| Move Class org.eclipse.che.api.machine.server.WsAgentLauncher moved to org.eclipse.che.api.machine.wsagent.WsAgentLauncher | From | To | |
| Move Class org.eclipse.che.api.machine.server.impl.SnapshotImpl moved to org.eclipse.che.api.machine.server.model.impl.SnapshotImpl | From | To | |
| Move Class org.eclipse.che.api.machine.server.WsAgentLauncherImpl moved to org.eclipse.che.api.machine.wsagent.WsAgentLauncherImpl | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.eclipse.che.api.machine.server.spi.impl.AbstractMachineProcess from classes [org.eclipse.che.plugin.docker.machine.DockerProcess] | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute apiEndpoint : String to recipeDownloader : RecipeDownloader in class org.eclipse.che.api.machine.server.MachineManager | From | To | |
| Rename Attribute terminalStartCommand : String to terminalLaunchers : Map<String,MachineImplSpecificTerminalLauncher> in class org.eclipse.che.api.machine.server.terminal.MachineTerminalLauncher | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type apiEndpoint : String to recipeDownloader : RecipeDownloader in class org.eclipse.che.api.machine.server.MachineManager | From | To | |
| Change Attribute Type terminalStartCommand : String to terminalLaunchers : Map<String,MachineImplSpecificTerminalLauncher> in class org.eclipse.che.api.machine.server.terminal.MachineTerminalLauncher | From | To | |
| Change Attribute Type launcher : DockerMachineTerminalLauncher to launcher : DockerMachineImplTerminalLauncher in class org.eclipse.che.plugin.docker.machine.DockerMachineTerminalLauncherTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter overwrite : boolean to overwriteDirNonDir : boolean in method public copy(sourceMachine Instance, sourcePath String, targetPath String, overwriteDirNonDir boolean) : void in class org.eclipse.che.api.machine.server.spi.Instance | From | To | |
| Rename Parameter overwrite : boolean to overwriteDirNonDir : boolean in method public copy(sourceMachine Instance, sourcePath String, targetPath String, overwriteDirNonDir boolean) : void in class org.eclipse.che.plugin.docker.machine.DockerInstance | From | To |