6100119a6834379b70a55703f0080c72fcc426c0
Files Diff
- Added: 18
- Removed: 7
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 4 | ||
| Move And Rename Method public shouldSetMemoryLimitFromExtendedMachineInDockerfileEnv() : void from class org.eclipse.che.api.environment.server.EnvironmentParserTest to public shouldBeAbleToParseDockerfileEnvironmentFromLocation() : void from class org.eclipse.che.plugin.docker.machine.parser.DockerfileEnvironmentParserTest | From | To | |
| Move And Rename Method public shouldBeAbleToParseDockerimageEnvironment() : void from class org.eclipse.che.api.environment.server.EnvironmentParserTest to public shouldBeAbleToParseDockerImageEnvironment() : void from class org.eclipse.che.plugin.docker.machine.parser.DockerImageEnvironmentParserTest | From | To | |
| Move And Rename Method public shouldSetMemoryLimitFromExtendedMachineInDockerimageEnv() : void from class org.eclipse.che.api.environment.server.EnvironmentParserTest to public shouldBeAbleToParseDockerImageEnvironment() : void from class org.eclipse.che.plugin.docker.machine.parser.DockerImageEnvironmentParserTest | From | To | |
| Move And Rename Method private fromCompose(environment ComposeEnvironmentImpl) : CheServicesEnvironmentImpl from class org.eclipse.che.api.environment.server.EnvironmentParserTest to private createCheServicesEnvByName(name String) : CheServicesEnvironmentImpl from class org.eclipse.che.api.environment.server.CheEnvironmentEngineTest | From | To | |
| Change Parameter Type | 8 | ||
| Change Parameter Type environment : ComposeEnvironmentImpl to environment : ComposeEnvironment in method public ComposeEnvironment(environment ComposeEnvironment) in class org.eclipse.che.plugin.docker.compose.ComposeEnvironment | From | To | |
| Change Parameter Type environment : ComposeEnvironmentImpl to name : String in method private createCheServicesEnvByName(name String) : CheServicesEnvironmentImpl in class org.eclipse.che.api.environment.server.CheEnvironmentEngineTest | From | To | |
| Change Parameter Type build : BuildContextImpl to build : BuildContext in method public setBuild(build BuildContext) : void in class org.eclipse.che.plugin.docker.compose.ComposeServiceImpl | From | To | |
| Change Parameter Type composeFileParser : ComposeFileParser to environmentParsers : Map<String,TypeSpecificEnvironmentParser> in method public EnvironmentParser(environmentParsers Map<String,TypeSpecificEnvironmentParser>) in class org.eclipse.che.api.environment.server.EnvironmentParser | From | To | |
| Change Parameter Type composeEnvironment : ComposeEnvironmentImpl to composeEnvironment : ComposeEnvironment in method public toYaml(composeEnvironment ComposeEnvironment) : String in class org.eclipse.che.plugin.docker.compose.yaml.ComposeEnvironmentParser | From | To | |
| Change Parameter Type composeEnvironment : ComposeEnvironmentImpl to parsedCheEnv : CheServicesEnvironmentImpl in method public shouldAddPortsAndLabelsFromExtendedMachineServers(environment EnvironmentImpl, expectedEnv CheServicesEnvironmentImpl, parsedCheEnv CheServicesEnvironmentImpl) : void in class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To | |
| Change Parameter Type buildContext : BuildContextImpl to buildContext : BuildContext in method public BuildContext(buildContext BuildContext) in class org.eclipse.che.plugin.docker.compose.BuildContext | From | To | |
| Change Parameter Type build : BuildContextImpl to build : BuildContext in method public withBuild(build BuildContext) : ComposeServiceImpl in class org.eclipse.che.plugin.docker.compose.ComposeServiceImpl | From | To | |
| Move Method | 4 | ||
| Move Method public shouldBeAbleToParseDockerfileEnvironmentFromLocation() : void from class org.eclipse.che.api.environment.server.EnvironmentParserTest to public shouldBeAbleToParseDockerfileEnvironmentFromLocation() : void from class org.eclipse.che.plugin.docker.machine.parser.DockerfileEnvironmentParserTest | From | To | |
| Move Method public shouldThrowExceptionOnParseOfDockerimageEnvWithSeveralExtendedMachines() : void from class org.eclipse.che.api.environment.server.EnvironmentParserTest to public shouldThrowExceptionOnParseOfDockerimageEnvWithSeveralExtendedMachines() : void from class org.eclipse.che.plugin.docker.machine.parser.DockerImageEnvironmentParserTest | From | To | |
| Move Method public shouldBeAbleToParseDockerfileEnvironmentFromContent() : void from class org.eclipse.che.api.environment.server.EnvironmentParserTest to public shouldBeAbleToParseDockerfileEnvironmentFromContent() : void from class org.eclipse.che.plugin.docker.machine.parser.DockerfileEnvironmentParserTest | From | To | |
| Move Method public shouldThrowExceptionOnParseOfDockerfileEnvWithSeveralExtendedMachines() : void from class org.eclipse.che.api.environment.server.EnvironmentParserTest to public shouldThrowExceptionOnParseOfDockerfileEnvWithSeveralExtendedMachines() : void from class org.eclipse.che.plugin.docker.machine.parser.DockerfileEnvironmentParserTest | From | To | |
| Extract Class | 1 | ||
| Extract Class org.eclipse.che.plugin.docker.machine.parser.DockerfileEnvironmentParserTest from class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To | |
| Move And Rename Class | 4 | ||
| Move And Rename Class org.eclipse.che.api.environment.server.compose.EnvironmentContextTest moved and renamed to org.eclipse.che.plugin.docker.compose.yaml.EnvironmentDeserializerTest | From | To | |
| Move And Rename Class org.eclipse.che.api.environment.server.compose.ComposeEnvironmentImpl moved and renamed to org.eclipse.che.plugin.docker.compose.ComposeEnvironment | From | To | |
| Move And Rename Class org.eclipse.che.api.environment.server.compose.ComposeFileParser moved and renamed to org.eclipse.che.plugin.docker.compose.yaml.ComposeEnvironmentParser | From | To | |
| Move And Rename Class org.eclipse.che.api.environment.server.compose.BuildContextImpl moved and renamed to org.eclipse.che.plugin.docker.compose.BuildContext | From | To | |
| Move Class | 3 | ||
| Move Class org.eclipse.che.api.environment.server.compose.BuildContextTest moved to org.eclipse.che.plugin.docker.compose.yaml.BuildContextTest | From | To | |
| Move Class org.eclipse.che.api.environment.server.compose.deserializer.EnvironmentDeserializer moved to org.eclipse.che.plugin.docker.compose.yaml.deserializer.EnvironmentDeserializer | From | To | |
| Move Class org.eclipse.che.api.environment.server.compose.ComposeServiceImpl moved to org.eclipse.che.plugin.docker.compose.ComposeServiceImpl | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type composeEnvironment : ComposeEnvironmentImpl to cheServicesEnvironment : ComposeEnvironment in method public testCorrectContentParsing(content String, expected Map<String,String>) : void in class org.eclipse.che.plugin.docker.compose.yaml.EnvironmentDeserializerTest | From | To | |
| Change Variable Type environmentTypes : List<String> to environmentTypes : Set<String> in method public shouldReturnEnvTypesCoveredByTests() : void in class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To | |
| Change Variable Type that : ComposeEnvironmentImpl to that : ComposeEnvironment in method public equals(o Object) : boolean in class org.eclipse.che.plugin.docker.compose.ComposeEnvironment | From | To | |
| Change Variable Type that : BuildContextImpl to that : BuildContext in method public equals(o Object) : boolean in class org.eclipse.che.plugin.docker.compose.BuildContext | From | To | |
| Change Variable Type composeEnvironment : ComposeEnvironmentImpl to composeEnvironment : ComposeEnvironment in method public parse(recipeContent String, contentType String) : ComposeEnvironment in class org.eclipse.che.plugin.docker.compose.yaml.ComposeEnvironmentParser | From | To | |
| Change Variable Type composeEnvironment : ComposeEnvironmentImpl to cheComposeEnv : CheServicesEnvironmentImpl in method private getEntryForComposeEnv(servers Map<String,ServerConf2Impl>, composeExpose List<String>, composeLabels Map<String,String>, expectedExpose List<String>, expectedLabels Map<String,String>) : List<Object> in class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To | |
| Rename Method | 2 | ||
| Rename Method public shouldBeAbleToParseComposeEnvironmentFromContent() : void renamed to public shouldThrowExceptionInCaseFailedParseMemoryLimit() : void in class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To | |
| Rename Method public shouldThrowExceptionOnParseOfDockerfileEnvWithIllegalContentType() : void renamed to public environmentRecipeShouldNotBeNull() : void in class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable composeEnvironment : ComposeEnvironmentImpl to cheServicesEnvironment : ComposeEnvironment in method public testCorrectContentParsing(content String, expected Map<String,String>) : void in class org.eclipse.che.plugin.docker.compose.yaml.EnvironmentDeserializerTest | From | To | |
| Rename Variable composeEnvironment : ComposeEnvironmentImpl to cheComposeEnv : CheServicesEnvironmentImpl in method private getEntryForComposeEnv(servers Map<String,ServerConf2Impl>, composeExpose List<String>, composeLabels Map<String,String>, expectedExpose List<String>, expectedLabels Map<String,String>) : List<Object> in class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To | |
| Inline Method | 1 | ||
| Inline Method private parseDocker(environment Environment) : CheServicesEnvironmentImpl inlined to public parse(environment Environment) : CheServicesEnvironmentImpl in class org.eclipse.che.api.environment.server.EnvironmentParser | From | To | |
| Change Return Type | 8 | ||
| Change Return Type ComposeEnvironmentImpl to ComposeEnvironment in method public parse(recipeContent String, contentType String) : ComposeEnvironment in class org.eclipse.che.plugin.docker.compose.yaml.ComposeEnvironmentParser | From | To | |
| Change Return Type BuildContextImpl to BuildContext in method public withDockerfile(dockerfile String) : BuildContext in class org.eclipse.che.plugin.docker.compose.BuildContext | From | To | |
| Change Return Type BuildContextImpl to BuildContext in method public withContext(context String) : BuildContext in class org.eclipse.che.plugin.docker.compose.BuildContext | From | To | |
| Change Return Type List<String> to Set<String> in method public getEnvironmentTypes() : Set<String> in class org.eclipse.che.api.environment.server.EnvironmentParser | From | To | |
| Change Return Type ComposeEnvironmentImpl to ComposeEnvironment in method public withVersion(version String) : ComposeEnvironment in class org.eclipse.che.plugin.docker.compose.ComposeEnvironment | From | To | |
| Change Return Type BuildContextImpl to BuildContext in method public withArgs(args Map<String,String>) : BuildContext in class org.eclipse.che.plugin.docker.compose.BuildContext | From | To | |
| Change Return Type BuildContextImpl to BuildContext in method public getBuild() : BuildContext in class org.eclipse.che.plugin.docker.compose.ComposeServiceImpl | From | To | |
| Change Return Type ComposeEnvironmentImpl to ComposeEnvironment in method public withServices(services Map<String,ComposeServiceImpl>) : ComposeEnvironment in class org.eclipse.che.plugin.docker.compose.ComposeEnvironment | From | To | |
| Change Package | 1 | ||
| Change Package org.eclipse.che.api.environment.server.compose to org.eclipse.che.plugin.docker.compose.yaml | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type parser : ComposeFileParser to parser : ComposeEnvironmentParser in class org.eclipse.che.plugin.docker.compose.yaml.BuildContextTest | From | To | |
| Change Attribute Type build : BuildContextImpl to build : BuildContext in class org.eclipse.che.plugin.docker.compose.ComposeServiceImpl | From | To | |
| Change Attribute Type parser : ComposeFileParser to parser : ComposeEnvironmentParser in class org.eclipse.che.plugin.docker.compose.yaml.EnvironmentDeserializerTest | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter environment : ComposeEnvironmentImpl to name : String in method private createCheServicesEnvByName(name String) : CheServicesEnvironmentImpl in class org.eclipse.che.api.environment.server.CheEnvironmentEngineTest | From | To | |
| Rename Parameter composeFileParser : ComposeFileParser to environmentParsers : Map<String,TypeSpecificEnvironmentParser> in method public EnvironmentParser(environmentParsers Map<String,TypeSpecificEnvironmentParser>) in class org.eclipse.che.api.environment.server.EnvironmentParser | From | To | |
| Rename Parameter composeEnvironment : ComposeEnvironmentImpl to parsedCheEnv : CheServicesEnvironmentImpl in method public shouldAddPortsAndLabelsFromExtendedMachineServers(environment EnvironmentImpl, expectedEnv CheServicesEnvironmentImpl, parsedCheEnv CheServicesEnvironmentImpl) : void in class org.eclipse.che.api.environment.server.EnvironmentParserTest | From | To |