7312af9fdbdc59364b219ce91c8aa1a0d12d494e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public validateBySchema(yamlContent String) : JsonNode renamed to private validate(content String, mapper ObjectMapper) : JsonNode in class org.eclipse.che.api.workspace.server.devfile.validator.DevfileSchemaValidator | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type devfileConverter : DevfileConverter to devfileIntegrityValidator : DevfileIntegrityValidator in method public LimitsCheckingWorkspaceManager(workspaceDao WorkspaceDao, runtimes WorkspaceRuntimes, eventService EventService, accountManager AccountManager, workspaceValidator WorkspaceValidator, maxRamPerEnv String, environmentRamCalculator EnvironmentRamCalculator, resourceManager ResourceManager, resourcesLocks ResourcesLocks, devfileIntegrityValidator DevfileIntegrityValidator) in class org.eclipse.che.multiuser.resource.api.workspace.LimitsCheckingWorkspaceManager | From | To | |
| Change Parameter Type devfile : DevfileDto to devfile : String in method public create(devfile String, attrsList List<String>, startAfterCreate Boolean, namespace String, contentType MediaType) : Response in class org.eclipse.che.api.workspace.server.WorkspaceService | From | To | |
| Change Return Type | 1 | ||
| Change Return Type DevfileDto to DevfileDtoImpl in method private createDevfileDto() : DevfileDtoImpl in class org.eclipse.che.api.workspace.server.WorkspaceServiceTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute yamlReader : ObjectMapper to yamlMapper : ObjectMapper in class org.eclipse.che.api.workspace.server.devfile.validator.DevfileSchemaValidator | From | To | |
| Rename Attribute jsonWriter : ObjectMapper to jsonMapper : ObjectMapper in class org.eclipse.che.api.workspace.server.devfile.validator.DevfileSchemaValidator | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type devfileDto : DevfileDto to devfileDto : DevfileDtoImpl in method public shouldCreateWorkspaceFromDevfile() : void in class org.eclipse.che.api.workspace.server.WorkspaceServiceTest | From | To | |
| Extract Method | 1 | ||
| Extract Method private validate(contentNode JsonNode) : void extracted from public validateBySchema(yamlContent String) : JsonNode in class org.eclipse.che.api.workspace.server.devfile.validator.DevfileSchemaValidator | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter devfileConverter : DevfileConverter to devfileIntegrityValidator : DevfileIntegrityValidator in method public LimitsCheckingWorkspaceManager(workspaceDao WorkspaceDao, runtimes WorkspaceRuntimes, eventService EventService, accountManager AccountManager, workspaceValidator WorkspaceValidator, maxRamPerEnv String, environmentRamCalculator EnvironmentRamCalculator, resourceManager ResourceManager, resourcesLocks ResourcesLocks, devfileIntegrityValidator DevfileIntegrityValidator) in class org.eclipse.che.multiuser.resource.api.workspace.LimitsCheckingWorkspaceManager | From | To | |
| Rename Parameter yamlContent : String to content : String in method private validate(content String, mapper ObjectMapper) : JsonNode in class org.eclipse.che.api.workspace.server.devfile.validator.DevfileSchemaValidator | From | To | |
| Rename Parameter devfileContent : String to content : String in method private parse(content String, validationFunction ValidationFunction) : DevfileImpl in class org.eclipse.che.api.workspace.server.devfile.DevfileManager | From | To |