7627ea4dde4120a1b3b7b1dc2bfa6321052320b9
Files Diff
- Added: 5
- Removed: 1
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private doPrepare(name String, client KubernetesClient) : void renamed to package prepare() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.KubernetesNamespace | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type kubernetesMachine : KubernetesMachine to kubernetesMachine : KubernetesMachineImpl in method public KubernetesBootstrapper(runtimeIdentity RuntimeIdentity, installers List<? extends Installer>, kubernetesMachine KubernetesMachineImpl, namespace KubernetesNamespace, cheWebsocketEndpoint String, bootstrapperBinaryUrl String, installerTimeoutSeconds int, serverCheckPeriodSeconds int, logsRootPath String, eventService EventService) in class org.eclipse.che.workspace.infrastructure.kubernetes.bootstrapper.KubernetesBootstrapper | From | To | |
| Change Parameter Type machine : KubernetesMachine to machine : KubernetesMachineImpl in method private bootstrap(toCancelFutures List<CompletableFuture<?>>, machine KubernetesMachineImpl) : Function<Void,CompletionStage<Void>> in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Parameter Type machine : KubernetesMachine to machine : KubernetesMachineImpl in method private checkServers(toCancelFutures List<CompletableFuture<?>>, machine KubernetesMachineImpl) : Function<Void,CompletionStage<Void>> in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Move Method | 4 | ||
| Move Method public exec(outputConsumer BiConsumer<String,String>, command String...) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesMachine to private exec(outputConsumer BiConsumer<String,String>, command String...) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.bootstrapper.KubernetesBootstrapper | From | To | |
| Move Method public exec(command String...) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesMachine to private exec(command String...) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.bootstrapper.KubernetesBootstrapper | From | To | |
| Move Method public getName() : String from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesMachine to public getName() : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.KubernetesNamespace | From | To | |
| Move Method public waitRunningAsync() : CompletableFuture<Void> from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesMachine to public waitRunningAsync(toCancelFutures List<CompletableFuture<?>>, machine KubernetesMachineImpl) : CompletableFuture<Void> from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Rename Variable | 1 | ||
| Rename Variable machineRunningFuture : CompletableFuture<Void> to machineName : String in method protected internalStart(startOptions Map<String,String>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Return Type | 3 | ||
| Change Return Type KubernetesInternalRuntime to OpenShiftInternalRuntime in method public getRuntime() : OpenShiftInternalRuntime in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftRuntimeContext | From | To | |
| Change Return Type Map<String,? extends Server> to Map<String,KubernetesServerImpl> in method public getServers() : Map<String,KubernetesServerImpl> in class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesMachineImpl | From | To | |
| Change Return Type Map<String,? extends KubernetesMachine> to Map<String,? extends KubernetesMachineImpl> in method public getInternalMachines() : Map<String,? extends KubernetesMachineImpl> in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private EXEC_TIMEOUT_MIN : int from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesMachine to private EXEC_TIMEOUT_MIN : int from class org.eclipse.che.workspace.infrastructure.kubernetes.bootstrapper.KubernetesBootstrapper | From | To | |
| Move Attribute private namespace : KubernetesNamespace from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesMachine to private namespace : KubernetesNamespace from class org.eclipse.che.workspace.infrastructure.kubernetes.bootstrapper.KubernetesBootstrapper | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesMachine moved and renamed to org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesMachineImpl | From | To | |
| Extract Variable | 4 | ||
| Extract Variable workspaceId : String in method public getRuntime() : KubernetesInternalRuntime from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesRuntimeContext | From | To | |
| Extract Variable workspaceId : String in method public getRuntime() : OpenShiftInternalRuntime from class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftRuntimeContext | From | To | |
| Extract Variable identity : RuntimeIdentity in method protected internalStop(stopOptions Map<String,String>) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Extract Variable identity : RuntimeIdentity in method public accept(serverRef String) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.ServerReadinessHandler | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type entry : Entry<String,KubernetesMachine> to entry : Entry<String,KubernetesMachineImpl> in method public handle(event ContainerEvent) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.MachineLogsPublisher | From | To | |
| Change Variable Type machineRunningFuture : CompletableFuture<Void> to machineName : String in method protected internalStart(startOptions Map<String,String>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Variable Type machine : KubernetesMachine to machine : KubernetesMachineImpl in method public handle(event ContainerEvent) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.MachineLogsPublisher | From | To | |
| Change Variable Type machine : KubernetesMachine to machine : KubernetesMachineImpl in method protected internalStart(startOptions Map<String,String>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type machines : Map<String,KubernetesMachine> to machines : KubernetesMachineCache in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Attribute Type kubernetesMachine : KubernetesMachine to kubernetesMachine : KubernetesMachineImpl in class org.eclipse.che.workspace.infrastructure.kubernetes.bootstrapper.KubernetesBootstrapper | From | To |